Split out propane and fuel oil no 2 energy results #300
+115,242
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split out propane and fuel oil no 2 in the simulation output report measure. Update measure to OS 2.0+ ReportingMeasure. Add tests to confirm new variables. Add variables to postprocessing column definitions.
mdahlhausen
added
reporting measure
mdahlhausen
changed the title
|
Had to make some postprocessing changes. Doing a new run with the change and will check postprocessing before merging. |
- change from fuel_oil_no2 to fuel_oil - move buildstock.rb functions into measure.rb instead of requiring buildstock.rb. This allows the measure to run both in buildstock and in the measure tests.
asparke2
previously approved these changes
Mar 20, 2025
postprocessing/comstockpostproc/resources/comstock_enumeration_definitions.csv
Show resolved
Hide resolved
asparke2
previously approved these changes
Apr 2, 2025
There was a problem hiding this comment.
@mdahlhausen Code looks good, merge assuming that the postprocessing works on a 10k run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Split out propane and fuel oil no 2 in the simulation output report measure.
Update measure to OS 2.0+ ReportingMeasure.
Add tests to confirm new variables.
Add variables to postprocessing column definitions.
Fixes Split out propane and fuel oil in annual results #87
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csvtest/reporting_measure_tests.txt,test/workflow_measure_tests.txt, ortest/upgrade_measure_tests.txtReview Checklist
This will not be exhaustively relevant to every PR.