Skip to content

utility bill percent savings calculation fix #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JanghyunJK
Copy link
Contributor

@JanghyunJK JanghyunJK commented Apr 3, 2025

Pull request overview

  • extension of this past PR: percentage savings calculation fix in post-processing #271

  • pretty much trying to do the same for the new utility bill savings calculation that happened after that previous PR

  • before this PR - datapoints representing 'fraction' although axis title is in %:
    image

  • after this PR - datapoints representing 'percentage':
    image

  • checked the other figures and didn't find any side effect causing changes in other figures

  • but thanks to @ChristopherCaradonna @asparke2 for conceptually fixing this already 🤟

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/reporting_measure_tests.txt, test/workflow_measure_tests.txt, or test/upgrade_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

@JanghyunJK JanghyunJK self-assigned this Apr 3, 2025
@JanghyunJK JanghyunJK added the postprocessing PR improves or adds postprocessing content label Apr 3, 2025
@JanghyunJK JanghyunJK changed the base branch from main to ccaradon/sdr_2025_r2 April 3, 2025 13:22
@JanghyunJK JanghyunJK removed their assignment Apr 4, 2025
@JanghyunJK JanghyunJK changed the title [WIP] utility bill percent savings calculation fix utility bill percent savings calculation fix Apr 4, 2025
@ChristopherCaradonna ChristopherCaradonna merged commit a797be6 into ccaradon/sdr_2025_r2 Apr 17, 2025
@ChristopherCaradonna ChristopherCaradonna deleted the jk/utility-bill-pcnt-savings-calc-fix branch April 17, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postprocessing PR improves or adds postprocessing content Pull Request - Ready for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants