-
Notifications
You must be signed in to change notification settings - Fork 26
EEDF: add new demand flexibility output variables related to the grid peak load reduction objective #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EEDF: add new demand flexibility output variables related to the grid peak load reduction objective #324
Conversation
measures/qoi_report/measure.rb
Outdated
def mean_daily_peak_by_month | ||
output_names = [] | ||
months.each do |month, _month_val| | ||
output_names << "mean_daily_peak_use_#{month}_kw" | ||
end | ||
output_names | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this instead work?
def min_daily_peak_by_month
months.keys.map { |month| "minimum_daily_peak_#{month}_kw" }
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and if does, I guess we can trim a lot of lines with the methods with similar structure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm following the format/definition used for the previous variables developed by whoever first create this measure. Do we want to refactor this measure now given the limited timeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this structural change seems reasonable and sort of similar to how it worked for me for the other cases
COLS_QOI_MONTHLY_MEAN_DAILY_PEAK = [ | ||
'out.qoi.mean_daily_peak_jan..kw', | ||
'out.qoi.mean_daily_peak_feb..kw', | ||
'out.qoi.mean_daily_peak_mar..kw', | ||
'out.qoi.mean_daily_peak_apr..kw', | ||
'out.qoi.mean_daily_peak_may..kw', | ||
'out.qoi.mean_daily_peak_jun..kw', | ||
'out.qoi.mean_daily_peak_jul..kw', | ||
'out.qoi.mean_daily_peak_aug..kw', | ||
'out.qoi.mean_daily_peak_sep..kw', | ||
'out.qoi.mean_daily_peak_oct..kw', | ||
'out.qoi.mean_daily_peak_nov..kw', | ||
'out.qoi.mean_daily_peak_dec..kw' | ||
] | ||
|
||
COLS_QOI_MONTHLY_MEAN_DAILY_PEAK_GRID_WIN = [ | ||
'out.qoi.mean_daily_peak_grid_window_jan..kw', | ||
'out.qoi.mean_daily_peak_grid_window_feb..kw', | ||
'out.qoi.mean_daily_peak_grid_window_mar..kw', | ||
'out.qoi.mean_daily_peak_grid_window_apr..kw', | ||
'out.qoi.mean_daily_peak_grid_window_may..kw', | ||
'out.qoi.mean_daily_peak_grid_window_jun..kw', | ||
'out.qoi.mean_daily_peak_grid_window_jul..kw', | ||
'out.qoi.mean_daily_peak_grid_window_aug..kw', | ||
'out.qoi.mean_daily_peak_grid_window_sep..kw', | ||
'out.qoi.mean_daily_peak_grid_window_oct..kw', | ||
'out.qoi.mean_daily_peak_grid_window_nov..kw', | ||
'out.qoi.mean_daily_peak_grid_window_dec..kw' | ||
] | ||
|
||
COLS_QOI_MONTHLY_MEAN_DAILY_PEAK_GRID_PEAK = [ | ||
'out.qoi.mean_daily_peak_grid_peak_jan..kw', | ||
'out.qoi.mean_daily_peak_grid_peak_feb..kw', | ||
'out.qoi.mean_daily_peak_grid_peak_mar..kw', | ||
'out.qoi.mean_daily_peak_grid_peak_apr..kw', | ||
'out.qoi.mean_daily_peak_grid_peak_may..kw', | ||
'out.qoi.mean_daily_peak_grid_peak_jun..kw', | ||
'out.qoi.mean_daily_peak_grid_peak_jul..kw', | ||
'out.qoi.mean_daily_peak_grid_peak_aug..kw', | ||
'out.qoi.mean_daily_peak_grid_peak_sep..kw', | ||
'out.qoi.mean_daily_peak_grid_peak_oct..kw', | ||
'out.qoi.mean_daily_peak_grid_peak_nov..kw', | ||
'out.qoi.mean_daily_peak_grid_peak_dec..kw' | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes sense too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some comments but approving! thanks!
Going to merge this to the DF branch after confirming with spot checks on 10k test. |
Pull request overview
3 changes are present in this PR to add new DF metrics in reporting & postprocessing:
measures\qoi_report\measure.rb
, where the mean peak during grid peak window (4 hour) by month, and the mean peak on grid peak (1 hour) by month, are calculated. Since the grid peaks are determined/sourced from the Cambium load data in the DF measures, we add the same resources into the reporting measure, so the measure will read the Cambium grid load data and generate the grid peak schedule to extract the building load corresponding to the grid peak schedule.postprocessing\comstockpostproc\resources\comstock_column_definitions.csv
andpostprocessing\comstockpostproc\naming_mixin.py
to include all these new variables, and clean up for unnecessary variablespostprocessing\comstockpostproc\comstock.py
, such asintensity
,savings
,'percent_savings`, which are also added into the column definition file, but set to FALSE to both basic and full metadata to avoid giant changes (~180 more columns) to the actual data release.Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/reporting_measure_tests.txt
,test/workflow_measure_tests.txt
, ortest/upgrade_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File