-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/more data in train history #49
Conversation
plt.tight_layout() | ||
|
||
|
||
fig2, ax2 = plt.subplots(3, 1, sharex=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -151,9 +149,62 @@ | |||
ax[-1].set_ylabel('Speed [m/s]') | |||
ax[-1].legend() | |||
plt.suptitle("Speed Limit Train Sim Demo") | |||
|
|||
fig1, ax1 = plt.subplots(3, 1, sharex=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

@SWRIganderson , I'd sure appreciate some serious scrutiny on this plot and similar plots in other contexts
@calbaker I spent some time on Saturday looking into this on Saturday, but I did not finish. So far things look pretty good. The discrepancy that got me sidetracked was the length of the link from the data vs what I was seeing in QGIS. I need to do a bit more digging on that. I'll keep you posted. I should be able to look at it more later today. |
@calbaker I have run this branch on my machine and inspected the results. I believe it is working correctly. I verified this by saving the data at 1 Hz and comparing the maximum link offset to the length of the link. I did this for the first dozen links in the trip. Everything checked out. The thing that I also discovered is that the length calculation that is being done by QGIS may not be taking into account elevation or curvature. I have tracked this partially in the QGIS code, but I haven't run it to ground yet. The link below is how far I have tracked it. The screenshot is from QGIS. They have two different ways of calculating distance. The length in the network file is 7596.7 m. We probably need to understand the differences between all of these calculations to make sure we are getting what we think we are. It may be worth opening an issue maybe aroud this? https://github.com/qgis/QGIS/blob/master/src/analysis/processing/qgsalgorithmextractvertices.cpp |
numerous comments to improve demo readability
Added:
to
TrainState
and corresponding code to store this in history