Skip to content

Adding pytest-pretty for nice test outputs #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

benomahony
Copy link

Description

Closes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented May 2, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@benomahony
Copy link
Author

@mdemoret-nv cleaned up commits + signed

Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Copy link
Contributor

/ok to test eb47bc5

@AnuradhaKaruppiah
Copy link
Contributor

AnuradhaKaruppiah commented May 8, 2025

@benomahony Thanks for the PR.
Please resolve the conflict in uv.lock using the following steps:

git fetch upstream 
git merge upstream/develop
rm uv.lock 
uv sync --all-groups --all-extras
git add uv.lock 
git merge --continue

@dagardner-nv dagardner-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels May 8, 2025
@dagardner-nv dagardner-nv self-assigned this May 16, 2025
@dagardner-nv
Copy link
Contributor

LGTM, on hold for internal approvals

@@ -140,6 +139,7 @@ dev = [
"pytest-asyncio==0.24.*",
"pytest-cov~=6.1",
"pytest~=8.3",
"pytest-pretty>=1.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the ~= operator here, this helps us as a team track our dependencies.

Suggested change
"pytest-pretty>=1.2.0",
"pytest-pretty~=1.2",

"scikit-learn~=1.6",
]
"scikit-learn~=1.6"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the white-space/formatting changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants