Skip to content

Store structure tool inputs #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Store structure tool inputs #196

wants to merge 1 commit into from

Conversation

1ytic
Copy link
Member

@1ytic 1ytic commented May 2, 2025

Store original tool inputs for TOOL_END event in LangchainProfilerHandler.

@1ytic
Store structure tool inputs
7ec3447 
Signed-off-by: Ivan Sorokin <[email protected]>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 2, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

dnandakumar-nv
dnandakumar-nv requested changes May 2, 2025
View reviewed changes
Copy link
Contributor

@dnandakumar-nv dnandakumar-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please also add/modify the callback handler's unit tests to test the updated functionality? The tests can be found here:

AIQToolkit/tests/aiq/profiler/test_callback_handler.py

Line 35 in ca1cff0

async def test_langchain_handler(reactive_stream: Subject):

@1ytic 1ytic marked this pull request as draft May 2, 2025 20:39
@mdemoret-nv mdemoret-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnandakumar-nv dnandakumar-nv dnandakumar-nv requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1ytic @dnandakumar-nv @mdemoret-nv