-
Notifications
You must be signed in to change notification settings - Fork 178
Fix or silence warnings emitted by tests #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dagardner-nv
wants to merge
37
commits into
NVIDIA:develop
Choose a base branch
from
dagardner-nv:david-remove-warnings
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+183
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…being unset Signed-off-by: David Gardner <[email protected]>
…ing about this not being set. Remove definition of pytest_plugins this is not a supported pytest config and triggers a warning Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
…classes to be collected Signed-off-by: David Gardner <[email protected]>
…classes to be collected Signed-off-by: David Gardner <[email protected]>
…re being emitted Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
…ment Signed-off-by: David Gardner <[email protected]>
…dependency on langchain-community (this is currently a transitory dep of ragas) Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
…ove-warnings Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
…use new fixture Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
… pull_intermediate, avoids issue where pull_intermediate is left unawaited when the workflow has multiple outputs Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
…ession_manager, avoids another warning about an unwaited coroutine Signed-off-by: David Gardner <[email protected]>
…e) to avoid warning from the nim client Signed-off-by: David Gardner <[email protected]>
… mem0), remove once qdrant/qdrant-client#983 is resolved Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
…nore, since this warning was also bein emitted from other parts of the code base Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
…ove-warnings Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pytest
now runs without reporting any warnings on 3.12 and reports one in 3.11langchain-community
toaiqtoolkit-test
needed for theDeterministicFakeEmbedding
class (this is currently a transitory dep of ragas)Test
which were not test classes, to prevent pytest from attempting to run them.asyncio.run_coroutine_threadsafe
method, this ensures that coroutines are awaited.src/aiq/eval/evaluate.py
such that coroutines are only started after passing theif not session_manager.workflow.has_single_output
check, and in the event of an exception, cancel any running coroutines in the exception handler.SyntaxWarning
on run qdrant/qdrant-client#983 is released.Closes #308
By Submitting this PR I confirm: