Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update audio to text dataset #12045

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

Jorjeous
Copy link
Collaborator

@Jorjeous Jorjeous commented Feb 4, 2025

What does this PR do ?

Fix error when using transcribe speech parralel on webdataset

Collection: [Note which collection this PR will affect]
ASR

Changelog

  • Add specific line by line info of high level changes in this PR.
  • replacement of error to warning since there is no error

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • [+] Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@Jorjeous Jorjeous requested review from karpnv and nithinraok February 4, 2025 16:30
@Jorjeous Jorjeous self-assigned this Feb 4, 2025
@github-actions github-actions bot added the ASR label Feb 4, 2025
@Jorjeous Jorjeous marked this pull request as ready for review February 4, 2025 16:30
comment removal

Signed-off-by: George <[email protected]>
Copy link
Collaborator Author

@Jorjeous Jorjeous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Jorjeous Jorjeous enabled auto-merge (squash) February 6, 2025 14:17
@Jorjeous Jorjeous requested a review from nithinraok February 7, 2025 13:26
nithinraok
nithinraok previously approved these changes Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

[🤖]: Hi @Jorjeous 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@nithinraok
Copy link
Collaborator

Fix pylint warnings

karpnv
karpnv previously approved these changes Feb 8, 2025
Copy link
Collaborator

@karpnv karpnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karpnv karpnv added Run CICD and removed Run CICD labels Feb 8, 2025
@ko3n1g
Copy link
Collaborator

ko3n1g commented Feb 8, 2025

Please address these errors before: https://github.com/NVIDIA/NeMo/actions/runs/13215343601?pr=12045

@Jorjeous Jorjeous disabled auto-merge February 8, 2025 20:18
@Jorjeous Jorjeous dismissed stale reviews from karpnv and nithinraok via a084154 February 10, 2025 13:12
@Jorjeous Jorjeous mentioned this pull request Feb 21, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants