Refactored forward step #12370
Draft
Refactored forward step #12370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maanug-nv
changed the base branch from
mlm-pretrain-loop
to
maanug/custom-pretrain-api
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nemo/tron/api.py
Outdated
| @@ -42,6 +44,11 @@ | |||
| test_data_iterator = setup_output.test_data_iterator | |||
| ckpt_context = setup_output.checkpointing_context | |||
|
|
|||
| if "state" in inspect.getfullargspec(forward_step_func).args: | |||
| mcore_forward_step = partial(forward_step_func, state=state) | |||
Check warning
Code scanning / CodeQL
Variable defined multiple times
nemo/tron/api.py
Outdated
| if "state" in inspect.getfullargspec(forward_step_func).args: | ||
| mcore_forward_step = partial(forward_step_func, state=state) | ||
| if "cfg" in inspect.getfullargspec(forward_step_func).args: | ||
| mcore_forward_step = partial(forward_step_func, cfg=full_config) |
Check notice
Code scanning / CodeQL
Unused local variable
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 5 days ago
To fix the problem, we should remove the assignment to the variable mcore_forward_step on line 50. This will eliminate the unused variable and clean up the code. Since the variable is not used anywhere else in the function, this change will not affect the existing functionality.
Suggested changeset
1
nemo/tron/api.py
| @@ -49,3 +49,3 @@ | ||
| if "cfg" in inspect.getfullargspec(forward_step_func).args: | ||
| mcore_forward_step = partial(forward_step_func, cfg=full_config) | ||
| partial(forward_step_func, cfg=full_config) | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import contextlib |
Check notice
Code scanning / CodeQL
Unused import
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 5 days ago
To fix the problem, we need to remove the unused import statement for contextlib. This will clean up the code and remove the unnecessary dependency, making the code easier to read and maintain.
- Locate the import statement for
contextlibin the filenemo/tron/llm/gpt.py. - Remove the line that imports
contextlib.
Suggested changeset
1
nemo/tron/llm/gpt.py
| @@ -14,3 +14,2 @@ | ||
|
|
||
| import contextlib | ||
| from functools import partial |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
Base automatically changed from
maanug/custom-pretrain-api
to
mlm-pretrain-loop
February 26, 2025 23:50
maanug-nv
force-pushed
the
maanug/modified-forward-step
branch
from
33fa8b7 to
a291837
Compare
Signed-off-by: Maanu Grover <[email protected]>
Signed-off-by: Maanu Grover <[email protected]>
Signed-off-by: Maanu Grover <[email protected]>
maanug-nv
force-pushed
the
maanug/modified-forward-step
branch
from
a291837 to
27f3f40
Compare
Signed-off-by: Maanu Grover <[email protected]>
|
beep boop 🤖: 🚨 The following files must be fixed before merge! Your code was analyzed with PyLint. The following annotations have been identified: Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Enable the forward step to take global state, so that GlobalState need not be a singleton.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information