Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Improve NeMo installer #12396

Merged
merged 51 commits into from
Mar 2, 2025
Merged

build: Improve NeMo installer #12396

merged 51 commits into from
Mar 2, 2025

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Feb 27, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Contributor

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 27, 2025
Copy link
Contributor

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added the Run CICD label Mar 1, 2025
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Mar 1, 2025
Copy link
Contributor

github-actions bot commented Mar 1, 2025

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Mar 1, 2025
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Mar 1, 2025
Copy link
Contributor

github-actions bot commented Mar 2, 2025

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Mar 2, 2025
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Mar 2, 2025
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Mar 2, 2025
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Mar 2, 2025
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Mar 2, 2025
Copy link
Contributor

github-actions bot commented Mar 2, 2025

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g merged commit c717227 into main Mar 2, 2025
188 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/build/bitsandbytes branch March 2, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants