Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output GenerationConfig for LLMs imported from HF #12403

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

marcromeyn
Copy link
Collaborator

@marcromeyn marcromeyn commented Feb 27, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Allowing models to be served in NIMs automatically by outputting the generation_config from HF.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Contributor

[🤖]: Hi @marcromeyn 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@marcromeyn marcromeyn marked this pull request as ready for review February 27, 2025 17:18
@marcromeyn marcromeyn requested a review from janekl February 28, 2025 10:34
@janekl
Copy link
Collaborator

janekl commented Feb 28, 2025

In the edited files on importing a particular model (Llama, Deepseek, etc.) we are adding instantiation of GenerationConfig as if it exists with:

generation_config = GenerationConfig.from_pretrained(str(self))

I wonder if this assumption is true. Will the import_ckpt call work fine if there is no generation_config.json present in the model directory?

@PeganovAnton pointed out one counterexample https://huggingface.co/nvidia/Minitron-4B-Base/tree/main w/o generation_config.json (though we don't have support for this one).

@janekl
Copy link
Collaborator

janekl commented Feb 28, 2025

LGTM. @marcromeyn could you please add a short description in the MR body under "What does this PR do" on what happens here? Like a command, one-sentence explanation and maybe that nice directory structure pasted (from _build_directory_tree).

I'm asking so that everyone immediately knows that the change here is about getting artifacts/generation_config.json into the context directory

janekl
janekl previously approved these changes Feb 28, 2025
Signed-off-by: Marc Romeyn <[email protected]>
@marcromeyn marcromeyn enabled auto-merge (squash) February 28, 2025 14:33
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 28, 2025
Copy link
Contributor

github-actions bot commented Mar 1, 2025

[🤖]: Hi @marcromeyn 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants