Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add llama 8b 128k recipe and mixtral 8x64k 64k recipe #12412

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

BoxiangW
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

import pytest
import torch

from nemo.collections.llm.api import finetune, pretrain

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'finetune' is not used.

Copilot Autofix AI 3 days ago

To fix the problem, we need to remove the unused import statement. This will clean up the code and remove the unnecessary dependency. Specifically, we will remove the finetune import from the line from nemo.collections.llm.api import finetune, pretrain.

Suggested changeset 1
tests/collections/llm/recipes/test_llama3_8b_128k.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/tests/collections/llm/recipes/test_llama3_8b_128k.py b/tests/collections/llm/recipes/test_llama3_8b_128k.py
--- a/tests/collections/llm/recipes/test_llama3_8b_128k.py
+++ b/tests/collections/llm/recipes/test_llama3_8b_128k.py
@@ -18,3 +18,3 @@
 
-from nemo.collections.llm.api import finetune, pretrain
+from nemo.collections.llm.api import pretrain
 from nemo.collections.llm.gpt.data.mock import MockDataModule
EOF
@@ -18,3 +18,3 @@

from nemo.collections.llm.api import finetune, pretrain
from nemo.collections.llm.api import pretrain
from nemo.collections.llm.gpt.data.mock import MockDataModule
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@BoxiangW BoxiangW self-assigned this Feb 27, 2025
Signed-off-by: Boxiang Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants