Minor updates to ModelOpt and TensorRT-LLM workflows #12422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: janekl <[email protected]>
oyilmaz-nvidia
requested changes
Feb 28, 2025
| @@ -35,6 +34,11 @@ | |||
|
|
|||
| from nemo.collections.common.tokenizers.tokenizer_spec import TokenizerSpec | |||
|
|
|||
| # TODO: Remove modelopt import guarding once it is installable on all platforms | |||
There was a problem hiding this comment.
Can we please remove the TODOs from the code and create issues to track it?
| @@ -38,7 +39,9 @@ | |||
| from nemo.lightning import Trainer | |||
| from nemo.lightning.megatron_parallel import MegatronParallel | |||
|
|
|||
| try: | |||
| # TODO: Remove modelopt import guarding once it is installable on all platforms | |||
There was a problem hiding this comment.
Let's remove the TODOs from here as well.
| HAVE_MODELOPT = False | ||
| HAVE_MODELOPT_ERROR = e | ||
|
|
||
|
|
||
| SUPPORTED_DTYPE = [16, "16", "bf16"] # Default precision for non-quantized layers |
There was a problem hiding this comment.
If it's an Enum, let's define it as an enum in the future. No updated needed right now. Adding it just for future references.
|
[🤖]: Hi @janekl 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
use_mcore_path=FalseinTensorRTLLM.export(...)(devices, num_nodes) = (calibration_tp, calibration_pp)in ptq.py scriptCollection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information