Skip to content

feat: large-scale EP(part 2: MoE Load Balancer - core utilities) #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025

Conversation

dongxuy04
Copy link
Collaborator

C++ and Python bindings for basic utilities for online MoE load balancing. No E2E flow, but some UT and simulated E2E flow.

PR title

Please write the PR title by following template:

[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>

For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like

[TRTLLM-1000][feat] Support a new feature about cache manager

Description

Please explain the issue and the solution in short.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@juney-nvidia juney-nvidia changed the title Moe Load Balance part 1 feat" Moe Load Balance part 1 May 16, 2025
@juney-nvidia juney-nvidia changed the title feat" Moe Load Balance part 1 feat: large-scale EP(part 2: MoE Load Balancer) May 16, 2025
@juney-nvidia juney-nvidia changed the title feat: large-scale EP(part 2: MoE Load Balancer) feat: large-scale EP(part 2: MoE Load Balancer - core utilities) May 16, 2025
@dongxuy04
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5489 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5489 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4004 completed with status: 'FAILURE'

@dongxuy04
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5649 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5649 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4126 completed with status: 'ABORTED'

Copy link
Collaborator

@juney-nvidia juney-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the code are the newly added code, with less intrusion as to the existing code.
LGTM.
Thanks for the hard working.

@dongxuy04
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5697 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5697 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4164 completed with status: 'FAILURE'

@dongxuy04 dongxuy04 force-pushed the user/dongxuy/moe_load_rebalancer branch from 64efa83 to bfcfdc1 Compare May 19, 2025 11:10
@dongxuy04
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5722 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5722 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4183 completed with status: 'FAILURE'

@dongxuy04
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5793 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5793 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4241 completed with status: 'FAILURE'

@dongxuy04
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5817 [ run ] triggered by Bot

@dongxuy04 dongxuy04 marked this pull request as ready for review May 20, 2025 08:56
@tensorrt-cicd
Copy link
Collaborator

PR_Github #5817 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4260 completed with status: 'SUCCESS'

@dongxuy04 dongxuy04 merged commit 21aff2e into NVIDIA:main May 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants