Skip to content

Feat: add chunked-attention kernels on Blackwell #4394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PerkzZheng
Copy link
Collaborator

Feat: add chunked-attention kernels on Blackwell

Please write the PR title by following template:

[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>

For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like

[TRTLLM-1000][feat] Support a new feature about cache manager

Description

Please explain the issue and the solution in short.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@PerkzZheng PerkzZheng requested a review from mikeiovine May 16, 2025 10:34
@PerkzZheng PerkzZheng self-assigned this May 16, 2025
@PerkzZheng
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5506 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5506 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4012 completed with status: 'FAILURE'

@PerkzZheng PerkzZheng force-pushed the user/perkzz/blackwell-chunked-attention branch from 60d2a2e to bf8b662 Compare May 18, 2025 09:57
@PerkzZheng
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5612 [ run ] triggered by Bot

@PerkzZheng PerkzZheng force-pushed the user/perkzz/blackwell-chunked-attention branch from bf8b662 to e4f79be Compare May 18, 2025 14:54
@PerkzZheng
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5619 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5612 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5619 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4104 completed with status: 'FAILURE'

@PerkzZheng PerkzZheng force-pushed the user/perkzz/blackwell-chunked-attention branch from e4f79be to d21f87f Compare May 19, 2025 04:09
@PerkzZheng
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5669 [ run ] triggered by Bot

@PerkzZheng PerkzZheng force-pushed the user/perkzz/blackwell-chunked-attention branch from d21f87f to f7a54d7 Compare May 19, 2025 05:00
@PerkzZheng
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5675 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5669 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5675 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4146 completed with status: 'FAILURE'

@PerkzZheng PerkzZheng force-pushed the user/perkzz/blackwell-chunked-attention branch from f7a54d7 to e0c55b6 Compare May 19, 2025 09:00
@PerkzZheng
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5704 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5704 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4170 completed with status: 'FAILURE'

@PerkzZheng
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5736 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5736 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4193 completed with status: 'SUCCESS'

@PerkzZheng PerkzZheng force-pushed the user/perkzz/blackwell-chunked-attention branch from e0c55b6 to 9b9d9d7 Compare May 20, 2025 02:16
@PerkzZheng
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5802 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5802 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4249 completed with status: 'FAILURE'

@PerkzZheng
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5835 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5835 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4274 completed with status: 'SUCCESS'

@PerkzZheng PerkzZheng force-pushed the user/perkzz/blackwell-chunked-attention branch from 9b9d9d7 to 59e2521 Compare May 20, 2025 09:36
@PerkzZheng
Copy link
Collaborator Author

@mikeiovine can you help merge this PR ? thanks.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5894 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5894 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #5835 for commit 59e2521

@PerkzZheng PerkzZheng force-pushed the user/perkzz/blackwell-chunked-attention branch from 59e2521 to 0b2c215 Compare May 21, 2025 01:39
@PerkzZheng
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5932 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5932 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #5835 for commit 0b2c215

Signed-off-by: Perkz Zheng <[email protected]>
Signed-off-by: Perkz Zheng <[email protected]>

fix

Signed-off-by: Perkz Zheng <[email protected]>
@niukuo niukuo force-pushed the user/perkzz/blackwell-chunked-attention branch from 0b2c215 to 2d2f71f Compare May 21, 2025 02:15
@niukuo niukuo merged commit 426f6fd into NVIDIA:main May 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants