Skip to content

doc: [TRTLLM-325]Integrate the NGC image in Makefile automation and document #4400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025

Conversation

MartinMarciniszyn
Copy link
Collaborator

[TRTLLM-325]Integrate the NGC image in Makefile automation and document

Description

This PR adds automation for deploying images from NGC in Makefile and the corresponding documentation in README.md.

@MartinMarciniszyn MartinMarciniszyn requested a review from kaiyux May 16, 2025 15:00
@MartinMarciniszyn
Copy link
Collaborator Author

/bot run --skip-test

@MartinMarciniszyn MartinMarciniszyn self-assigned this May 16, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #5520 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5520 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4022 (Partly Tested) completed with status: 'FAILURE'

Copy link
Member

@kaiyux kaiyux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes.

@kaiyux
Copy link
Member

kaiyux commented May 18, 2025

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5602 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5602 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4088 (Partly Tested) completed with status: 'FAILURE'

@MartinMarciniszyn MartinMarciniszyn force-pushed the document_ngc_image branch 3 times, most recently from 8595d59 to 45c785e Compare May 19, 2025 14:33
@MartinMarciniszyn
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5741 [ run ] triggered by Bot

@MartinMarciniszyn
Copy link
Collaborator Author

/bot help

Copy link

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@MartinMarciniszyn
Copy link
Collaborator Author

/bot kill

@MartinMarciniszyn
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5743 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5741 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5743 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit fe63449

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5744 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5744 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4199 completed with status: 'FAILURE'

@kaiyux
Copy link
Member

kaiyux commented May 20, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5815 [ run ] triggered by Bot

…ocumentation

Signed-off-by: Martin Marciniszyn Mehringer <[email protected]>
Signed-off-by: Martin Marciniszyn Mehringer <[email protected]>
Signed-off-by: Martin Marciniszyn Mehringer <[email protected]>
Signed-off-by: Martin Marciniszyn Mehringer <[email protected]>
@MartinMarciniszyn MartinMarciniszyn enabled auto-merge (squash) May 20, 2025 06:35
@MartinMarciniszyn MartinMarciniszyn merged commit 3485347 into NVIDIA:main May 20, 2025
2 checks passed
@tensorrt-cicd
Copy link
Collaborator

PR_Github #5815 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4258 completed with status: 'SUCCESS'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants