Skip to content

fix[nvbug/5286515]: trtllm-llmapi-launch on single node single gpu #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

Superjomn
Copy link
Collaborator

PR title

Please write the PR title by following template:

[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>

For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like

[TRTLLM-1000][feat] Support a new feature about cache manager

Description

Please explain the issue and the solution in short.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@Superjomn
Copy link
Collaborator Author

/bot run --only-multi-gpu-test

@Superjomn Superjomn changed the title fix: trtllm-llmapi-launch on single node single gpu fix[nvbug/5286515]: trtllm-llmapi-launch on single node single gpu May 19, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #5664 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5664 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4137 (Partly Tested) completed with status: 'FAILURE'

@Superjomn
Copy link
Collaborator Author

/bot run --only-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5797 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5797 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4244 (Partly Tested) completed with status: 'FAILURE'

Superjomn added 2 commits May 20, 2025 14:29
Signed-off-by: Superjomn <[email protected]>
Signed-off-by: Superjomn <[email protected]>
@Superjomn
Copy link
Collaborator Author

/bot run --only-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5833 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5833 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4272 (Partly Tested) completed with status: 'SUCCESS'

@Superjomn
Copy link
Collaborator Author

/bot skip --comment "only affect multi-gpu and the tests passed"

@Superjomn Superjomn enabled auto-merge (squash) May 20, 2025 12:05
@tensorrt-cicd
Copy link
Collaborator

PR_Github #5873 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5873 [ skip ] completed with state SUCCESS
Skipping testing for commit 3248652

@Superjomn Superjomn merged commit 174c518 into NVIDIA:main May 20, 2025
3 checks passed
@Superjomn Superjomn deleted the fix-mgmn-1n-1g branch May 21, 2025 08:20
Superjomn added a commit to Superjomn/TensorRT-LLM that referenced this pull request May 21, 2025
…VIDIA#4428)

* add test

Signed-off-by: Superjomn <[email protected]>

* fix

Signed-off-by: Superjomn <[email protected]>

---------

Signed-off-by: Superjomn <[email protected]>
Superjomn added a commit to Superjomn/TensorRT-LLM that referenced this pull request May 22, 2025
…VIDIA#4428)

* add test

Signed-off-by: Superjomn <[email protected]>

* fix

Signed-off-by: Superjomn <[email protected]>

---------

Signed-off-by: Superjomn <[email protected]>
Superjomn added a commit to Superjomn/TensorRT-LLM that referenced this pull request May 22, 2025
…VIDIA#4428)

* add test

Signed-off-by: Superjomn <[email protected]>

* fix

Signed-off-by: Superjomn <[email protected]>

---------

Signed-off-by: Superjomn <[email protected]>
Superjomn added a commit to Superjomn/TensorRT-LLM that referenced this pull request May 22, 2025
…VIDIA#4428)

* add test

Signed-off-by: Superjomn <[email protected]>

* fix

Signed-off-by: Superjomn <[email protected]>

---------

Signed-off-by: Superjomn <[email protected]>
Superjomn added a commit to Superjomn/TensorRT-LLM that referenced this pull request May 22, 2025
…VIDIA#4428)

* add test

Signed-off-by: Superjomn <[email protected]>

* fix

Signed-off-by: Superjomn <[email protected]>

---------

Signed-off-by: Superjomn <[email protected]>
Superjomn added a commit to Superjomn/TensorRT-LLM that referenced this pull request May 26, 2025
…VIDIA#4428)

* add test

Signed-off-by: Superjomn <[email protected]>

* fix

Signed-off-by: Superjomn <[email protected]>

---------

Signed-off-by: Superjomn <[email protected]>
Superjomn added a commit to Superjomn/TensorRT-LLM that referenced this pull request May 27, 2025
…VIDIA#4428)

* add test

Signed-off-by: Superjomn <[email protected]>

* fix

Signed-off-by: Superjomn <[email protected]>

---------

Signed-off-by: Superjomn <[email protected]>
Superjomn added a commit that referenced this pull request May 27, 2025
…4529)

fix[nvbug/5286515]: trtllm-llmapi-launch on single node single gpu (#4428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants