Skip to content

Tkurth/interface fixes #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

azrael417
Copy link
Collaborator

This MR adds some more tests for shapes of tensors emitted from replay and rollout buffers and also multi env tests for replay buffer.

This MR fixes shape checks in the training routines for various RL algorithms

This MR adds Debug compilation mode to Dockerfile

@azrael417 azrael417 requested a review from romerojosh June 24, 2025 09:45
…ng argument names (terminal/final_state) consistent.
@romerojosh
Copy link
Collaborator

I pushed a commit to fix up some of the Fortran to C boolean conversions in the interface as we discussed.

I also noticed that there was some inconsistency in the names of arguments, particularly final_state and terminal across the Fortran and C APIs. I went ahead and just converted them all to final_state but feel free to change them all to terminal if you think that is better. The important thing is that we are consistent everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants