Skip to content

Commit

Permalink
Switch to entropy-based stopping criterion (#1280)
Browse files Browse the repository at this point in the history
  • Loading branch information
gevtushenko authored Jan 15, 2024
1 parent f54b11e commit 2b38693
Showing 1 changed file with 2 additions and 16 deletions.
18 changes: 2 additions & 16 deletions benchmarks/scripts/cccl/bench/bench.py
Original file line number Diff line number Diff line change
Expand Up @@ -626,22 +626,8 @@ def do_run(self, ct_point, rt_values, timeout, is_search=True):
cmd.append('--jsonbin')
cmd.append(result_path)

if is_search:
# Allow noise because we rely on min samples
cmd.append("--max-noise")
cmd.append("100")

# Need at least 70 samples
cmd.append("--min-samples")
cmd.append("70")

# Unlike noise, minimal benchmarking time is not directly related to variance.
# Default minimal time is 0.5 seconds. For CI we want to reduce it to 0.1 seconds,
# becuse we have limited time budget. Having smaller minimal time doesn't affect
# stability of sample distribution median in a deterministic way. For small problem sizes,
# 0.1s leads to smaller variation than 0.5s. For other workloads, 0.5 leads to smaller variance.
cmd.append("--min-time")
cmd.append("0.1")
cmd.append("--stopping-criterion")
cmd.append("entropy")

# NVBench is currently broken for multiple GPUs, use `CUDA_VISIBLE_DEVICES`
cmd.append("-d")
Expand Down

0 comments on commit 2b38693

Please sign in to comment.