Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icc / cub #1152

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix icc / cub #1152

merged 1 commit into from
Nov 28, 2023

Conversation

gevtushenko
Copy link
Collaborator

Description

closes #1151

Suppresses visibility warning for icc.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@gevtushenko gevtushenko requested review from a team as code owners November 27, 2023 23:14
miscco
miscco requested changes Nov 28, 2023
View reviewed changes
cub/cub/util_macro.cuh Outdated Show resolved Hide resolved
cub/cub/util_macro.cuh Outdated Show resolved Hide resolved
@gevtushenko gevtushenko added the backport branch/2.3.x For backporting to the 2.3.x release branch label Nov 28, 2023
@gevtushenko gevtushenko requested a review from a team as a code owner November 28, 2023 16:53
@gevtushenko
Copy link
Collaborator Author

/ok to test

@gevtushenko @miscco
Fix icc / cub
23bd579 
Co-Authored-By: Michael Schellenberger Costa <[email protected]>
@gevtushenko gevtushenko force-pushed the fix-main/github/icc_vis branch from d6ba9a2 to 23bd579 Compare November 28, 2023 18:36
@gevtushenko gevtushenko merged commit ad93a00 into NVIDIA:main Nov 28, 2023
515 checks passed
@github-actions GitHub Actions
Copy link
Contributor

GitHub Actions is not permitted to create or approve pull requests.

@jrhemstad jrhemstad mentioned this pull request Nov 29, 2023
Merged
wmaxey pushed a commit that referenced this pull request Dec 1, 2023
@gevtushenko @miscco @wmaxey
Fix icc / cub (#1152)
f7acd91 
Co-authored-by: Michael Schellenberger Costa <[email protected]>
jrhemstad pushed a commit that referenced this pull request Dec 8, 2023
@gevtushenko @miscco @jrhemstad
Fix icc / cub (#1152)
1803899 
Co-authored-by: Michael Schellenberger Costa <[email protected]>
jrhemstad pushed a commit that referenced this pull request Dec 8, 2023
@wmaxey @gevtushenko @miscco
Fix icc / cub (#1152) (#1171)
7552e97 
Co-authored-by: Georgii Evtushenko <[email protected]>
Co-authored-by: Michael Schellenberger Costa <[email protected]>
@miscco miscco added backport done This PR has been backported to the relevant branch and removed backport branch/2.3.x For backporting to the 2.3.x release branch labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@wmaxey wmaxey wmaxey approved these changes

@elstehle elstehle Awaiting requested review from elstehle elstehle is a code owner automatically assigned from NVIDIA/cccl-cub-codeowners

@alliepiper alliepiper Awaiting requested review from alliepiper alliepiper was automatically assigned from NVIDIA/cccl-codeowners

@ericniebler ericniebler Awaiting requested review from ericniebler ericniebler is a code owner automatically assigned from NVIDIA/cccl-libcudacxx-codeowners

Assignees
No one assigned
Labels
backport done This PR has been backported to the relevant branch
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: ICC support is broken by linkage visibility fixes
3 participants
@gevtushenko @miscco @wmaxey