Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTX: Add cuda::ptx:barrier_cluster_{arrive,wait} #1366

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

ahendriksen
Copy link
Contributor

Description

closes #1365

Adds cuda::ptx::barrier_cluster_arrive and cuda::ptx::barrier_cluster_wait.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ahendriksen ahendriksen requested review from a team as code owners February 12, 2024 10:23
libcudacxx/docs/ptx.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to discuss adding deprecated interfaces internally

@ahendriksen ahendriksen force-pushed the ptx-add-barrier-cluster branch 2 times, most recently from 7f6e9a0 to 3212cc5 Compare February 22, 2024 16:33
@ahendriksen
Copy link
Contributor Author

The .aligned conversation has closed. The .aligned version is now exposed. @miscco : can you review and if good, merge?

@ahendriksen ahendriksen force-pushed the ptx-add-barrier-cluster branch from 2ad4e4b to c2340e6 Compare February 27, 2024 11:23
@ahendriksen
Copy link
Contributor Author

Can we merge this? The only check that is failing is an unrelated CUB test.

@miscco miscco enabled auto-merge (squash) February 27, 2024 14:39
@miscco miscco merged commit 2f09e3d into NVIDIA:main Feb 27, 2024
561 checks passed
miscco pushed a commit to miscco/cccl that referenced this pull request Feb 29, 2024
* Add `cuda::ptx::barrier.cluster.{arrive,wait}`

* Add note about .aligned variants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Add cuda::ptx::barrier_cluster
2 participants