-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dev Containers guide for WSL #1394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, some minor docs structure comment
exec: "xdg-open,x-www-browser,www-browser,wslview": executable file not found in $PATH | ||
Please try entering the URL in your browser manually | ||
|
||
In that case type in the address manually in your web browser https://github.com/login/device and fill in the one-time code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a random 1st time user/installer, these instructions worked well for me.
Thanks
beb5c30
to
88bc471
Compare
@miscco @jrhemstad @gevtushenko merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instruction is great! Just a few nits below.
80e0e44
to
19f43f8
Compare
…ments and create refs to them
Co-authored-by: Michael Schellenberger Costa <[email protected]>
Co-authored-by: Georgii Evtushenko <[email protected]>
Co-authored-by: Georgii Evtushenko <[email protected]>
Description
devcontainer.json
configuration file in every image.