Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate handling of constexpr and if constexpr #1562

Merged
merged 5 commits into from
Mar 24, 2024

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Mar 22, 2024

This consolidates our support macros for if constexpr and constexpr into a central location within the __cccl/dialect.h header

It also applies this throughout the repo.
Finally it cleanes up some related machinery

miscco added 4 commits March 22, 2024 13:43
All supported compilers satisfy the requirement on this so its useless
Its only used within a single header, move it there and clean it up afterwards
@miscco miscco requested review from a team as code owners March 22, 2024 13:04
@miscco miscco requested review from wmaxey and gevtushenko March 22, 2024 13:04
@miscco miscco added feature request New feature or request. thrust For all items related to Thrust. cub For all items related to CUB libcu++ For all items related to libcu++ infrastructure Shared CMake, github, etc infrastructure labels Mar 22, 2024
@miscco miscco requested a review from griwes March 22, 2024 13:05
@miscco miscco enabled auto-merge (squash) March 24, 2024 12:32
auto-merge was automatically disabled March 24, 2024 12:41

Pull Request is not mergeable

@miscco miscco merged commit 4d49c2f into NVIDIA:main Mar 24, 2024
585 checks passed
@miscco miscco deleted the centralize_standard_mode_checks branch March 24, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cub For all items related to CUB feature request New feature or request. infrastructure Shared CMake, github, etc infrastructure libcu++ For all items related to libcu++ thrust For all items related to Thrust.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants