Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable heterogeneous tests that frequently hang #1570

Closed
wants to merge 1 commit into from

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Mar 27, 2024

Those tests are creating an incredible amount of noise in CI.

We want the functionality tested, but until we can get the tests to unflake, disable them

Those tests are creating an incredible amount of noise in CI.

We want the functionality tested, but until we can get the tests to unflake, disable them
@miscco miscco requested review from a team as code owners March 27, 2024 07:55
@miscco miscco added the libcu++ For all items related to libcu++ label Mar 27, 2024
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, open an issue to track fixing and re-enabling these if you haven't already.

Copy link
Member

@wmaxey wmaxey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only accept this PR if the fix is being actively worked on. I can work on this in the meantime but I don't have an ETA for a fix to the currently UB launch flow.

@miscco
Copy link
Collaborator Author

miscco commented Apr 2, 2024

I would only accept this PR if the fix is being actively worked on. I can work on this in the meantime but I don't have an ETA for a fix to the currently UB launch flow.

Those tests are continuously breaking some CI run somewhere that get filed as bugs. I do not know of any of those reports that was actually investigated. That means those tests serve no purpose currently

Copy link
Collaborator

@griwes griwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need tests that actually verify the layouts before we merge this.

We can safely drop the abi_v2 versions, as I don't think ABI v2 is still supported, right?

@miscco
Copy link
Collaborator Author

miscco commented May 8, 2024

@wmaxey has a PR to fix those tests, so dropping

@miscco miscco closed this May 8, 2024
@miscco miscco deleted the disable_heterogeneous_tests branch May 8, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libcu++ For all items related to libcu++
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants