Mostly flatten the folder structure of libcu++ #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested review from
alliepiper,
ericniebler,
jarmak-nv,
elstehle,
griwes and
wmaxey
miscco
added
feature request
miscco
force-pushed
the
move_libcudacxx
branch
2 times, most recently
from
4d6eb01 to
97a73bf
Compare
We want to name the folder cotnaining the subheaders as `__meow` so that we then can easily expose the internal header without any further code movement
We do not need the deep nested structure anymore, as a first step move all internal subfolders of `cuda/std/detail/libcxx/include` to `cuda/std`
wmaxey
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all of the subfolders from
cuda/std/detail/libcxx/include/__meowdown tocuda/std/__meowWe also move the ptx headers to
cuda/__ptxand adopt the__cccl_configThis is a first step in completely flatting our libcu++ folder structure.
The remaining work is in moving all the individual header files around.