Make --cmake-options="" always override others.
#1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
approved these changes
Apr 18, 2024
miscco
reviewed
Apr 19, 2024
| @@ -167,7 +167,7 @@ function configure_preset() | |||
| local GROUP_NAME="🛠️ CMake Configure ${BUILD_NAME}" | |||
|
|
|||
| pushd .. > /dev/null | |||
| run_command "$GROUP_NAME" cmake --preset=$PRESET --log-level=VERBOSE "${GLOBAL_CMAKE_OPTIONS[@]}" $CMAKE_OPTIONS | |||
| run_command "$GROUP_NAME" cmake --preset=$PRESET --log-level=VERBOSE $CMAKE_OPTIONS "${GLOBAL_CMAKE_OPTIONS[@]}" | |||
There was a problem hiding this comment.
I believe we need to adopt the line
echo " -cmake-options: Additional options to pass to CMake"
to tell the users what it does now
There was a problem hiding this comment.
I'm not following what you mean.
There was a problem hiding this comment.
The behavior still matches the docs. The only difference is how user-supplied options are ordered around hardcoded options in the build scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a user to override things like CUB's benchmarks when they aren't needed.