Add docs instructions on how to utilize CMake Presets #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
reviewed
May 6, 2024
|
@gonidelis Hi! I haven't had a chance to look at this. Will do so as soon as I can. Thanks for tagging me! |
mhoemmen
approved these changes
May 7, 2024
🟩 CI Results [ Failed: 0 | Passed: 306 | Total: 306 ]
|
| # | Runner |
|---|---|
| 232 | linux-amd64-cpu16 |
| 32 | linux-amd64-gpu-v100-latest-1 |
| 24 | linux-arm64-cpu16 |
| 18 | windows-amd64-cpu16 |
👃 Inspect Changes
Modifications in project?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
alliepiper
reviewed
May 11, 2024
🟨 CI Results [ Failed: 1 | Passed: 305 | Total: 306 ]
|
| # | Runner |
|---|---|
| 232 | linux-amd64-cpu16 |
| 32 | linux-amd64-gpu-v100-latest-1 |
| 24 | linux-arm64-cpu16 |
| 18 | windows-amd64-cpu16 |
👃 Inspect Changes
Modifications in project?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
🟩 CI Results [ Failed: 0 | Passed: 306 | Total: 306 ]
|
| # | Runner |
|---|---|
| 232 | linux-amd64-cpu16 |
| 32 | linux-amd64-gpu-v100-latest-1 |
| 24 | linux-arm64-cpu16 |
| 18 | windows-amd64-cpu16 |
👃 Inspect Changes
Modifications in project?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
jrhemstad
approved these changes
May 14, 2024
gonidelis
requested review from
alliepiper,
mhoemmen,
jrhemstad and
bernhardmgruber
and removed request for
mhoemmen and
jrhemstad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1689.
Adds instructions on how to use our
CMakePresets.jsonfrom either terminal or VS Code GUI.One of my considerations is that I added the images under the
.devcontainer/imgdirectory as it is the only folder where we are storing images thus far. Another thing is that I may have added too many images and source size is increased more than it should.Finally if the instructions I wrote have too much clutter in it, please let me know so I can reduce them.
It would be ideal if we found a volunteer who is agnostic to the CMake Presets (@mhoemmen random tag) to give us some feedback before merging.
@jrhemstad @gevtushenko I would appreciate your feedback on all three of my concerns.