Fix CMake option handling. #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These need to just be passed as a string, which is more flexible than assuming only key/value pairs.
The relative action path doesn't properly resolve when CCCL's workflows/actions from reused in other repos (eg. nvbench).
🟩 CI Results [ Failed: 0 | Passed: 306 | Total: 306 ]
|
| # | Runner |
|---|---|
| 232 | linux-amd64-cpu16 |
| 32 | linux-amd64-gpu-v100-latest-1 |
| 24 | linux-arm64-cpu16 |
| 18 | windows-amd64-cpu16 |
👃 Inspect Changes
Modifications in project?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
miscco
approved these changes
May 6, 2024
| role-to-assume: arn:aws:iam::279114543810:role/gha-oidc-NVIDIA | ||
| aws-region: us-east-2 | ||
| role-duration-seconds: 43200 # 12 hours) | ||
| - name: Set environment variables |
There was a problem hiding this comment.
Nitpick: Should there be a newline here separating the two actions like the other ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues discovered while updating NVBench to use the new CI. The sccache action was causing issues when reusing our actions/workflows from another repo.
We may need to consider splitting our workflows/actions out into a different versioned repo at some point.