Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable previously failing histogram test for icc #1725

Merged
merged 1 commit into from
May 13, 2024
Merged

Reenable previously failing histogram test for icc #1725

merged 1 commit into from
May 13, 2024

Conversation

bernhardmgruber
Copy link
Contributor

The test compiles and runs successfully with icc (ICC) 2021.10.0 20230609

Fixes: #872

@bernhardmgruber bernhardmgruber added the cub For all items related to CUB label May 8, 2024
@bernhardmgruber
Reenable previously failing histogram test for icc
55d5c46 
The test compiles and runs successfully with icc (ICC) 2021.10.0 20230609

Fixes: NVIDIA#872
@bernhardmgruber bernhardmgruber marked this pull request as ready for review May 8, 2024 17:36
@bernhardmgruber bernhardmgruber requested review from a team as code owners May 8, 2024 17:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

🟩 CI Results [ Failed: 0 | Passed: 198 | Total: 198 ]

  • 🟩 Project cub [ Failed: 0 | Passed: 99 | Total: 99 ]

     
    🟩 cpu
  🟩 amd64 (0% Fail)              Failed:  0  -- Passed: 91  -- Total: 91 
  🟩 arm64 (0% Fail)              Failed:  0  -- Passed:  8  -- Total:  8 
🟩 ctk
  🟩 11.1 (0% Fail)               Failed:  0  -- Passed: 15  -- Total: 15 
  🟩 11.8 (0% Fail)               Failed:  0  -- Passed:  3  -- Total:  3 
  🟩 12.4 (0% Fail)               Failed:  0  -- Passed: 81  -- Total: 81 
🟩 cudacxx_full
  🟩 clang-cuda16 (0% Fail)       Failed:  0  -- Passed:  2  -- Total:  2 
  🟩 nvcc11.1 (0% Fail)           Failed:  0  -- Passed: 15  -- Total: 15 
  🟩 nvcc11.8 (0% Fail)           Failed:  0  -- Passed:  3  -- Total:  3 
  🟩 nvcc12.4 (0% Fail)           Failed:  0  -- Passed: 79  -- Total: 79 
🟩 cudacxx_name
  🟩 clang-cuda (0% Fail)         Failed:  0  -- Passed:  2  -- Total:  2 
  🟩 nvcc (0% Fail)               Failed:  0  -- Passed: 97  -- Total: 97 
🟩 cxx_full
  🟩 clang9 (0% Fail)             Failed:  0  -- Passed:  6  -- Total:  6 
  🟩 clang10 (0% Fail)            Failed:  0  -- Passed:  3  -- Total:  3 
  🟩 clang11 (0% Fail)            Failed:  0  -- Passed:  4  -- Total:  4 
  🟩 clang12 (0% Fail)            Failed:  0  -- Passed:  4  -- Total:  4 
  🟩 clang13 (0% Fail)            Failed:  0  -- Passed:  4  -- Total:  4 
  🟩 clang14 (0% Fail)            Failed:  0  -- Passed:  4  -- Total:  4 
  🟩 clang15 (0% Fail)            Failed:  0  -- Passed:  4  -- Total:  4 
  🟩 clang16 (0% Fail)            Failed:  0  -- Passed: 14  -- Total: 14 
  🟩 gcc6 (0% Fail)               Failed:  0  -- Passed:  2  -- Total:  2 
  🟩 gcc7 (0% Fail)               Failed:  0  -- Passed:  6  -- Total:  6 
  🟩 gcc8 (0% Fail)               Failed:  0  -- Passed:  6  -- Total:  6 
  🟩 gcc9 (0% Fail)               Failed:  0  -- Passed:  6  -- Total:  6 
  🟩 gcc10 (0% Fail)              Failed:  0  -- Passed:  4  -- Total:  4 
  🟩 gcc11 (0% Fail)              Failed:  0  -- Passed:  7  -- Total:  7 
  🟩 gcc12 (0% Fail)              Failed:  0  -- Passed: 16  -- Total: 16 
  🟩 Intel2023.2.0 (0% Fail)      Failed:  0  -- Passed:  3  -- Total:  3 
  🟩 MSVC14.16 (0% Fail)          Failed:  0  -- Passed:  1  -- Total:  1 
  🟩 MSVC14.29 (0% Fail)          Failed:  0  -- Passed:  2  -- Total:  2 
  🟩 MSVC14.39 (0% Fail)          Failed:  0  -- Passed:  3  -- Total:  3 
🟩 cxx_name
  🟩 clang (0% Fail)              Failed:  0  -- Passed: 43  -- Total: 43 
  🟩 gcc (0% Fail)                Failed:  0  -- Passed: 47  -- Total: 47 
  🟩 Intel (0% Fail)              Failed:  0  -- Passed:  3  -- Total:  3 
  🟩 MSVC (0% Fail)               Failed:  0  -- Passed:  6  -- Total:  6 
🟩 gpu
  🟩 v100 (0% Fail)               Failed:  0  -- Passed: 99  -- Total: 99 
🟩 jobs
  🟩 build (0% Fail)              Failed:  0  -- Passed: 91  -- Total: 91 
  🟩 test (0% Fail)               Failed:  0  -- Passed:  8  -- Total:  8 
🟩 os
  🟩 ubuntu18.04 (0% Fail)        Failed:  0  -- Passed: 14  -- Total: 14 
  🟩 ubuntu20.04 (0% Fail)        Failed:  0  -- Passed: 35  -- Total: 35 
  🟩 ubuntu22.04 (0% Fail)        Failed:  0  -- Passed: 44  -- Total: 44 
  🟩 windows2022 (0% Fail)        Failed:  0  -- Passed:  6  -- Total:  6 
🟩 sm
  🟩 60;70;80;90 (0% Fail)        Failed:  0  -- Passed:  3  -- Total:  3 
  🟩 90a (0% Fail)                Failed:  0  -- Passed:  4  -- Total:  4 
🟩 std
  🟩 11 (0% Fail)                 Failed:  0  -- Passed: 26  -- Total: 26 
  🟩 14 (0% Fail)                 Failed:  0  -- Passed: 29  -- Total: 29 
  🟩 17 (0% Fail)                 Failed:  0  -- Passed: 28  -- Total: 28 
  🟩 20 (0% Fail)                 Failed:  0  -- Passed: 16  -- Total: 16

  • 🟩 Project thrust [ Failed: 0 | Passed: 99 | Total: 99 ]

     
    🟩 cpu
  🟩 amd64 (0% Fail)              Failed:  0  -- Passed: 91  -- Total: 91 
  🟩 arm64 (0% Fail)              Failed:  0  -- Passed:  8  -- Total:  8 
🟩 ctk
  🟩 11.1 (0% Fail)               Failed:  0  -- Passed: 15  -- Total: 15 
  🟩 11.8 (0% Fail)               Failed:  0  -- Passed:  3  -- Total:  3 
  🟩 12.4 (0% Fail)               Failed:  0  -- Passed: 81  -- Total: 81 
🟩 cudacxx_full
  🟩 clang-cuda16 (0% Fail)       Failed:  0  -- Passed:  2  -- Total:  2 
  🟩 nvcc11.1 (0% Fail)           Failed:  0  -- Passed: 15  -- Total: 15 
  🟩 nvcc11.8 (0% Fail)           Failed:  0  -- Passed:  3  -- Total:  3 
  🟩 nvcc12.4 (0% Fail)           Failed:  0  -- Passed: 79  -- Total: 79 
🟩 cudacxx_name
  🟩 clang-cuda (0% Fail)         Failed:  0  -- Passed:  2  -- Total:  2 
  🟩 nvcc (0% Fail)               Failed:  0  -- Passed: 97  -- Total: 97 
🟩 cxx_full
  🟩 clang9 (0% Fail)             Failed:  0  -- Passed:  6  -- Total:  6 
  🟩 clang10 (0% Fail)            Failed:  0  -- Passed:  3  -- Total:  3 
  🟩 clang11 (0% Fail)            Failed:  0  -- Passed:  4  -- Total:  4 
  🟩 clang12 (0% Fail)            Failed:  0  -- Passed:  4  -- Total:  4 
  🟩 clang13 (0% Fail)            Failed:  0  -- Passed:  4  -- Total:  4 
  🟩 clang14 (0% Fail)            Failed:  0  -- Passed:  4  -- Total:  4 
  🟩 clang15 (0% Fail)            Failed:  0  -- Passed:  4  -- Total:  4 
  🟩 clang16 (0% Fail)            Failed:  0  -- Passed: 14  -- Total: 14 
  🟩 gcc6 (0% Fail)               Failed:  0  -- Passed:  2  -- Total:  2 
  🟩 gcc7 (0% Fail)               Failed:  0  -- Passed:  6  -- Total:  6 
  🟩 gcc8 (0% Fail)               Failed:  0  -- Passed:  6  -- Total:  6 
  🟩 gcc9 (0% Fail)               Failed:  0  -- Passed:  6  -- Total:  6 
  🟩 gcc10 (0% Fail)              Failed:  0  -- Passed:  4  -- Total:  4 
  🟩 gcc11 (0% Fail)              Failed:  0  -- Passed:  7  -- Total:  7 
  🟩 gcc12 (0% Fail)              Failed:  0  -- Passed: 16  -- Total: 16 
  🟩 Intel2023.2.0 (0% Fail)      Failed:  0  -- Passed:  3  -- Total:  3 
  🟩 MSVC14.16 (0% Fail)          Failed:  0  -- Passed:  1  -- Total:  1 
  🟩 MSVC14.29 (0% Fail)          Failed:  0  -- Passed:  2  -- Total:  2 
  🟩 MSVC14.39 (0% Fail)          Failed:  0  -- Passed:  3  -- Total:  3 
🟩 cxx_name
  🟩 clang (0% Fail)              Failed:  0  -- Passed: 43  -- Total: 43 
  🟩 gcc (0% Fail)                Failed:  0  -- Passed: 47  -- Total: 47 
  🟩 Intel (0% Fail)              Failed:  0  -- Passed:  3  -- Total:  3 
  🟩 MSVC (0% Fail)               Failed:  0  -- Passed:  6  -- Total:  6 
🟩 gpu
  🟩 v100 (0% Fail)               Failed:  0  -- Passed: 99  -- Total: 99 
🟩 jobs
  🟩 build (0% Fail)              Failed:  0  -- Passed: 91  -- Total: 91 
  🟩 test (0% Fail)               Failed:  0  -- Passed:  8  -- Total:  8 
🟩 os
  🟩 ubuntu18.04 (0% Fail)        Failed:  0  -- Passed: 14  -- Total: 14 
  🟩 ubuntu20.04 (0% Fail)        Failed:  0  -- Passed: 35  -- Total: 35 
  🟩 ubuntu22.04 (0% Fail)        Failed:  0  -- Passed: 44  -- Total: 44 
  🟩 windows2022 (0% Fail)        Failed:  0  -- Passed:  6  -- Total:  6 
🟩 sm
  🟩 60;70;80;90 (0% Fail)        Failed:  0  -- Passed:  3  -- Total:  3 
  🟩 90a (0% Fail)                Failed:  0  -- Passed:  4  -- Total:  4 
🟩 std
  🟩 11 (0% Fail)                 Failed:  0  -- Passed: 26  -- Total: 26 
  🟩 14 (0% Fail)                 Failed:  0  -- Passed: 29  -- Total: 29 
  🟩 17 (0% Fail)                 Failed:  0  -- Passed: 28  -- Total: 28 
  🟩 20 (0% Fail)                 Failed:  0  -- Passed: 16  -- Total: 16

🏃‍ Runner counts (total jobs: 198)
# Runner
154 linux-amd64-cpu16
16 linux-arm64-cpu16
16 linux-amd64-gpu-v100-latest-1
12 windows-amd64-cpu16

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust

@miscco miscco merged commit d1a0401 into NVIDIA:main May 13, 2024
3 checks passed
@bernhardmgruber bernhardmgruber deleted the enable_icc branch May 16, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@gevtushenko gevtushenko Awaiting requested review from gevtushenko gevtushenko is a code owner automatically assigned from NVIDIA/cccl-cub-codeowners

@ericniebler ericniebler Awaiting requested review from ericniebler ericniebler was automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
cub For all items related to CUB
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cub::DeviceHistogramEven 3/4 multichannel float unit test fails with ICC
2 participants
@bernhardmgruber @miscco