Add ForEachN from CUB to cccl/c. #2378

wmaxey · 2024-09-06T00:52:20Z

Description

Adds the For Each algorithm to cccl/c. Later PRs will address lack of iterator support.

Checklist

New or existing tests cover these changes.

github-actions · 2024-09-06T01:08:12Z

🟩 CI finished in 14m 26s: Pass: 100%/1 | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s

🟩 pycuda: Pass: 100%/1 | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s
🟩 ctk
  🟩 12.5               Pass: 100%/1   | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s
🟩 cudacxx
  🟩 nvcc12.5           Pass: 100%/1   | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
	pycuda
+/-	CUDA C Core Library

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
+/-	pycuda
+/-	CUDA C Core Library

🏃‍ Runner counts (total jobs: 1)

#	Runner
1	`linux-amd64-gpu-v100-latest-1`

gevtushenko

This PR has most of the things we need already! Let's add iterators support and mark ready for review.

c/src/reduce.cu

c/src/util/small_storage.h

c/src/for.cu

c/src/util/small_storage.cpp

c/src/for.cu

github-actions · 2024-10-04T04:14:49Z

🟥 CI finished in 12m 33s: Pass: 0%/1 | Total: 12m 33s | Avg: 12m 33s | Max: 12m 33s

🟥 pycuda: Pass: 0%/1 | Total: 12m 33s | Avg: 12m 33s | Max: 12m 33s

🟥 cpu
  🟥 amd64              Pass:   0%/1   | Total: 12m 33s | Avg: 12m 33s | Max: 12m 33s
🟥 ctk
  🟥 12.5               Pass:   0%/1   | Total: 12m 33s | Avg: 12m 33s | Max: 12m 33s
🟥 cudacxx
  🟥 nvcc12.5           Pass:   0%/1   | Total: 12m 33s | Avg: 12m 33s | Max: 12m 33s
🟥 cudacxx_family
  🟥 nvcc               Pass:   0%/1   | Total: 12m 33s | Avg: 12m 33s | Max: 12m 33s
🟥 cxx
  🟥 GCC13              Pass:   0%/1   | Total: 12m 33s | Avg: 12m 33s | Max: 12m 33s
🟥 cxx_family
  🟥 GCC                Pass:   0%/1   | Total: 12m 33s | Avg: 12m 33s | Max: 12m 33s
🟥 gpu
  🟥 v100               Pass:   0%/1   | Total: 12m 33s | Avg: 12m 33s | Max: 12m 33s
🟥 jobs
  🟥 Test               Pass:   0%/1   | Total: 12m 33s | Avg: 12m 33s | Max: 12m 33s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
	pycuda
+/-	CUDA C Core Library

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
+/-	pycuda
+/-	CUDA C Core Library

🏃‍ Runner counts (total jobs: 1)

#	Runner
1	`linux-amd64-gpu-v100-latest-1`

github-actions · 2024-10-04T19:22:57Z

🟩 CI finished in 15m 01s: Pass: 100%/1 | Total: 15m 01s | Avg: 15m 01s | Max: 15m 01s

🟩 pycuda: Pass: 100%/1 | Total: 15m 01s | Avg: 15m 01s | Max: 15m 01s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 15m 01s | Avg: 15m 01s | Max: 15m 01s
🟩 ctk
  🟩 12.5               Pass: 100%/1   | Total: 15m 01s | Avg: 15m 01s | Max: 15m 01s
🟩 cudacxx
  🟩 nvcc12.5           Pass: 100%/1   | Total: 15m 01s | Avg: 15m 01s | Max: 15m 01s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 15m 01s | Avg: 15m 01s | Max: 15m 01s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 15m 01s | Avg: 15m 01s | Max: 15m 01s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 15m 01s | Avg: 15m 01s | Max: 15m 01s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 15m 01s | Avg: 15m 01s | Max: 15m 01s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 15m 01s | Avg: 15m 01s | Max: 15m 01s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
	pycuda
+/-	CUDA C Core Library

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
+/-	pycuda
+/-	CUDA C Core Library

🏃‍ Runner counts (total jobs: 1)

#	Runner
1	`linux-amd64-gpu-v100-latest-1`

github-actions · 2024-10-04T23:34:59Z

🟩 CI finished in 18m 40s: Pass: 100%/1 | Total: 18m 40s | Avg: 18m 40s | Max: 18m 40s

🟩 pycuda: Pass: 100%/1 | Total: 18m 40s | Avg: 18m 40s | Max: 18m 40s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 18m 40s | Avg: 18m 40s | Max: 18m 40s
🟩 ctk
  🟩 12.5               Pass: 100%/1   | Total: 18m 40s | Avg: 18m 40s | Max: 18m 40s
🟩 cudacxx
  🟩 nvcc12.5           Pass: 100%/1   | Total: 18m 40s | Avg: 18m 40s | Max: 18m 40s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 18m 40s | Avg: 18m 40s | Max: 18m 40s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 18m 40s | Avg: 18m 40s | Max: 18m 40s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 18m 40s | Avg: 18m 40s | Max: 18m 40s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 18m 40s | Avg: 18m 40s | Max: 18m 40s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 18m 40s | Avg: 18m 40s | Max: 18m 40s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
	pycuda
+/-	CUDA C Core Library

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
+/-	pycuda
+/-	CUDA C Core Library

🏃‍ Runner counts (total jobs: 1)

#	Runner
1	`linux-amd64-gpu-v100-latest-1`

github-actions · 2024-10-07T21:52:13Z

🟩 CI finished in 14m 29s: Pass: 100%/1 | Total: 14m 29s | Avg: 14m 29s | Max: 14m 29s

🟩 pycuda: Pass: 100%/1 | Total: 14m 29s | Avg: 14m 29s | Max: 14m 29s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 14m 29s | Avg: 14m 29s | Max: 14m 29s
🟩 ctk
  🟩 12.5               Pass: 100%/1   | Total: 14m 29s | Avg: 14m 29s | Max: 14m 29s
🟩 cudacxx
  🟩 nvcc12.5           Pass: 100%/1   | Total: 14m 29s | Avg: 14m 29s | Max: 14m 29s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 14m 29s | Avg: 14m 29s | Max: 14m 29s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 14m 29s | Avg: 14m 29s | Max: 14m 29s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 14m 29s | Avg: 14m 29s | Max: 14m 29s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 14m 29s | Avg: 14m 29s | Max: 14m 29s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 14m 29s | Avg: 14m 29s | Max: 14m 29s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
	pycuda
+/-	CUDA C Core Library

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
+/-	pycuda
+/-	CUDA C Core Library

🏃‍ Runner counts (total jobs: 1)

#	Runner
1	`linux-amd64-gpu-v100-latest-1`

c/test/test_for.cpp

Co-authored-by: Georgii Evtushenko <[email protected]>

github-actions · 2024-10-08T17:15:15Z

🟩 CI finished in 13m 11s: Pass: 100%/1 | Total: 13m 11s | Avg: 13m 11s | Max: 13m 11s

🟩 pycuda: Pass: 100%/1 | Total: 13m 11s | Avg: 13m 11s | Max: 13m 11s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 13m 11s | Avg: 13m 11s | Max: 13m 11s
🟩 ctk
  🟩 12.5               Pass: 100%/1   | Total: 13m 11s | Avg: 13m 11s | Max: 13m 11s
🟩 cudacxx
  🟩 nvcc12.5           Pass: 100%/1   | Total: 13m 11s | Avg: 13m 11s | Max: 13m 11s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 13m 11s | Avg: 13m 11s | Max: 13m 11s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 13m 11s | Avg: 13m 11s | Max: 13m 11s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 13m 11s | Avg: 13m 11s | Max: 13m 11s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 13m 11s | Avg: 13m 11s | Max: 13m 11s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 13m 11s | Avg: 13m 11s | Max: 13m 11s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
	pycuda
+/-	CUDA C Core Library

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
+/-	pycuda
+/-	CUDA C Core Library

🏃‍ Runner counts (total jobs: 1)

#	Runner
1	`linux-amd64-gpu-v100-latest-1`

c/src/for/for_op_helper.cpp

c/src/for.cu

github-actions · 2024-10-08T18:14:30Z

🟩 CI finished in 14m 44s: Pass: 100%/1 | Total: 14m 44s | Avg: 14m 44s | Max: 14m 44s

🟩 pycuda: Pass: 100%/1 | Total: 14m 44s | Avg: 14m 44s | Max: 14m 44s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 14m 44s | Avg: 14m 44s | Max: 14m 44s
🟩 ctk
  🟩 12.5               Pass: 100%/1   | Total: 14m 44s | Avg: 14m 44s | Max: 14m 44s
🟩 cudacxx
  🟩 nvcc12.5           Pass: 100%/1   | Total: 14m 44s | Avg: 14m 44s | Max: 14m 44s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 14m 44s | Avg: 14m 44s | Max: 14m 44s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 14m 44s | Avg: 14m 44s | Max: 14m 44s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 14m 44s | Avg: 14m 44s | Max: 14m 44s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 14m 44s | Avg: 14m 44s | Max: 14m 44s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 14m 44s | Avg: 14m 44s | Max: 14m 44s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
	pycuda
+/-	CUDA C Core Library

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
	CUB
	Thrust
	CUDA Experimental
+/-	pycuda
+/-	CUDA C Core Library

🏃‍ Runner counts (total jobs: 1)

#	Runner
1	`linux-amd64-gpu-v100-latest-1`

wmaxey added 3 commits September 5, 2024 17:01

Work in progress

1600eaa

Initial draft of exposing CUB::for in cccl/c.

99c1fc0

Add a fairly cursed storage abstraction for kernel arguments.

c90f299

wmaxey requested a review from gevtushenko September 6, 2024 00:52

gevtushenko reviewed Sep 14, 2024

View reviewed changes

wmaxey added 6 commits September 30, 2024 16:32

Merge branch 'main' into fea/cub_device_for_c

e7fc26b

Fix cccl/c include path.

e58cc0f

Commit WIP

b4c3d66

Make reduce inline functions static.

e6ee5d5

Initial draft of iterator support for C device for

46cee0a

Remove small vector (for now)

9a0396b

wmaxey requested a review from gevtushenko October 4, 2024 06:11

Fixup and remove debug build option from for.cu.

627bd3d

Disable iterator support in foreach (for now)

6fb017e

wmaxey changed the title ~~[Draft] Add ForEachN from CUB to cccl/c.~~ Add ForEachN from CUB to cccl/c. Oct 4, 2024

Merge branch 'main' into fea/cub_device_for_c

e36ffd9

wmaxey marked this pull request as ready for review October 4, 2024 23:11

wmaxey requested review from a team as code owners October 4, 2024 23:11

wmaxey requested review from alliepiper and elstehle October 4, 2024 23:11

wmaxey mentioned this pull request Oct 5, 2024

Create a command list utility for nvrtc/jitlink steps. #2511

Merged

2 tasks

wmaxey and others added 2 commits October 7, 2024 14:28

Merge branch 'main' into fea/cub_device_for_c

84e4234

whitespace fixup

ed5dfca

wmaxey force-pushed the fea/cub_device_for_c branch from 7e267f0 to ed5dfca Compare October 7, 2024 21:32

NVIDIA deleted a comment from copy-pr-bot bot Oct 7, 2024

gevtushenko reviewed Oct 8, 2024

View reviewed changes

c/test/test_for.cpp Outdated Show resolved Hide resolved

Restore LDL/STL call ABI checks that were commented out earlier.

9dc3ab0

Co-authored-by: Georgii Evtushenko <[email protected]>

gevtushenko approved these changes Oct 8, 2024

View reviewed changes

c/src/for/for_op_helper.cpp Outdated Show resolved Hide resolved

c/src/for/for_op_helper.cpp Outdated Show resolved Hide resolved

c/src/for.cu Outdated Show resolved Hide resolved

c/src/for.cu Show resolved Hide resolved

wmaxey added 3 commits October 8, 2024 17:57

Fix missing context push, Fix terminating instead of returning error.

3bdb92c

alignof instead of signof, use value_t for value type of kernel.

5db871a

Fix missing header in for.cu

7c2686f

wmaxey merged commit ee5dd3e into NVIDIA:main Oct 8, 2024
17 checks passed

rwgk added a commit to rwgk/cccl that referenced this pull request Oct 8, 2024

Fixes related to just-merged PR NVIDIA#2378

da1d11d

gevtushenko mentioned this pull request Oct 9, 2024

Implement C API for device for #2295

Closed

gevtushenko linked an issue Oct 10, 2024 that may be closed by this pull request

Implement C API for device for #2295

Closed

gevtushenko mentioned this pull request Oct 10, 2024

[FEA]: Implement cuda.parallel.device_for #2537

Open

1 task

Add ForEachN from CUB to cccl/c. #2378

Add ForEachN from CUB to cccl/c. #2378

Conversation

wmaxey commented Sep 6, 2024 • edited Loading

Description

Checklist

github-actions bot commented Sep 6, 2024

🟩 pycuda: Pass: 100%/1 | Total: 14m 26s | Avg: 14m 26s | Max: 14m 26s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 1)

gevtushenko left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 4, 2024

🟥 pycuda: Pass: 0%/1 | Total: 12m 33s | Avg: 12m 33s | Max: 12m 33s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 1)

github-actions bot commented Oct 4, 2024

🟩 pycuda: Pass: 100%/1 | Total: 15m 01s | Avg: 15m 01s | Max: 15m 01s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 1)

github-actions bot commented Oct 4, 2024

🟩 pycuda: Pass: 100%/1 | Total: 18m 40s | Avg: 18m 40s | Max: 18m 40s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 1)

github-actions bot commented Oct 7, 2024

🟩 pycuda: Pass: 100%/1 | Total: 14m 29s | Avg: 14m 29s | Max: 14m 29s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 1)

github-actions bot commented Oct 8, 2024

🟩 pycuda: Pass: 100%/1 | Total: 13m 11s | Avg: 13m 11s | Max: 13m 11s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 1)

github-actions bot commented Oct 8, 2024

🟩 pycuda: Pass: 100%/1 | Total: 14m 44s | Avg: 14m 44s | Max: 14m 44s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 1)

wmaxey commented Sep 6, 2024 •

edited

Loading