-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace a few more instances of CUDA C++ Core Libraries
with CUDA Core Compute Libraries`.
#2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That might conflict with the host standard library
…Core Compute Libraries`. NO MANUAL CHANGES. Command used: ``` for fn in `git grep 'CUDA C++ Core Libraries' | cut -d':' -f1 | uniq`; do sed -i .bak 's/CUDA C++ Core Libraries/CUDA Core Compute Libraries/g' $fn; done ```
leofang
approved these changes
Sep 20, 2024
🟩 CI finished in 1h 51m: Pass: 100%/368 | Total: 2d 10h | Avg: 9m 34s | Max: 1h 17m | Hits: 86%/25655
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
+/- | CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 368)
# | Runner |
---|---|
297 | linux-amd64-cpu16 |
28 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
miscco
approved these changes
Sep 23, 2024
gevtushenko
reviewed
Sep 23, 2024
Rationale: These files actually have a C++-specific license. It's left for later to change the license and the notices together.
sed
) replace CUDA C++ Core Libraries
with CUDA Core Compute Libraries`.CUDA C++ Core Libraries
with CUDA Core Compute Libraries`.
Hi @gevtushenko could you please take another look? This is now a much smaller PR. I updated the PR title & description accordingly. |
🟩 CI finished in 52m 35s: Pass: 100%/368 | Total: 1d 20h | Avg: 7m 18s | Max: 35m 57s | Hits: 98%/25663
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
+/- | CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 368)
# | Runner |
---|---|
297 | linux-amd64-cpu16 |
28 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
miscco
approved these changes
Sep 30, 2024
gevtushenko
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All
.cuh
,.cu
,.h
,.cpp
files are intentionally not changed (0e28ed7).Two files under
docs/
are intentionally not changed (529e331).See also: PR #2424 (merged already)
Checklist