removes superfluous template keyword in call to Dereference #2482

andrewcorrigan · 2024-09-30T01:20:56Z

Description

This PR proposes to removes a superfluous template keyword for a call to function Dereference that triggers a warning/error with clang-19+CUDA compilation. I encountered this using the pre-cccl version of CUB but this particular line is the same in the current trunk vs. the version I'm using.

thread_store.cuh:349:56: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  349 |     IterateThreadStore<0, VOLATILE_MULTIPLE>::template Dereference(
      |                                                        ^
1 error generated when compiling for sm_80.

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

…ith clang-19 error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw] 349 | IterateThreadStore<0, VOLATILE_MULTIPLE>::template Dereference(

copy-pr-bot · 2024-09-30T01:21:00Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

miscco

Thanks a lot, I verified via the following regex that there are no other occurences

::template ([a-z_A-Z]*)\(

miscco · 2024-09-30T06:31:31Z

/ok to test

github-actions · 2024-09-30T08:09:49Z

🟩 CI finished in 1h 36m: Pass: 100%/208 | Total: 5d 15h | Avg: 39m 09s | Max: 1h 08m | Hits: 62%/14058

🟩 cub: Pass: 100%/104 | Total: 3d 11h | Avg: 48m 17s | Max: 1h 08m | Hits: 25%/2908

🟩 cpu
  🟩 amd64              Pass: 100%/96  | Total:  3d 04h | Avg: 47m 50s | Max:  1h 08m | Hits:  25%/2908  
  🟩 arm64              Pass: 100%/8   | Total:  7h 09m | Avg: 53m 37s | Max: 57m 49s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total: 11h 33m | Avg: 46m 12s | Max: 55m 29s | Hits:  25%/727   
  🟩 11.8               Pass: 100%/3   | Total:  3h 14m | Avg:  1h 04m | Max:  1h 05m
  🟩 12.6               Pass: 100%/86  | Total:  2d 20h | Avg: 48m 04s | Max:  1h 08m | Hits:  25%/2181  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  1h 47m | Avg: 53m 43s | Max: 54m 06s
  🟩 nvcc11.1           Pass: 100%/15  | Total: 11h 33m | Avg: 46m 12s | Max: 55m 29s | Hits:  25%/727   
  🟩 nvcc11.8           Pass: 100%/3   | Total:  3h 14m | Avg:  1h 04m | Max:  1h 05m
  🟩 nvcc12.6           Pass: 100%/84  | Total:  2d 19h | Avg: 47m 56s | Max:  1h 08m | Hits:  25%/2181  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  1h 47m | Avg: 53m 43s | Max: 54m 06s
  🟩 nvcc               Pass: 100%/102 | Total:  3d 09h | Avg: 48m 11s | Max:  1h 08m | Hits:  25%/2908  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  4h 45m | Avg: 47m 31s | Max: 49m 28s
  🟩 Clang10            Pass: 100%/3   | Total:  2h 36m | Avg: 52m 06s | Max: 55m 34s
  🟩 Clang11            Pass: 100%/4   | Total:  3h 22m | Avg: 50m 42s | Max: 56m 02s
  🟩 Clang12            Pass: 100%/4   | Total:  3h 29m | Avg: 52m 22s | Max: 56m 16s
  🟩 Clang13            Pass: 100%/4   | Total:  3h 24m | Avg: 51m 07s | Max: 54m 44s
  🟩 Clang14            Pass: 100%/4   | Total:  3h 23m | Avg: 50m 55s | Max: 56m 22s
  🟩 Clang15            Pass: 100%/4   | Total:  3h 16m | Avg: 49m 03s | Max: 49m 54s
  🟩 Clang16            Pass: 100%/4   | Total:  3h 38m | Avg: 54m 43s | Max: 57m 38s
  🟩 Clang17            Pass: 100%/4   | Total:  3h 17m | Avg: 49m 23s | Max: 49m 49s
  🟩 Clang18            Pass: 100%/9   | Total:  6h 56m | Avg: 46m 16s | Max: 56m 08s
  🟩 GCC6               Pass: 100%/2   | Total:  1h 31m | Avg: 45m 51s | Max: 48m 55s
  🟩 GCC7               Pass: 100%/6   | Total:  4h 52m | Avg: 48m 44s | Max: 56m 00s
  🟩 GCC8               Pass: 100%/6   | Total:  5h 02m | Avg: 50m 25s | Max: 55m 58s
  🟩 GCC9               Pass: 100%/6   | Total:  4h 38m | Avg: 46m 27s | Max: 49m 45s
  🟩 GCC10              Pass: 100%/4   | Total:  3h 28m | Avg: 52m 05s | Max: 55m 30s
  🟩 GCC11              Pass: 100%/7   | Total:  6h 51m | Avg: 58m 47s | Max:  1h 05m
  🟩 GCC12              Pass: 100%/4   | Total:  3h 27m | Avg: 51m 55s | Max: 56m 36s
  🟩 GCC13              Pass: 100%/16  | Total:  8h 44m | Avg: 32m 46s | Max: 57m 49s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  2h 42m | Avg: 54m 10s | Max: 57m 23s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 55m 29s | Avg: 55m 29s | Max: 55m 29s | Hits:  25%/727   
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 10m | Avg:  1h 05m | Max:  1h 08m | Hits:  25%/1454  
  🟩 MSVC14.39          Pass: 100%/1   | Total:  1h 05m | Avg:  1h 05m | Max:  1h 05m | Hits:  25%/727   
🟩 cxx_family
  🟩 Clang              Pass: 100%/46  | Total:  1d 14h | Avg: 49m 48s | Max: 57m 38s
  🟩 GCC                Pass: 100%/51  | Total:  1d 14h | Avg: 45m 26s | Max:  1h 05m
  🟩 Intel              Pass: 100%/3   | Total:  2h 42m | Avg: 54m 10s | Max: 57m 23s
  🟩 MSVC               Pass: 100%/4   | Total:  4h 11m | Avg:  1h 02m | Max:  1h 08m | Hits:  25%/2908  
🟩 gpu
  🟩 v100               Pass: 100%/104 | Total:  3d 11h | Avg: 48m 17s | Max:  1h 08m | Hits:  25%/2908  
🟩 jobs
  🟩 Build              Pass: 100%/96  | Total:  3d 09h | Avg: 50m 46s | Max:  1h 08m | Hits:  25%/2908  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 17m 46s | Avg: 17m 46s | Max: 17m 46s
  🟩 GraphCapture       Pass: 100%/1   | Total: 15m 02s | Avg: 15m 02s | Max: 15m 02s
  🟩 HostLaunch         Pass: 100%/3   | Total: 48m 26s | Avg: 16m 08s | Max: 18m 08s
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 06m | Avg: 22m 15s | Max: 23m 24s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  3h 14m | Avg:  1h 04m | Max:  1h 05m
  🟩 90a                Pass: 100%/4   | Total:  1h 31m | Avg: 22m 56s | Max: 25m 07s
🟩 std
  🟩 11                 Pass: 100%/28  | Total: 22h 07m | Avg: 47m 24s | Max:  1h 04m
  🟩 14                 Pass: 100%/27  | Total: 23h 07m | Avg: 51m 22s | Max:  1h 08m | Hits:  25%/1454  
  🟩 17                 Pass: 100%/26  | Total: 21h 48m | Avg: 50m 20s | Max:  1h 05m | Hits:  25%/727   
  🟩 20                 Pass: 100%/23  | Total: 16h 39m | Avg: 43m 27s | Max:  1h 05m | Hits:  25%/727

🟩 thrust: Pass: 100%/103 | Total: 2d 03h | Avg: 30m 10s | Max: 1h 06m | Hits: 72%/11150

🟩 cpu
  🟩 amd64              Pass: 100%/95  | Total:  1d 23h | Avg: 30m 14s | Max:  1h 06m | Hits:  72%/11150 
  🟩 arm64              Pass: 100%/8   | Total:  3h 55m | Avg: 29m 25s | Max: 33m 19s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  7h 38m | Avg: 30m 34s | Max:  1h 03m | Hits:  65%/2230  
  🟩 11.8               Pass: 100%/3   | Total:  1h 57m | Avg: 39m 18s | Max: 41m 30s
  🟩 12.6               Pass: 100%/85  | Total:  1d 18h | Avg: 29m 47s | Max:  1h 06m | Hits:  74%/8920  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 48m 59s | Avg: 24m 29s | Max: 25m 08s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  7h 38m | Avg: 30m 34s | Max:  1h 03m | Hits:  65%/2230  
  🟩 nvcc11.8           Pass: 100%/3   | Total:  1h 57m | Avg: 39m 18s | Max: 41m 30s
  🟩 nvcc12.6           Pass: 100%/83  | Total:  1d 17h | Avg: 29m 54s | Max:  1h 06m | Hits:  74%/8920  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 48m 59s | Avg: 24m 29s | Max: 25m 08s
  🟩 nvcc               Pass: 100%/101 | Total:  2d 02h | Avg: 30m 17s | Max:  1h 06m | Hits:  72%/11150 
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  2h 56m | Avg: 29m 22s | Max: 34m 48s
  🟩 Clang10            Pass: 100%/3   | Total:  1h 30m | Avg: 30m 11s | Max: 32m 56s
  🟩 Clang11            Pass: 100%/4   | Total:  2h 03m | Avg: 30m 53s | Max: 33m 56s
  🟩 Clang12            Pass: 100%/4   | Total:  2h 01m | Avg: 30m 28s | Max: 34m 30s
  🟩 Clang13            Pass: 100%/4   | Total:  2h 05m | Avg: 31m 27s | Max: 35m 22s
  🟩 Clang14            Pass: 100%/4   | Total:  2h 03m | Avg: 30m 48s | Max: 35m 43s
  🟩 Clang15            Pass: 100%/4   | Total:  2h 04m | Avg: 31m 11s | Max: 35m 46s
  🟩 Clang16            Pass: 100%/4   | Total:  1h 58m | Avg: 29m 31s | Max: 32m 20s
  🟩 Clang17            Pass: 100%/4   | Total:  2h 03m | Avg: 30m 57s | Max: 36m 26s
  🟩 Clang18            Pass: 100%/9   | Total:  3h 34m | Avg: 23m 47s | Max: 32m 44s
  🟩 GCC6               Pass: 100%/2   | Total: 54m 06s | Avg: 27m 03s | Max: 31m 07s
  🟩 GCC7               Pass: 100%/6   | Total:  2h 55m | Avg: 29m 15s | Max: 32m 28s
  🟩 GCC8               Pass: 100%/6   | Total:  2h 54m | Avg: 29m 04s | Max: 35m 06s
  🟩 GCC9               Pass: 100%/6   | Total:  2h 55m | Avg: 29m 11s | Max: 33m 04s
  🟩 GCC10              Pass: 100%/4   | Total:  2h 02m | Avg: 30m 31s | Max: 33m 25s
  🟩 GCC11              Pass: 100%/7   | Total:  4h 10m | Avg: 35m 48s | Max: 41m 30s
  🟩 GCC12              Pass: 100%/4   | Total:  2h 14m | Avg: 33m 40s | Max: 39m 44s
  🟩 GCC13              Pass: 100%/14  | Total:  4h 52m | Avg: 20m 51s | Max: 34m 51s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  1h 49m | Avg: 36m 32s | Max: 40m 07s
  🟩 MSVC14.16          Pass: 100%/1   | Total:  1h 03m | Avg:  1h 03m | Max:  1h 03m | Hits:  65%/2230  
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 05m | Avg:  1h 02m | Max:  1h 03m | Hits:  65%/4460  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 29m | Avg: 44m 38s | Max:  1h 06m | Hits:  82%/4460  
🟩 cxx_family
  🟩 Clang              Pass: 100%/46  | Total: 22h 22m | Avg: 29m 10s | Max: 36m 26s
  🟩 GCC                Pass: 100%/49  | Total: 22h 58m | Avg: 28m 08s | Max: 41m 30s
  🟩 Intel              Pass: 100%/3   | Total:  1h 49m | Avg: 36m 32s | Max: 40m 07s
  🟩 MSVC               Pass: 100%/5   | Total:  4h 38m | Avg: 55m 39s | Max:  1h 06m | Hits:  72%/11150 
🟩 gpu
  🟩 v100               Pass: 100%/103 | Total:  2d 03h | Avg: 30m 10s | Max:  1h 06m | Hits:  72%/11150 
🟩 jobs
  🟩 Build              Pass: 100%/96  | Total:  2d 02h | Avg: 31m 32s | Max:  1h 06m | Hits:  65%/8920  
  🟩 TestCPU            Pass: 100%/4   | Total: 44m 52s | Avg: 11m 13s | Max: 23m 03s | Hits:  99%/2230  
  🟩 TestGPU            Pass: 100%/3   | Total: 36m 13s | Avg: 12m 04s | Max: 12m 42s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  1h 57m | Avg: 39m 18s | Max: 41m 30s
  🟩 90a                Pass: 100%/4   | Total:  1h 09m | Avg: 17m 24s | Max: 19m 00s
🟩 std
  🟩 11                 Pass: 100%/28  | Total: 11h 23m | Avg: 24m 24s | Max: 37m 02s
  🟩 14                 Pass: 100%/27  | Total: 15h 01m | Avg: 33m 23s | Max:  1h 03m | Hits:  65%/4460  
  🟩 17                 Pass: 100%/26  | Total: 14h 34m | Avg: 33m 37s | Max:  1h 03m | Hits:  65%/2230  
  🟩 20                 Pass: 100%/22  | Total: 10h 49m | Avg: 29m 30s | Max:  1h 06m | Hits:  82%/4460

🟩 pycuda: Pass: 100%/1 | Total: 13m 14s | Avg: 13m 14s | Max: 13m 14s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 13m 14s | Avg: 13m 14s | Max: 13m 14s
🟩 ctk
  🟩 12.5               Pass: 100%/1   | Total: 13m 14s | Avg: 13m 14s | Max: 13m 14s
🟩 cudacxx
  🟩 nvcc12.5           Pass: 100%/1   | Total: 13m 14s | Avg: 13m 14s | Max: 13m 14s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 13m 14s | Avg: 13m 14s | Max: 13m 14s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 13m 14s | Avg: 13m 14s | Max: 13m 14s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 13m 14s | Avg: 13m 14s | Max: 13m 14s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 13m 14s | Avg: 13m 14s | Max: 13m 14s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 13m 14s | Avg: 13m 14s | Max: 13m 14s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
	Thrust
	CUDA Experimental
	pycuda
	CUDA C Core Library

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental
+/-	pycuda
+/-	CUDA C Core Library

🏃‍ Runner counts (total jobs: 208)

#	Runner
171	`linux-amd64-cpu16`
16	`linux-arm64-cpu16`
12	`linux-amd64-gpu-v100-latest-1`
9	`windows-amd64-cpu16`

miscco · 2024-09-30T08:45:19Z

Thanks a lot for the fix 🎉

andrewcorrigan requested review from a team as code owners September 30, 2024 01:20

andrewcorrigan requested review from elstehle and fbusato September 30, 2024 01:20

miscco approved these changes Sep 30, 2024

View reviewed changes

miscco enabled auto-merge (squash) September 30, 2024 06:37

miscco merged commit 242bcce into NVIDIA:main Sep 30, 2024
224 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

removes superfluous template keyword in call to Dereference #2482

removes superfluous template keyword in call to Dereference #2482

andrewcorrigan commented Sep 30, 2024 •

edited

Loading

copy-pr-bot bot commented Sep 30, 2024

miscco left a comment

miscco commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

🟩 cub: Pass: 100%/104 | Total: 3d 11h | Avg: 48m 17s | Max: 1h 08m | Hits: 25%/2908

🟩 thrust: Pass: 100%/103 | Total: 2d 03h | Avg: 30m 10s | Max: 1h 06m | Hits: 72%/11150

🟩 pycuda: Pass: 100%/1 | Total: 13m 14s | Avg: 13m 14s | Max: 13m 14s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 208)

miscco commented Sep 30, 2024

removes superfluous template keyword in call to Dereference #2482

removes superfluous template keyword in call to Dereference #2482

Conversation

andrewcorrigan commented Sep 30, 2024 • edited Loading

Description

Checklist

copy-pr-bot bot commented Sep 30, 2024

miscco left a comment

Choose a reason for hiding this comment

miscco commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

🟩 cub: Pass: 100%/104 | Total: 3d 11h | Avg: 48m 17s | Max: 1h 08m | Hits: 25%/2908

🟩 thrust: Pass: 100%/103 | Total: 2d 03h | Avg: 30m 10s | Max: 1h 06m | Hits: 72%/11150

🟩 pycuda: Pass: 100%/1 | Total: 13m 14s | Avg: 13m 14s | Max: 13m 14s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 208)

miscco commented Sep 30, 2024

andrewcorrigan commented Sep 30, 2024 •

edited

Loading