-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop badly named _One_of
concept
#2490
Conversation
🟩 CI finished in 2h 10m: Pass: 100%/364 | Total: 7d 18h | Avg: 30m 49s | Max: 1h 24m | Hits: 36%/25675
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 364)
# | Runner |
---|---|
297 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
24 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
@@ -83,6 +83,10 @@ using __type_set_insert = decltype(__set::__bulk_insert::__call<_Ts...>(static_c | |||
template <class... _Ts> | |||
using __make_type_set = __type_set_insert<__type_set<>, _Ts...>; | |||
|
|||
template <class _Ty, class... _Ts> | |||
_LIBCUDACXX_INLINE_VAR constexpr bool __is_contained_in = | |||
_CCCL_TRAIT(_CUDA_VSTD::is_base_of, __type_identity<_Ty>, _CUDA_VSTD::__make_type_set<_Ts...>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new one uses is_base_of
while the old one was is_same_v
, do we plan to support inheriting from properties?
Not really feedback, I am just curious
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that is just how @ericniebler implemented the matching for __type_set
The old one did plain type checking.
I am wondering whether its more efficient the old way but I guess it doesnt really matter
First ig goes against the naming convention we have with both files and concepts. Furthermore, we should rather use the new type set facility
🟨 CI finished in 2h 23m: Pass: 99%/364 | Total: 3d 13h | Avg: 14m 00s | Max: 1h 27m | Hits: 77%/25688
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 364)
# | Runner |
---|---|
297 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
24 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
🟩 CI finished in 4h 43m: Pass: 100%/364 | Total: 3d 12h | Avg: 13m 59s | Max: 1h 23m | Hits: 77%/25688
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 364)
# | Runner |
---|---|
297 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
24 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
I would prefer we keep the existing |
|
||
_LIBCUDACXX_BEGIN_NAMESPACE_STD | ||
|
||
#if _CCCL_STD_VER >= 2017 | ||
template <bool... _Preds> | ||
_LIBCUDACXX_CONCEPT __all_of = (_Preds && ...); | ||
_LIBCUDACXX_INLINE_VAR constexpr bool __all_of = (_Preds && ...); | ||
#elif _CCCL_STD_VER >= 2014 | ||
template <bool... _Preds> | ||
struct __all_of_helper; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this is also used in the implementation of __none_of
. maybe a name like __bools
would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont really like that either and I was unable to find a better name thinking about it
🟩 CI finished in 2h 35m: Pass: 100%/364 | Total: 8d 03h | Avg: 32m 12s | Max: 1h 14m | Hits: 28%/25688
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 364)
# | Runner |
---|---|
297 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
24 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
First ig goes against the naming convention we have with both files and concepts.
Furthermore, we should rather use the new type set facility