-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor away per-project TOPLEVEL flags. #2498
Merged
alliepiper
merged 2 commits into
NVIDIA:main
from
alliepiper:remove_project_toplevel_flag
Oct 3, 2024
Merged
Refactor away per-project TOPLEVEL flags. #2498
alliepiper
merged 2 commits into
NVIDIA:main
from
alliepiper:remove_project_toplevel_flag
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will never be toplevel projects ever again now that we're a monorepo. They're redundant with the `CCCL_ENABLE_<proj>` flags.
miscco
approved these changes
Oct 3, 2024
🟩 CI finished in 2h 05m: Pass: 100%/370 | Total: 2d 01h | Avg: 7m 59s | Max: 1h 08m | Hits: 93%/25712
|
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 370)
# | Runner |
---|---|
297 | linux-amd64-cpu16 |
30 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will never be toplevel projects ever again now that we're a monorepo.
They're redundant with the
CCCL_ENABLE_<proj>
flags, and have been replace by them.This also moves the
thrust_fix_clang_nvcc_build_for
function definition out of Thrust's mainCMakeLists.txt
and into theThrustUtilities.cmake
file.