Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add values to compiler macros #2503

Closed
wants to merge 2 commits into from
Closed

Add values to compiler macros #2503

wants to merge 2 commits into from

Conversation

fbusato
Copy link
Contributor

@fbusato fbusato commented Oct 3, 2024

Description

Compiler identification macros are defined but don't have a value. This is bug-prone, namely when the user forgets to add the header:

#if defined(_CCCL_COMPILER_GCC) 
// do important things

this statement could be skipped or not depending on the inclusion of compiler.h even if gcc is actually used

@fbusato fbusato requested a review from miscco October 3, 2024 23:03
@fbusato fbusato requested review from a team as code owners October 3, 2024 23:03
@fbusato fbusato requested a review from alliepiper October 3, 2024 23:03
@fbusato fbusato self-assigned this Oct 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

🟩 CI finished in 1h 37m: Pass: 100%/364 | Total: 1d 15h | Avg: 6m 28s | Max: 49m 20s | Hits: 98%/25712

  • 🟩 cub: Pass: 100%/104 | Total: 11h 30m | Avg: 6m 38s | Max: 49m 20s | Hits: 99%/2908 

    🟩 cpu
  🟩 amd64              Pass: 100%/96  | Total: 10h 57m | Avg:  6m 50s | Max: 49m 20s | Hits:  99%/2908  
  🟩 arm64              Pass: 100%/8   | Total: 33m 51s | Avg:  4m 13s | Max:  4m 52s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 09m | Avg:  4m 38s | Max: 16m 16s | Hits:  99%/727   
  🟩 11.8               Pass: 100%/3   | Total: 14m 04s | Avg:  4m 41s | Max:  4m 57s
  🟩 12.6               Pass: 100%/86  | Total: 10h 07m | Avg:  7m 03s | Max: 49m 20s | Hits:  99%/2181  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  7m 50s | Avg:  3m 55s | Max:  4m 02s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 09m | Avg:  4m 38s | Max: 16m 16s | Hits:  99%/727   
  🟩 nvcc11.8           Pass: 100%/3   | Total: 14m 04s | Avg:  4m 41s | Max:  4m 57s
  🟩 nvcc12.6           Pass: 100%/84  | Total:  9h 59m | Avg:  7m 08s | Max: 49m 20s | Hits:  99%/2181  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 50s | Avg:  3m 55s | Max:  4m 02s
  🟩 nvcc               Pass: 100%/102 | Total: 11h 23m | Avg:  6m 41s | Max: 49m 20s | Hits:  99%/2908  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 28m 16s | Avg:  4m 42s | Max:  5m 51s
  🟩 Clang10            Pass: 100%/3   | Total: 16m 11s | Avg:  5m 23s | Max:  5m 38s
  🟩 Clang11            Pass: 100%/4   | Total: 18m 15s | Avg:  4m 33s | Max:  4m 45s
  🟩 Clang12            Pass: 100%/4   | Total: 17m 43s | Avg:  4m 25s | Max:  4m 32s
  🟩 Clang13            Pass: 100%/4   | Total: 18m 25s | Avg:  4m 36s | Max:  4m 45s
  🟩 Clang14            Pass: 100%/4   | Total: 18m 11s | Avg:  4m 32s | Max:  4m 43s
  🟩 Clang15            Pass: 100%/4   | Total: 18m 54s | Avg:  4m 43s | Max:  5m 02s
  🟩 Clang16            Pass: 100%/4   | Total: 18m 54s | Avg:  4m 43s | Max:  4m 53s
  🟩 Clang17            Pass: 100%/4   | Total: 18m 13s | Avg:  4m 33s | Max:  4m 39s
  🟩 Clang18            Pass: 100%/9   | Total:  1h 10m | Avg:  7m 52s | Max: 23m 30s
  🟩 GCC6               Pass: 100%/2   | Total:  7m 44s | Avg:  3m 52s | Max:  3m 59s
  🟩 GCC7               Pass: 100%/6   | Total: 23m 41s | Avg:  3m 56s | Max:  4m 32s
  🟩 GCC8               Pass: 100%/6   | Total: 25m 31s | Avg:  4m 15s | Max:  4m 39s
  🟩 GCC9               Pass: 100%/6   | Total:  1h 10m | Avg: 11m 42s | Max: 49m 20s
  🟩 GCC10              Pass: 100%/4   | Total: 18m 53s | Avg:  4m 43s | Max:  4m 51s
  🟩 GCC11              Pass: 100%/7   | Total: 32m 40s | Avg:  4m 40s | Max:  5m 01s
  🟩 GCC12              Pass: 100%/4   | Total: 19m 11s | Avg:  4m 47s | Max:  5m 14s
  🟩 GCC13              Pass: 100%/16  | Total:  2h 55m | Avg: 10m 57s | Max: 32m 11s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 16m 15s | Avg:  5m 25s | Max:  5m 32s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 16m 16s | Avg: 16m 16s | Max: 16m 16s | Hits:  99%/727   
  🟩 MSVC14.29          Pass: 100%/2   | Total: 26m 15s | Avg: 13m 07s | Max: 13m 40s | Hits:  99%/1454  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 14m 56s | Avg: 14m 56s | Max: 14m 56s | Hits:  99%/727   
🟩 cxx_family
  🟩 Clang              Pass: 100%/46  | Total:  4h 03m | Avg:  5m 18s | Max: 23m 30s
  🟩 GCC                Pass: 100%/51  | Total:  6h 13m | Avg:  7m 19s | Max: 49m 20s
  🟩 Intel              Pass: 100%/3   | Total: 16m 15s | Avg:  5m 25s | Max:  5m 32s
  🟩 MSVC               Pass: 100%/4   | Total: 57m 27s | Avg: 14m 21s | Max: 16m 16s | Hits:  99%/2908  
🟩 gpu
  🟩 v100               Pass: 100%/104 | Total: 11h 30m | Avg:  6m 38s | Max: 49m 20s | Hits:  99%/2908  
🟩 jobs
  🟩 Build              Pass: 100%/96  | Total:  8h 35m | Avg:  5m 22s | Max: 49m 20s | Hits:  99%/2908  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 19m 35s | Avg: 19m 35s | Max: 19m 35s
  🟩 GraphCapture       Pass: 100%/1   | Total: 16m 22s | Avg: 16m 22s | Max: 16m 22s
  🟩 HostLaunch         Pass: 100%/3   | Total: 51m 38s | Avg: 17m 12s | Max: 19m 04s
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 27m | Avg: 29m 08s | Max: 32m 11s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 14m 04s | Avg:  4m 41s | Max:  4m 57s
  🟩 90a                Pass: 100%/4   | Total: 15m 08s | Avg:  3m 47s | Max:  3m 59s
🟩 std
  🟩 11                 Pass: 100%/28  | Total:  2h 40m | Avg:  5m 44s | Max: 31m 44s
  🟩 14                 Pass: 100%/27  | Total:  2h 22m | Avg:  5m 16s | Max: 16m 16s | Hits:  99%/1454  
  🟩 17                 Pass: 100%/26  | Total:  2h 50m | Avg:  6m 34s | Max: 49m 20s | Hits:  99%/727   
  🟩 20                 Pass: 100%/23  | Total:  3h 36m | Avg:  9m 25s | Max: 32m 11s | Hits:  99%/727

  • 🟩 libcudacxx: Pass: 100%/104 | Total: 14h 46m | Avg: 8m 31s | Max: 29m 33s | Hits: 96%/11438 

    🟩 cpu
  🟩 amd64              Pass: 100%/96  | Total: 14h 03m | Avg:  8m 47s | Max: 29m 33s | Hits:  96%/11438 
  🟩 arm64              Pass: 100%/8   | Total: 42m 25s | Avg:  5m 18s | Max: 17m 58s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 38m | Avg:  6m 33s | Max: 24m 05s | Hits:  88%/2661  
  🟩 11.8               Pass: 100%/3   | Total:  1h 10m | Avg: 23m 28s | Max: 26m 46s
  🟩 12.6               Pass: 100%/86  | Total: 11h 57m | Avg:  8m 20s | Max: 29m 33s | Hits:  99%/8777  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 38m 08s | Avg: 19m 04s | Max: 21m 16s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 38m | Avg:  6m 33s | Max: 24m 05s | Hits:  88%/2661  
  🟩 nvcc11.8           Pass: 100%/3   | Total:  1h 10m | Avg: 23m 28s | Max: 26m 46s
  🟩 nvcc12.6           Pass: 100%/84  | Total: 11h 19m | Avg:  8m 05s | Max: 29m 33s | Hits:  99%/8777  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 38m 08s | Avg: 19m 04s | Max: 21m 16s
  🟩 nvcc               Pass: 100%/102 | Total: 14h 08m | Avg:  8m 18s | Max: 29m 33s | Hits:  96%/11438 
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 47m 27s | Avg:  7m 54s | Max: 27m 34s
  🟩 Clang10            Pass: 100%/3   | Total: 15m 40s | Avg:  5m 13s | Max:  5m 53s
  🟩 Clang11            Pass: 100%/4   | Total: 48m 26s | Avg: 12m 06s | Max: 20m 59s
  🟩 Clang12            Pass: 100%/4   | Total: 16m 23s | Avg:  4m 05s | Max:  4m 24s
  🟩 Clang13            Pass: 100%/4   | Total: 40m 32s | Avg: 10m 08s | Max: 28m 41s
  🟩 Clang14            Pass: 100%/4   | Total: 16m 19s | Avg:  4m 04s | Max:  4m 15s
  🟩 Clang15            Pass: 100%/4   | Total: 17m 36s | Avg:  4m 24s | Max:  4m 39s
  🟩 Clang16            Pass: 100%/4   | Total: 17m 50s | Avg:  4m 27s | Max:  4m 57s
  🟩 Clang17            Pass: 100%/4   | Total: 17m 12s | Avg:  4m 18s | Max:  4m 29s
  🟩 Clang18            Pass: 100%/8   | Total:  1h 16m | Avg:  9m 31s | Max: 21m 16s
  🟩 GCC6               Pass: 100%/2   | Total:  5m 30s | Avg:  2m 45s | Max:  2m 52s
  🟩 GCC7               Pass: 100%/6   | Total: 39m 48s | Avg:  6m 38s | Max: 24m 05s
  🟩 GCC8               Pass: 100%/6   | Total: 33m 02s | Avg:  5m 30s | Max: 16m 00s
  🟩 GCC9               Pass: 100%/6   | Total: 32m 24s | Avg:  5m 24s | Max: 15m 31s
  🟩 GCC10              Pass: 100%/4   | Total: 28m 17s | Avg:  7m 04s | Max: 16m 47s
  🟩 GCC11              Pass: 100%/7   | Total:  2h 00m | Avg: 17m 12s | Max: 29m 33s
  🟩 GCC12              Pass: 100%/4   | Total: 34m 50s | Avg:  8m 42s | Max: 23m 10s
  🟩 GCC13              Pass: 100%/17  | Total:  2h 56m | Avg: 10m 23s | Max: 23m 17s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 33m 26s | Avg: 11m 08s | Max: 21m 59s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 23m 32s | Avg: 23m 32s | Max: 23m 32s | Hits:  88%/2661  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 28m 24s | Avg: 14m 12s | Max: 14m 15s | Hits:  99%/5686  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 16m 24s | Avg: 16m 24s | Max: 16m 24s | Hits:  99%/3091  
🟩 cxx_family
  🟩 Clang              Pass: 100%/45  | Total:  5h 13m | Avg:  6m 58s | Max: 28m 41s
  🟩 GCC                Pass: 100%/52  | Total:  7h 50m | Avg:  9m 03s | Max: 29m 33s
  🟩 Intel              Pass: 100%/3   | Total: 33m 26s | Avg: 11m 08s | Max: 21m 59s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 08m | Avg: 17m 05s | Max: 23m 32s | Hits:  96%/11438 
🟩 gpu
  🟩 v100               Pass: 100%/104 | Total: 14h 46m | Avg:  8m 31s | Max: 29m 33s | Hits:  96%/11438 
🟩 jobs
  🟩 Build              Pass: 100%/96  | Total: 12h 20m | Avg:  7m 42s | Max: 29m 33s | Hits:  96%/11438 
  🟩 NVRTC              Pass: 100%/4   | Total:  1h 23m | Avg: 20m 54s | Max: 22m 23s
  🟩 Test               Pass: 100%/3   | Total:  1h 00m | Avg: 20m 06s | Max: 23m 17s
  🟩 VerifyCodegen      Pass: 100%/1   | Total:  1m 50s | Avg:  1m 50s | Max:  1m 50s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  1h 10m | Avg: 23m 28s | Max: 26m 46s
  🟩 90a                Pass: 100%/4   | Total: 14m 35s | Avg:  3m 38s | Max:  3m 54s
🟩 std
  🟩 11                 Pass: 100%/28  | Total:  4h 06m | Avg:  8m 47s | Max: 24m 05s
  🟩 14                 Pass: 100%/28  | Total:  3h 33m | Avg:  7m 37s | Max: 24m 18s | Hits:  94%/5424  
  🟩 17                 Pass: 100%/27  | Total:  3h 55m | Avg:  8m 43s | Max: 28m 41s | Hits:  99%/2923  
  🟩 20                 Pass: 100%/20  | Total:  3h 09m | Avg:  9m 27s | Max: 29m 33s | Hits:  99%/3091

  • 🟩 thrust: Pass: 100%/103 | Total: 10h 18m | Avg: 6m 00s | Max: 29m 33s | Hits: 99%/11150 

    🟩 cpu
  🟩 amd64              Pass: 100%/95  | Total:  9h 42m | Avg:  6m 08s | Max: 29m 33s | Hits:  99%/11150 
  🟩 arm64              Pass: 100%/8   | Total: 35m 14s | Avg:  4m 24s | Max:  5m 17s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 15m | Avg:  5m 03s | Max: 20m 57s | Hits:  99%/2230  
  🟩 11.8               Pass: 100%/3   | Total: 14m 43s | Avg:  4m 54s | Max:  5m 29s
  🟩 12.6               Pass: 100%/85  | Total:  8h 47m | Avg:  6m 12s | Max: 29m 33s | Hits:  99%/8920  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  9m 30s | Avg:  4m 45s | Max:  5m 03s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 15m | Avg:  5m 03s | Max: 20m 57s | Hits:  99%/2230  
  🟩 nvcc11.8           Pass: 100%/3   | Total: 14m 43s | Avg:  4m 54s | Max:  5m 29s
  🟩 nvcc12.6           Pass: 100%/83  | Total:  8h 38m | Avg:  6m 14s | Max: 29m 33s | Hits:  99%/8920  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  9m 30s | Avg:  4m 45s | Max:  5m 03s
  🟩 nvcc               Pass: 100%/101 | Total: 10h 08m | Avg:  6m 01s | Max: 29m 33s | Hits:  99%/11150 
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 29m 04s | Avg:  4m 50s | Max:  6m 23s
  🟩 Clang10            Pass: 100%/3   | Total: 17m 43s | Avg:  5m 54s | Max:  6m 47s
  🟩 Clang11            Pass: 100%/4   | Total: 19m 48s | Avg:  4m 57s | Max:  5m 13s
  🟩 Clang12            Pass: 100%/4   | Total: 19m 11s | Avg:  4m 47s | Max:  5m 11s
  🟩 Clang13            Pass: 100%/4   | Total: 19m 36s | Avg:  4m 54s | Max:  5m 03s
  🟩 Clang14            Pass: 100%/4   | Total: 19m 41s | Avg:  4m 55s | Max:  5m 16s
  🟩 Clang15            Pass: 100%/4   | Total: 19m 53s | Avg:  4m 58s | Max:  5m 35s
  🟩 Clang16            Pass: 100%/4   | Total: 20m 08s | Avg:  5m 02s | Max:  5m 42s
  🟩 Clang17            Pass: 100%/4   | Total: 19m 17s | Avg:  4m 49s | Max:  4m 57s
  🟩 Clang18            Pass: 100%/9   | Total: 51m 49s | Avg:  5m 45s | Max: 13m 02s
  🟩 GCC6               Pass: 100%/2   | Total:  7m 38s | Avg:  3m 49s | Max:  3m 59s
  🟩 GCC7               Pass: 100%/6   | Total: 26m 05s | Avg:  4m 20s | Max:  5m 18s
  🟩 GCC8               Pass: 100%/6   | Total: 25m 41s | Avg:  4m 16s | Max:  5m 14s
  🟩 GCC9               Pass: 100%/6   | Total: 26m 21s | Avg:  4m 23s | Max:  4m 59s
  🟩 GCC10              Pass: 100%/4   | Total: 19m 47s | Avg:  4m 56s | Max:  5m 19s
  🟩 GCC11              Pass: 100%/7   | Total: 34m 55s | Avg:  4m 59s | Max:  5m 31s
  🟩 GCC12              Pass: 100%/4   | Total: 19m 40s | Avg:  4m 55s | Max:  5m 09s
  🟩 GCC13              Pass: 100%/14  | Total:  1h 45m | Avg:  7m 32s | Max: 29m 33s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 18m 26s | Avg:  6m 08s | Max:  6m 43s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 20m 57s | Avg: 20m 57s | Max: 20m 57s | Hits:  99%/2230  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 33m 29s | Avg: 16m 44s | Max: 17m 02s | Hits:  99%/4460  
  🟩 MSVC14.39          Pass: 100%/2   | Total: 43m 29s | Avg: 21m 44s | Max: 25m 26s | Hits:  99%/4460  
🟩 cxx_family
  🟩 Clang              Pass: 100%/46  | Total:  3h 56m | Avg:  5m 08s | Max: 13m 02s
  🟩 GCC                Pass: 100%/49  | Total:  4h 25m | Avg:  5m 25s | Max: 29m 33s
  🟩 Intel              Pass: 100%/3   | Total: 18m 26s | Avg:  6m 08s | Max:  6m 43s
  🟩 MSVC               Pass: 100%/5   | Total:  1h 37m | Avg: 19m 35s | Max: 25m 26s | Hits:  99%/11150 
🟩 gpu
  🟩 v100               Pass: 100%/103 | Total: 10h 18m | Avg:  6m 00s | Max: 29m 33s | Hits:  99%/11150 
🟩 jobs
  🟩 Build              Pass: 100%/96  | Total:  8h 33m | Avg:  5m 20s | Max: 20m 57s | Hits:  99%/8920  
  🟩 TestCPU            Pass: 100%/4   | Total: 48m 08s | Avg: 12m 02s | Max: 25m 26s | Hits:  99%/2230  
  🟩 TestGPU            Pass: 100%/3   | Total: 56m 35s | Avg: 18m 51s | Max: 29m 33s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 14m 43s | Avg:  4m 54s | Max:  5m 29s
  🟩 90a                Pass: 100%/4   | Total: 16m 42s | Avg:  4m 10s | Max:  4m 18s
🟩 std
  🟩 11                 Pass: 100%/28  | Total:  2h 31m | Avg:  5m 24s | Max: 29m 33s
  🟩 14                 Pass: 100%/27  | Total:  2h 37m | Avg:  5m 49s | Max: 20m 57s | Hits:  99%/4460  
  🟩 17                 Pass: 100%/26  | Total:  2h 24m | Avg:  5m 34s | Max: 17m 02s | Hits:  99%/2230  
  🟩 20                 Pass: 100%/22  | Total:  2h 44m | Avg:  7m 29s | Max: 25m 26s | Hits:  99%/4460

  • 🟩 cudax: Pass: 100%/52 | Total: 2h 24m | Avg: 2m 46s | Max: 10m 08s | Hits: 91%/216 

    🟩 cpu
  🟩 amd64              Pass: 100%/48  | Total:  2h 16m | Avg:  2m 50s | Max: 10m 08s | Hits:  91%/216   
  🟩 arm64              Pass: 100%/4   | Total:  7m 40s | Avg:  1m 55s | Max:  2m 06s
🟩 ctk
  🟩 12.0               Pass: 100%/19  | Total: 54m 15s | Avg:  2m 51s | Max: 10m 07s | Hits:  91%/108   
  🟩 12.6               Pass: 100%/33  | Total:  1h 29m | Avg:  2m 43s | Max: 10m 08s | Hits:  91%/108   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/19  | Total: 54m 15s | Avg:  2m 51s | Max: 10m 07s | Hits:  91%/108   
  🟩 nvcc12.6           Pass: 100%/33  | Total:  1h 29m | Avg:  2m 43s | Max: 10m 08s | Hits:  91%/108   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/52  | Total:  2h 24m | Avg:  2m 46s | Max: 10m 08s | Hits:  91%/216   
🟩 cxx
  🟩 Clang9             Pass: 100%/2   | Total:  4m 57s | Avg:  2m 28s | Max:  2m 41s
  🟩 Clang10            Pass: 100%/2   | Total:  4m 40s | Avg:  2m 20s | Max:  2m 21s
  🟩 Clang11            Pass: 100%/4   | Total:  8m 56s | Avg:  2m 14s | Max:  2m 20s
  🟩 Clang12            Pass: 100%/4   | Total:  8m 53s | Avg:  2m 13s | Max:  2m 18s
  🟩 Clang13            Pass: 100%/4   | Total:  9m 04s | Avg:  2m 16s | Max:  2m 24s
  🟩 Clang14            Pass: 100%/4   | Total: 12m 24s | Avg:  3m 06s | Max:  5m 01s
  🟩 Clang15            Pass: 100%/2   | Total:  4m 47s | Avg:  2m 23s | Max:  2m 29s
  🟩 Clang16            Pass: 100%/4   | Total:  8m 35s | Avg:  2m 08s | Max:  2m 25s
  🟩 Clang17            Pass: 100%/2   | Total:  4m 48s | Avg:  2m 24s | Max:  2m 30s
  🟩 Clang18            Pass: 100%/2   | Total:  7m 09s | Avg:  3m 34s | Max:  4m 57s
  🟩 GCC9               Pass: 100%/2   | Total:  4m 33s | Avg:  2m 16s | Max:  2m 22s
  🟩 GCC10              Pass: 100%/4   | Total:  8m 39s | Avg:  2m 09s | Max:  2m 25s
  🟩 GCC11              Pass: 100%/4   | Total:  8m 18s | Avg:  2m 04s | Max:  2m 11s
  🟩 GCC12              Pass: 100%/7   | Total: 22m 16s | Avg:  3m 10s | Max:  4m 39s
  🟩 GCC13              Pass: 100%/3   | Total:  5m 56s | Avg:  1m 58s | Max:  2m 10s
  🟩 MSVC14.36          Pass: 100%/1   | Total: 10m 07s | Avg: 10m 07s | Max: 10m 07s | Hits:  91%/108   
  🟩 MSVC14.39          Pass: 100%/1   | Total: 10m 08s | Avg: 10m 08s | Max: 10m 08s | Hits:  91%/108   
🟩 cxx_family
  🟩 Clang              Pass: 100%/30  | Total:  1h 14m | Avg:  2m 28s | Max:  5m 01s
  🟩 GCC                Pass: 100%/20  | Total: 49m 42s | Avg:  2m 29s | Max:  4m 39s
  🟩 MSVC               Pass: 100%/2   | Total: 20m 15s | Avg: 10m 07s | Max: 10m 08s | Hits:  91%/216   
🟩 gpu
  🟩 v100               Pass: 100%/52  | Total:  2h 24m | Avg:  2m 46s | Max: 10m 08s | Hits:  91%/216   
🟩 jobs
  🟩 Build              Pass: 100%/47  | Total:  2h 00m | Avg:  2m 34s | Max: 10m 08s | Hits:  91%/216   
  🟩 Test               Pass: 100%/5   | Total: 23m 17s | Avg:  4m 39s | Max:  5m 01s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  2m 15s | Avg:  2m 15s | Max:  2m 15s
  🟩 90a                Pass: 100%/1   | Total:  2m 10s | Avg:  2m 10s | Max:  2m 10s
🟩 std
  🟩 17                 Pass: 100%/28  | Total:  1h 07m | Avg:  2m 24s | Max:  4m 39s
  🟩 20                 Pass: 100%/24  | Total:  1h 16m | Avg:  3m 11s | Max: 10m 08s | Hits:  91%/216

  • 🟩 pycuda: Pass: 100%/1 | Total: 16m 04s | Avg: 16m 04s | Max: 16m 04s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 16m 04s | Avg: 16m 04s | Max: 16m 04s
🟩 ctk
  🟩 12.5               Pass: 100%/1   | Total: 16m 04s | Avg: 16m 04s | Max: 16m 04s
🟩 cudacxx
  🟩 nvcc12.5           Pass: 100%/1   | Total: 16m 04s | Avg: 16m 04s | Max: 16m 04s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 16m 04s | Avg: 16m 04s | Max: 16m 04s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 16m 04s | Avg: 16m 04s | Max: 16m 04s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 16m 04s | Avg: 16m 04s | Max: 16m 04s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 16m 04s | Avg: 16m 04s | Max: 16m 04s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 16m 04s | Avg: 16m 04s | Max: 16m 04s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
+/- libcu++
CUB
Thrust
CUDA Experimental
pycuda
CUDA C Core Library

Modifications in project or dependencies?

Project
CCCL Infrastructure
+/- libcu++
+/- CUB
+/- Thrust
+/- CUDA Experimental
+/- pycuda
+/- CUDA C Core Library

🏃‍ Runner counts (total jobs: 364)
# Runner
297 linux-amd64-cpu16
28 linux-arm64-cpu16
24 linux-amd64-gpu-v100-latest-1
15 windows-amd64-cpu16

miscco
miscco requested changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am opposed to that.

This is an internal feature that is uniformly used throughout the whole libraries. We always include compliler.h through the __cccl_config which is included everywhere through the respective library configs.

If we ever have issues with that it is a library bug

@fbusato
Copy link
Contributor Author

fbusato commented Oct 4, 2024 •
edited
Loading

I agree on your point, but it is minimal change that doesn't affect CCCL. I don't see any downside right now. Secondly, the next step is to expose such macros, see. #2504. They are so common across the CUDA ecosystem that would be weird to keep them internal only.

EDIT: without #2504, this PR makes little sense

@fbusato fbusato closed this Oct 14, 2024
@fbusato fbusato mentioned this pull request Nov 12, 2024
Closed
1 task
@fbusato fbusato deleted the compiler-macro-with-values branch November 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco requested changes

@alliepiper alliepiper Awaiting requested review from alliepiper alliepiper was automatically assigned from NVIDIA/cccl-codeowners

Assignees

@fbusato fbusato

Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbusato @miscco