Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the forwarding of the receiver in the just_from algorithm #2569

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

ericniebler
Copy link
Collaborator

Description

a typo in the just_from algorithm meant that a receiver is getting passed as an lvalue to a completion function. not all receivers have .set_[value|error|stopped]() members that are callable on lvalue object. this PR fixes the typo and correctly forwards the receiver.

as a drive-by, i also fix a conformance issue by making environments not move/copy assignable.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ericniebler ericniebler requested a review from a team as a code owner October 12, 2024 01:12
Copy link
Contributor

🟨 CI finished in 13m 35s: Pass: 96%/52 | Total: 2h 37m | Avg: 3m 01s | Max: 11m 50s | Hits: 68%/216
  • 🟨 cudax: Pass: 96%/52 | Total: 2h 37m | Avg: 3m 01s | Max: 11m 50s | Hits: 68%/216

    🔍 cpu: amd64 🔍
      🔍 amd64              Pass:  95%/48  | Total:  2h 27m | Avg:  3m 03s | Max: 11m 50s | Hits:  68%/216   
      🟩 arm64              Pass: 100%/4   | Total: 10m 18s | Avg:  2m 34s | Max:  3m 35s
    🚨 cxx: Clang9 🚨
      🔥 Clang9             Pass:   0%/2   | Total:  4m 14s | Avg:  2m 07s | Max:  2m 08s
      🟩 Clang10            Pass: 100%/2   | Total:  5m 19s | Avg:  2m 39s | Max:  2m 42s
      🟩 Clang11            Pass: 100%/4   | Total:  9m 57s | Avg:  2m 29s | Max:  2m 40s
      🟩 Clang12            Pass: 100%/4   | Total: 10m 15s | Avg:  2m 33s | Max:  2m 46s
      🟩 Clang13            Pass: 100%/4   | Total: 10m 11s | Avg:  2m 32s | Max:  2m 41s
      🟩 Clang14            Pass: 100%/4   | Total: 12m 17s | Avg:  3m 04s | Max:  4m 03s
      🟩 Clang15            Pass: 100%/2   | Total:  5m 43s | Avg:  2m 51s | Max:  2m 54s
      🟩 Clang16            Pass: 100%/4   | Total: 10m 13s | Avg:  2m 33s | Max:  2m 49s
      🟩 Clang17            Pass: 100%/2   | Total:  5m 45s | Avg:  2m 52s | Max:  2m 53s
      🟩 Clang18            Pass: 100%/2   | Total:  6m 54s | Avg:  3m 27s | Max:  4m 15s
      🟩 GCC9               Pass: 100%/2   | Total:  4m 47s | Avg:  2m 23s | Max:  2m 28s
      🟩 GCC10              Pass: 100%/4   | Total: 10m 00s | Avg:  2m 30s | Max:  2m 37s
      🟩 GCC11              Pass: 100%/4   | Total: 10m 04s | Avg:  2m 31s | Max:  2m 36s
      🟩 GCC12              Pass: 100%/7   | Total: 21m 15s | Avg:  3m 02s | Max:  4m 02s
      🟩 GCC13              Pass: 100%/3   | Total:  8m 03s | Avg:  2m 41s | Max:  3m 35s
      🟩 MSVC14.36          Pass: 100%/1   | Total: 10m 34s | Avg: 10m 34s | Max: 10m 34s | Hits:  68%/108   
      🟩 MSVC14.39          Pass: 100%/1   | Total: 11m 50s | Avg: 11m 50s | Max: 11m 50s | Hits:  68%/108   
    🔍 cxx_family: Clang 🔍
      🔍 Clang              Pass:  93%/30  | Total:  1h 20m | Avg:  2m 41s | Max:  4m 15s
      🟩 GCC                Pass: 100%/20  | Total: 54m 09s | Avg:  2m 42s | Max:  4m 02s
      🟩 MSVC               Pass: 100%/2   | Total: 22m 24s | Avg: 11m 12s | Max: 11m 50s | Hits:  68%/216   
    🔍 jobs: Build 🔍
      🔍 Build              Pass:  95%/47  | Total:  2h 17m | Avg:  2m 55s | Max: 11m 50s | Hits:  68%/216   
      🟩 Test               Pass: 100%/5   | Total: 19m 36s | Avg:  3m 55s | Max:  4m 15s
    🔍 std: 17 🔍
      🔍 17                 Pass:  92%/28  | Total:  1h 13m | Avg:  2m 38s | Max:  3m 57s
      🟩 20                 Pass: 100%/24  | Total:  1h 23m | Avg:  3m 29s | Max: 11m 50s | Hits:  68%/216   
    🟨 cudacxx_family
      🟨 nvcc               Pass:  96%/52  | Total:  2h 37m | Avg:  3m 01s | Max: 11m 50s | Hits:  68%/216   
    🟨 gpu
      🟨 v100               Pass:  96%/52  | Total:  2h 37m | Avg:  3m 01s | Max: 11m 50s | Hits:  68%/216   
    🟨 ctk
      🟨 12.0               Pass:  94%/19  | Total: 57m 06s | Avg:  3m 00s | Max: 10m 34s | Hits:  68%/108   
      🟨 12.6               Pass:  96%/33  | Total:  1h 40m | Avg:  3m 02s | Max: 11m 50s | Hits:  68%/108   
    🟨 cudacxx
      🟨 nvcc12.0           Pass:  94%/19  | Total: 57m 06s | Avg:  3m 00s | Max: 10m 34s | Hits:  68%/108   
      🟨 nvcc12.6           Pass:  96%/33  | Total:  1h 40m | Avg:  3m 02s | Max: 11m 50s | Hits:  68%/108   
    🟩 sm
      🟩 90                 Pass: 100%/1   | Total:  2m 20s | Avg:  2m 20s | Max:  2m 20s
      🟩 90a                Pass: 100%/1   | Total:  2m 20s | Avg:  2m 20s | Max:  2m 20s
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CCCL C Parallel Library

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CCCL C Parallel Library

🏃‍ Runner counts (total jobs: 52)

# Runner
41 linux-amd64-cpu16
5 linux-amd64-gpu-v100-latest-1
4 linux-arm64-cpu16
2 windows-amd64-cpu16

Copy link
Contributor

🟩 CI finished in 14m 55s: Pass: 100%/52 | Total: 2h 39m | Avg: 3m 03s | Max: 11m 43s | Hits: 68%/216
  • 🟩 cudax: Pass: 100%/52 | Total: 2h 39m | Avg: 3m 03s | Max: 11m 43s | Hits: 68%/216

    🟩 cpu
      🟩 amd64              Pass: 100%/48  | Total:  2h 29m | Avg:  3m 07s | Max: 11m 43s | Hits:  68%/216   
      🟩 arm64              Pass: 100%/4   | Total:  9m 30s | Avg:  2m 22s | Max:  2m 47s
    🟩 ctk
      🟩 12.0               Pass: 100%/19  | Total: 58m 18s | Avg:  3m 04s | Max: 11m 43s | Hits:  68%/108   
      🟩 12.6               Pass: 100%/33  | Total:  1h 41m | Avg:  3m 03s | Max: 10m 57s | Hits:  68%/108   
    🟩 cudacxx
      🟩 nvcc12.0           Pass: 100%/19  | Total: 58m 18s | Avg:  3m 04s | Max: 11m 43s | Hits:  68%/108   
      🟩 nvcc12.6           Pass: 100%/33  | Total:  1h 41m | Avg:  3m 03s | Max: 10m 57s | Hits:  68%/108   
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/52  | Total:  2h 39m | Avg:  3m 03s | Max: 11m 43s | Hits:  68%/216   
    🟩 cxx
      🟩 Clang9             Pass: 100%/2   | Total:  5m 07s | Avg:  2m 33s | Max:  2m 39s
      🟩 Clang10            Pass: 100%/2   | Total:  5m 10s | Avg:  2m 35s | Max:  2m 43s
      🟩 Clang11            Pass: 100%/4   | Total: 10m 28s | Avg:  2m 37s | Max:  3m 05s
      🟩 Clang12            Pass: 100%/4   | Total: 10m 12s | Avg:  2m 33s | Max:  2m 41s
      🟩 Clang13            Pass: 100%/4   | Total: 10m 11s | Avg:  2m 32s | Max:  2m 37s
      🟩 Clang14            Pass: 100%/4   | Total: 11m 58s | Avg:  2m 59s | Max:  3m 44s
      🟩 Clang15            Pass: 100%/2   | Total:  5m 14s | Avg:  2m 37s | Max:  2m 42s
      🟩 Clang16            Pass: 100%/4   | Total:  9m 50s | Avg:  2m 27s | Max:  2m 41s
      🟩 Clang17            Pass: 100%/2   | Total:  5m 25s | Avg:  2m 42s | Max:  2m 46s
      🟩 Clang18            Pass: 100%/2   | Total:  8m 25s | Avg:  4m 12s | Max:  5m 35s
      🟩 GCC9               Pass: 100%/2   | Total:  4m 39s | Avg:  2m 19s | Max:  2m 22s
      🟩 GCC10              Pass: 100%/4   | Total:  9m 45s | Avg:  2m 26s | Max:  2m 30s
      🟩 GCC11              Pass: 100%/4   | Total: 10m 09s | Avg:  2m 32s | Max:  2m 37s
      🟩 GCC12              Pass: 100%/7   | Total: 23m 00s | Avg:  3m 17s | Max:  5m 22s
      🟩 GCC13              Pass: 100%/3   | Total:  7m 06s | Avg:  2m 22s | Max:  2m 47s
      🟩 MSVC14.36          Pass: 100%/1   | Total: 11m 43s | Avg: 11m 43s | Max: 11m 43s | Hits:  68%/108   
      🟩 MSVC14.39          Pass: 100%/1   | Total: 10m 57s | Avg: 10m 57s | Max: 10m 57s | Hits:  68%/108   
    🟩 cxx_family
      🟩 Clang              Pass: 100%/30  | Total:  1h 22m | Avg:  2m 44s | Max:  5m 35s
      🟩 GCC                Pass: 100%/20  | Total: 54m 39s | Avg:  2m 43s | Max:  5m 22s
      🟩 MSVC               Pass: 100%/2   | Total: 22m 40s | Avg: 11m 20s | Max: 11m 43s | Hits:  68%/216   
    🟩 gpu
      🟩 v100               Pass: 100%/52  | Total:  2h 39m | Avg:  3m 03s | Max: 11m 43s | Hits:  68%/216   
    🟩 jobs
      🟩 Build              Pass: 100%/47  | Total:  2h 17m | Avg:  2m 55s | Max: 11m 43s | Hits:  68%/216   
      🟩 Test               Pass: 100%/5   | Total: 22m 12s | Avg:  4m 26s | Max:  5m 35s
    🟩 sm
      🟩 90                 Pass: 100%/1   | Total:  2m 15s | Avg:  2m 15s | Max:  2m 15s
      🟩 90a                Pass: 100%/1   | Total:  2m 12s | Avg:  2m 12s | Max:  2m 12s
    🟩 std
      🟩 17                 Pass: 100%/28  | Total:  1h 13m | Avg:  2m 36s | Max:  4m 05s
      🟩 20                 Pass: 100%/24  | Total:  1h 26m | Avg:  3m 35s | Max: 11m 43s | Hits:  68%/216   
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CCCL C Parallel Library

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CCCL C Parallel Library

🏃‍ Runner counts (total jobs: 52)

# Runner
41 linux-amd64-cpu16
5 linux-amd64-gpu-v100-latest-1
4 linux-arm64-cpu16
2 windows-amd64-cpu16

@ericniebler ericniebler merged commit e86947f into NVIDIA:main Oct 14, 2024
66 checks passed
@ericniebler ericniebler deleted the cudax-fix-just-from branch October 14, 2024 18:58
caugonnet pushed a commit to caugonnet/cccl that referenced this pull request Oct 16, 2024
…IA#2569)

* fix the forwarding of the receiver in the `just_from` algorithm

* suppress clang deprecation warning about `prop` and `env`

* suppress clang warning about unknown diagnostic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants