-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the forwarding of the receiver in the just_from
algorithm
#2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pciolkosz
approved these changes
Oct 12, 2024
miscco
approved these changes
Oct 14, 2024
🟨 CI finished in 13m 35s: Pass: 96%/52 | Total: 2h 37m | Avg: 3m 01s | Max: 11m 50s | Hits: 68%/216
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
CCCL C Parallel Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
CCCL C Parallel Library |
🏃 Runner counts (total jobs: 52)
# | Runner |
---|---|
41 | linux-amd64-cpu16 |
5 | linux-amd64-gpu-v100-latest-1 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
🟩 CI finished in 14m 55s: Pass: 100%/52 | Total: 2h 39m | Avg: 3m 03s | Max: 11m 43s | Hits: 68%/216
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
CCCL C Parallel Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
CCCL C Parallel Library |
🏃 Runner counts (total jobs: 52)
# | Runner |
---|---|
41 | linux-amd64-cpu16 |
5 | linux-amd64-gpu-v100-latest-1 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
caugonnet
pushed a commit
to caugonnet/cccl
that referenced
this pull request
Oct 16, 2024
…IA#2569) * fix the forwarding of the receiver in the `just_from` algorithm * suppress clang deprecation warning about `prop` and `env` * suppress clang warning about unknown diagnostic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a typo in the
just_from
algorithm meant that a receiver is getting passed as an lvalue to a completion function. not all receivers have.set_[value|error|stopped]()
members that are callable on lvalue object. this PR fixes the typo and correctly forwards the receiver.as a drive-by, i also fix a conformance issue by making environments not move/copy assignable.
Checklist