Reorganize PTX docs to match generator #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Nov 22, 2024
ahendriksen
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Hi, this is really great! I spot-checked the rendered docs, and it looks good.
To make reviewing easier, I undid the renaming of the file non-generated files (diff). That made the diff a lot easier to comb through.
Co-authored-by: Allard Hendriksen <[email protected]>
bernhardmgruber
force-pushed
the
ptx_docs_gen
branch
from
b2004ea to
3cd13f0
Compare
ahendriksen
approved these changes
Nov 22, 2024
davebayer
pushed a commit
to davebayer/cccl
that referenced
this pull request
Nov 22, 2024
Co-authored-by: Allard Hendriksen <[email protected]>
trxcllnt
pushed a commit
to trxcllnt/cccl
that referenced
this pull request
Nov 23, 2024
Co-authored-by: Allard Hendriksen <[email protected]>
davebayer
pushed a commit
to davebayer/cccl
that referenced
this pull request
Dec 2, 2024
Co-authored-by: Allard Hendriksen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the
cuda::ptxdocumentation into the generated and manually written part. It's just moving around content and renaming files. No other changes.