Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid symbol clashes with libc++ #2955

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Avoid symbol clashes with libc++ #2955

merged 2 commits into from
Nov 26, 2024

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Nov 25, 2024

libc++ has recently moved towards only qualifying their function calls with plain std:: rather than a fully qualified ::std::

That leads to potential symbol clashes with everything that is in namespace cuda::std

As a first step we should drop any __libcpp prefix in favor of a cccl one.

I was contemplating using __libcupp but settled on our prefered __cccl

While we are at it, drop one of the most frequent occurences by backporting is_constant_evaluated

@miscco
Drop __libcpp prefix in favor of __cccl
5bc7448 
libc++ has moved towards just using unqualified `std::` for any partial qualification.

That leads to a high chance of symbol clashes if we use the same names as them. As a first replace all uses of `__libcpp` with `_cccl`

I was wondering about `__libcupp` but 🤷
@miscco miscco requested review from a team as code owners November 25, 2024 15:38
@miscco miscco requested review from griwes and gevtushenko November 25, 2024 15:38
@miscco miscco force-pushed the avoid_libcpp_symbol_clashes branch 4 times, most recently from 2227597 to 96ae632 Compare November 25, 2024 18:36
@miscco miscco force-pushed the avoid_libcpp_symbol_clashes branch from 96ae632 to ee29dfc Compare November 25, 2024 18:41
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 3h 26m: Pass: 100%/396 | Total: 2d 23h | Avg: 10m 48s | Max: 1h 25m | Hits: 84%/22058

  • 🟩 libcudacxx: Pass: 100%/118 | Total: 1d 11h | Avg: 17m 48s | Max: 53m 00s | Hits: 65%/9524 

    🟩 cpu
  🟩 amd64              Pass: 100%/110 | Total:  1d 08h | Avg: 17m 52s | Max: 53m 00s | Hits:  65%/9524  
  🟩 arm64              Pass: 100%/8   | Total:  2h 15m | Avg: 16m 56s | Max: 25m 58s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  4h 24m | Avg: 17m 37s | Max: 36m 48s | Hits:  35%/2187  
  🟩 11.8               Pass: 100%/3   | Total:  1h 15m | Avg: 25m 15s | Max: 29m 21s
  🟩 12.5               Pass: 100%/4   | Total:  2h 22m | Avg: 35m 30s | Max: 38m 28s
  🟩 12.6               Pass: 100%/96  | Total:  1d 03h | Avg: 16m 52s | Max: 53m 00s | Hits:  74%/7337  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/12  | Total:  2h 40m | Avg: 13m 22s | Max: 24m 59s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  4h 24m | Avg: 17m 37s | Max: 36m 48s | Hits:  35%/2187  
  🟩 nvcc11.8           Pass: 100%/3   | Total:  1h 15m | Avg: 25m 15s | Max: 29m 21s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  2h 22m | Avg: 35m 30s | Max: 38m 28s
  🟩 nvcc12.6           Pass: 100%/84  | Total:  1d 00h | Avg: 17m 22s | Max: 53m 00s | Hits:  74%/7337  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/12  | Total:  2h 40m | Avg: 13m 22s | Max: 24m 59s
  🟩 nvcc               Pass: 100%/106 | Total:  1d 08h | Avg: 18m 19s | Max: 53m 00s | Hits:  65%/9524  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  1h 52m | Avg: 18m 43s | Max: 27m 18s
  🟩 Clang10            Pass: 100%/3   | Total: 35m 53s | Avg: 11m 57s | Max: 23m 02s
  🟩 Clang11            Pass: 100%/4   | Total:  1h 16m | Avg: 19m 04s | Max: 28m 34s
  🟩 Clang12            Pass: 100%/4   | Total: 51m 16s | Avg: 12m 49s | Max: 22m 37s
  🟩 Clang13            Pass: 100%/4   | Total:  1h 38m | Avg: 24m 34s | Max: 30m 11s
  🟩 Clang14            Pass: 100%/4   | Total:  1h 19m | Avg: 19m 58s | Max: 24m 55s
  🟩 Clang15            Pass: 100%/4   | Total: 40m 14s | Avg: 10m 03s | Max: 25m 59s
  🟩 Clang16            Pass: 100%/4   | Total: 57m 26s | Avg: 14m 21s | Max: 31m 00s
  🟩 Clang17            Pass: 100%/4   | Total:  1h 17m | Avg: 19m 24s | Max: 30m 53s
  🟩 Clang18            Pass: 100%/18  | Total:  4h 26m | Avg: 14m 46s | Max: 24m 59s
  🟩 GCC6               Pass: 100%/2   | Total: 22m 04s | Avg: 11m 02s | Max: 17m 55s
  🟩 GCC7               Pass: 100%/6   | Total:  1h 29m | Avg: 14m 59s | Max: 24m 57s
  🟩 GCC8               Pass: 100%/6   | Total:  1h 46m | Avg: 17m 49s | Max: 24m 53s
  🟩 GCC9               Pass: 100%/6   | Total:  2h 06m | Avg: 21m 04s | Max: 30m 01s
  🟩 GCC10              Pass: 100%/4   | Total:  1h 04m | Avg: 16m 08s | Max: 31m 22s
  🟩 GCC11              Pass: 100%/7   | Total:  2h 34m | Avg: 22m 03s | Max: 29m 21s
  🟩 GCC12              Pass: 100%/4   | Total:  1h 12m | Avg: 18m 03s | Max: 27m 25s
  🟩 GCC13              Pass: 100%/17  | Total:  4h 38m | Avg: 16m 24s | Max: 53m 00s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 42m 07s | Avg: 14m 02s | Max: 27m 58s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 36m 48s | Avg: 36m 48s | Max: 36m 48s | Hits:  35%/2187  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 25m 13s | Avg: 12m 36s | Max: 13m 05s | Hits:  98%/4737  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 45m 21s | Avg: 45m 21s | Max: 45m 21s | Hits:  29%/2600  
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  2h 22m | Avg: 35m 30s | Max: 38m 28s
🟩 cxx_family
  🟩 Clang              Pass: 100%/55  | Total: 14h 55m | Avg: 16m 16s | Max: 31m 00s
  🟩 GCC                Pass: 100%/52  | Total: 15h 15m | Avg: 17m 36s | Max: 53m 00s
  🟩 Intel              Pass: 100%/3   | Total: 42m 07s | Avg: 14m 02s | Max: 27m 58s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 47m | Avg: 26m 50s | Max: 45m 21s | Hits:  65%/9524  
  🟩 NVHPC              Pass: 100%/4   | Total:  2h 22m | Avg: 35m 30s | Max: 38m 28s
🟩 gpu
  🟩 v100               Pass: 100%/118 | Total:  1d 11h | Avg: 17m 48s | Max: 53m 00s | Hits:  65%/9524  
🟩 jobs
  🟩 Build              Pass: 100%/110 | Total:  1d 07h | Avg: 17m 26s | Max: 45m 21s | Hits:  65%/9524  
  🟩 NVRTC              Pass: 100%/4   | Total:  1h 25m | Avg: 21m 27s | Max: 22m 46s
  🟩 Test               Pass: 100%/3   | Total:  1h 35m | Avg: 31m 56s | Max: 53m 00s
  🟩 VerifyCodegen      Pass: 100%/1   | Total:  2m 39s | Avg:  2m 39s | Max:  2m 39s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  1h 15m | Avg: 25m 15s | Max: 29m 21s
  🟩 90                 Pass: 100%/4   | Total: 42m 46s | Avg: 10m 41s | Max: 12m 33s
  🟩 90a                Pass: 100%/8   | Total:  1h 03m | Avg:  7m 53s | Max: 13m 05s
🟩 std
  🟩 11                 Pass: 100%/32  | Total:  8h 54m | Avg: 16m 42s | Max: 53m 00s
  🟩 14                 Pass: 100%/32  | Total:  9h 21m | Avg: 17m 32s | Max: 37m 17s | Hits:  67%/4477  
  🟩 17                 Pass: 100%/30  | Total:  8h 58m | Avg: 17m 56s | Max: 38m 28s | Hits:  98%/2447  
  🟩 20                 Pass: 100%/23  | Total:  7h 45m | Avg: 20m 13s | Max: 45m 21s | Hits:  29%/2600

  • 🟩 thrust: Pass: 100%/111 | Total: 13h 19m | Avg: 7m 12s | Max: 28m 07s | Hits: 99%/9260 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 34m 04s | Avg: 17m 02s | Max: 28m 07s
🟩 cpu
  🟩 amd64              Pass: 100%/103 | Total: 12h 40m | Avg:  7m 23s | Max: 28m 07s | Hits:  99%/9260  
  🟩 arm64              Pass: 100%/8   | Total: 39m 01s | Avg:  4m 52s | Max:  5m 27s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 25m | Avg:  5m 40s | Max: 18m 16s | Hits:  99%/1852  
  🟩 11.8               Pass: 100%/3   | Total: 18m 20s | Avg:  6m 06s | Max:  6m 47s
  🟩 12.5               Pass: 100%/4   | Total:  1h 04m | Avg: 16m 07s | Max: 17m 18s
  🟩 12.6               Pass: 100%/89  | Total: 10h 31m | Avg:  7m 05s | Max: 28m 07s | Hits:  99%/7408  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 22m 04s | Avg:  5m 31s | Max:  5m 57s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 25m | Avg:  5m 40s | Max: 18m 16s | Hits:  99%/1852  
  🟩 nvcc11.8           Pass: 100%/3   | Total: 18m 20s | Avg:  6m 06s | Max:  6m 47s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  1h 04m | Avg: 16m 07s | Max: 17m 18s
  🟩 nvcc12.6           Pass: 100%/85  | Total: 10h 09m | Avg:  7m 10s | Max: 28m 07s | Hits:  99%/7408  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total: 22m 04s | Avg:  5m 31s | Max:  5m 57s
  🟩 nvcc               Pass: 100%/107 | Total: 12h 57m | Avg:  7m 15s | Max: 28m 07s | Hits:  99%/9260  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 34m 01s | Avg:  5m 40s | Max:  6m 52s
  🟩 Clang10            Pass: 100%/3   | Total: 19m 35s | Avg:  6m 31s | Max:  7m 11s
  🟩 Clang11            Pass: 100%/4   | Total: 21m 11s | Avg:  5m 17s | Max:  5m 54s
  🟩 Clang12            Pass: 100%/4   | Total: 21m 49s | Avg:  5m 27s | Max:  5m 52s
  🟩 Clang13            Pass: 100%/4   | Total: 25m 10s | Avg:  6m 17s | Max:  8m 17s
  🟩 Clang14            Pass: 100%/4   | Total: 22m 20s | Avg:  5m 35s | Max:  5m 48s
  🟩 Clang15            Pass: 100%/4   | Total: 22m 26s | Avg:  5m 36s | Max:  5m 48s
  🟩 Clang16            Pass: 100%/4   | Total: 23m 42s | Avg:  5m 55s | Max:  6m 19s
  🟩 Clang17            Pass: 100%/4   | Total: 22m 26s | Avg:  5m 36s | Max:  6m 01s
  🟩 Clang18            Pass: 100%/11  | Total:  1h 18m | Avg:  7m 07s | Max: 24m 45s
  🟩 GCC6               Pass: 100%/2   | Total:  9m 10s | Avg:  4m 35s | Max:  4m 39s
  🟩 GCC7               Pass: 100%/6   | Total: 30m 07s | Avg:  5m 01s | Max:  5m 47s
  🟩 GCC8               Pass: 100%/6   | Total: 31m 48s | Avg:  5m 18s | Max:  5m 51s
  🟩 GCC9               Pass: 100%/6   | Total: 32m 45s | Avg:  5m 27s | Max:  6m 30s
  🟩 GCC10              Pass: 100%/4   | Total: 24m 56s | Avg:  6m 14s | Max:  6m 34s
  🟩 GCC11              Pass: 100%/7   | Total: 44m 18s | Avg:  6m 19s | Max:  6m 51s
  🟩 GCC12              Pass: 100%/4   | Total: 25m 42s | Avg:  6m 25s | Max:  7m 12s
  🟩 GCC13              Pass: 100%/16  | Total:  2h 11m | Avg:  8m 13s | Max: 28m 07s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 24m 09s | Avg:  8m 03s | Max:  8m 11s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 18m 16s | Avg: 18m 16s | Max: 18m 16s | Hits:  99%/1852  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 32m 12s | Avg: 16m 06s | Max: 17m 14s | Hits:  99%/3704  
  🟩 MSVC14.39          Pass: 100%/2   | Total: 39m 01s | Avg: 19m 30s | Max: 20m 50s | Hits:  99%/3704  
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  1h 04m | Avg: 16m 07s | Max: 17m 18s
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  4h 51m | Avg:  6m 03s | Max: 24m 45s
  🟩 GCC                Pass: 100%/51  | Total:  5h 30m | Avg:  6m 28s | Max: 28m 07s
  🟩 Intel              Pass: 100%/3   | Total: 24m 09s | Avg:  8m 03s | Max:  8m 11s
  🟩 MSVC               Pass: 100%/5   | Total:  1h 29m | Avg: 17m 53s | Max: 20m 50s | Hits:  99%/9260  
  🟩 NVHPC              Pass: 100%/4   | Total:  1h 04m | Avg: 16m 07s | Max: 17m 18s
🟩 gpu
  🟩 v100               Pass: 100%/111 | Total: 13h 19m | Avg:  7m 12s | Max: 28m 07s | Hits:  99%/9260  
🟩 jobs
  🟩 Build              Pass: 100%/103 | Total: 11h 12m | Avg:  6m 31s | Max: 18m 16s | Hits:  99%/7408  
  🟩 TestCPU            Pass: 100%/4   | Total: 43m 19s | Avg: 10m 49s | Max: 20m 50s | Hits:  99%/1852  
  🟩 TestGPU            Pass: 100%/4   | Total:  1h 23m | Avg: 20m 49s | Max: 28m 07s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 18m 20s | Avg:  6m 06s | Max:  6m 47s
  🟩 90a                Pass: 100%/4   | Total: 19m 44s | Avg:  4m 56s | Max:  5m 17s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  3h 02m | Avg:  6m 04s | Max: 18m 14s
  🟩 14                 Pass: 100%/29  | Total:  3h 15m | Avg:  6m 44s | Max: 18m 16s | Hits:  99%/3704  
  🟩 17                 Pass: 100%/27  | Total:  3h 02m | Avg:  6m 45s | Max: 17m 14s | Hits:  99%/1852  
  🟩 20                 Pass: 100%/23  | Total:  3h 25m | Avg:  8m 54s | Max: 24m 45s | Hits:  99%/3704

  • 🟩 cub: Pass: 100%/110 | Total: 17h 34m | Avg: 9m 35s | Max: 1h 25m | Hits: 99%/3028 

    🟩 cpu
  🟩 amd64              Pass: 100%/102 | Total: 16h 57m | Avg:  9m 58s | Max:  1h 25m | Hits:  99%/3028  
  🟩 arm64              Pass: 100%/8   | Total: 37m 14s | Avg:  4m 39s | Max:  4m 59s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 16m | Avg:  5m 05s | Max: 15m 26s | Hits:  99%/757   
  🟩 11.8               Pass: 100%/3   | Total:  2h 12m | Avg: 44m 10s | Max: 45m 02s
  🟩 12.5               Pass: 100%/4   | Total:  1h 13m | Avg: 18m 15s | Max: 39m 33s
  🟩 12.6               Pass: 100%/88  | Total: 12h 52m | Avg:  8m 46s | Max:  1h 25m | Hits:  98%/2271  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 17m 33s | Avg:  4m 23s | Max:  4m 54s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 16m | Avg:  5m 05s | Max: 15m 26s | Hits:  99%/757   
  🟩 nvcc11.8           Pass: 100%/3   | Total:  2h 12m | Avg: 44m 10s | Max: 45m 02s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  1h 13m | Avg: 18m 15s | Max: 39m 33s
  🟩 nvcc12.6           Pass: 100%/84  | Total: 12h 34m | Avg:  8m 59s | Max:  1h 25m | Hits:  98%/2271  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total: 17m 33s | Avg:  4m 23s | Max:  4m 54s
  🟩 nvcc               Pass: 100%/106 | Total: 17h 16m | Avg:  9m 46s | Max:  1h 25m | Hits:  99%/3028  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 34m 05s | Avg:  5m 40s | Max:  7m 13s
  🟩 Clang10            Pass: 100%/3   | Total: 21m 16s | Avg:  7m 05s | Max:  7m 25s
  🟩 Clang11            Pass: 100%/4   | Total: 24m 55s | Avg:  6m 13s | Max:  6m 43s
  🟩 Clang12            Pass: 100%/4   | Total: 23m 14s | Avg:  5m 48s | Max:  6m 19s
  🟩 Clang13            Pass: 100%/4   | Total: 23m 47s | Avg:  5m 56s | Max:  6m 14s
  🟩 Clang14            Pass: 100%/4   | Total: 26m 01s | Avg:  6m 30s | Max:  7m 00s
  🟩 Clang15            Pass: 100%/4   | Total: 23m 59s | Avg:  5m 59s | Max:  6m 14s
  🟩 Clang16            Pass: 100%/4   | Total: 24m 08s | Avg:  6m 02s | Max:  6m 58s
  🟩 Clang17            Pass: 100%/4   | Total: 24m 17s | Avg:  6m 04s | Max:  6m 49s
  🟩 Clang18            Pass: 100%/11  | Total:  1h 44m | Avg:  9m 31s | Max: 41m 01s
  🟩 GCC6               Pass: 100%/2   | Total:  8m 41s | Avg:  4m 20s | Max:  4m 26s
  🟩 GCC7               Pass: 100%/6   | Total: 30m 28s | Avg:  5m 04s | Max:  6m 25s
  🟩 GCC8               Pass: 100%/6   | Total: 30m 40s | Avg:  5m 06s | Max:  6m 40s
  🟩 GCC9               Pass: 100%/6   | Total: 30m 28s | Avg:  5m 04s | Max:  6m 13s
  🟩 GCC10              Pass: 100%/4   | Total: 24m 15s | Avg:  6m 03s | Max:  6m 54s
  🟩 GCC11              Pass: 100%/7   | Total:  2h 36m | Avg: 22m 25s | Max: 45m 02s
  🟩 GCC12              Pass: 100%/4   | Total: 23m 08s | Avg:  5m 47s | Max:  6m 31s
  🟩 GCC13              Pass: 100%/16  | Total:  3h 58m | Avg: 14m 54s | Max:  1h 25m
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 22m 59s | Avg:  7m 39s | Max:  8m 04s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 15m 26s | Avg: 15m 26s | Max: 15m 26s | Hits:  99%/757   
  🟩 MSVC14.29          Pass: 100%/2   | Total: 55m 59s | Avg: 27m 59s | Max: 44m 01s | Hits:  98%/1514  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 13m 13s | Avg: 13m 13s | Max: 13m 13s | Hits:  99%/757   
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  1h 13m | Avg: 18m 15s | Max: 39m 33s
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  5h 30m | Avg:  6m 53s | Max: 41m 01s
  🟩 GCC                Pass: 100%/51  | Total:  9h 03m | Avg: 10m 38s | Max:  1h 25m
  🟩 Intel              Pass: 100%/3   | Total: 22m 59s | Avg:  7m 39s | Max:  8m 04s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 24m | Avg: 21m 09s | Max: 44m 01s | Hits:  99%/3028  
  🟩 NVHPC              Pass: 100%/4   | Total:  1h 13m | Avg: 18m 15s | Max: 39m 33s
🟩 gpu
  🟩 v100               Pass: 100%/110 | Total: 17h 34m | Avg:  9m 35s | Max:  1h 25m | Hits:  99%/3028  
🟩 jobs
  🟩 Build              Pass: 100%/102 | Total: 13h 22m | Avg:  7m 52s | Max: 45m 02s | Hits:  99%/3028  
  🟩 DeviceLaunch       Pass: 100%/1   | Total:  1h 25m | Avg:  1h 25m | Max:  1h 25m
  🟩 GraphCapture       Pass: 100%/1   | Total: 18m 04s | Avg: 18m 04s | Max: 18m 04s
  🟩 HostLaunch         Pass: 100%/3   | Total: 58m 43s | Avg: 19m 34s | Max: 22m 38s
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 29m | Avg: 29m 43s | Max: 41m 01s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  2h 12m | Avg: 44m 10s | Max: 45m 02s
  🟩 90a                Pass: 100%/4   | Total: 19m 39s | Avg:  4m 54s | Max:  5m 26s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  4h 29m | Avg:  8m 59s | Max: 45m 02s
  🟩 14                 Pass: 100%/29  | Total:  3h 41m | Avg:  7m 38s | Max: 44m 15s | Hits:  99%/1514  
  🟩 17                 Pass: 100%/27  | Total:  3h 58m | Avg:  8m 50s | Max: 44m 01s | Hits:  98%/757   
  🟩 20                 Pass: 100%/24  | Total:  5h 24m | Avg: 13m 31s | Max:  1h 25m | Hits:  99%/757

  • 🟩 cudax: Pass: 100%/54 | Total: 4h 53m | Avg: 5m 26s | Max: 22m 53s | Hits: 90%/246 

    🟩 cpu
  🟩 amd64              Pass: 100%/50  | Total:  4h 43m | Avg:  5m 40s | Max: 22m 53s | Hits:  90%/246   
  🟩 arm64              Pass: 100%/4   | Total: 10m 05s | Avg:  2m 31s | Max:  2m 36s
🟩 ctk
  🟩 12.0               Pass: 100%/19  | Total:  1h 49m | Avg:  5m 46s | Max: 22m 53s | Hits:  90%/123   
  🟩 12.5               Pass: 100%/2   | Total: 13m 48s | Avg:  6m 54s | Max:  7m 00s
  🟩 12.6               Pass: 100%/33  | Total:  2h 50m | Avg:  5m 09s | Max: 19m 28s | Hits:  90%/123   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/19  | Total:  1h 49m | Avg:  5m 46s | Max: 22m 53s | Hits:  90%/123   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 13m 48s | Avg:  6m 54s | Max:  7m 00s
  🟩 nvcc12.6           Pass: 100%/33  | Total:  2h 50m | Avg:  5m 09s | Max: 19m 28s | Hits:  90%/123   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/54  | Total:  4h 53m | Avg:  5m 26s | Max: 22m 53s | Hits:  90%/246   
🟩 cxx
  🟩 Clang9             Pass: 100%/2   | Total:  7m 57s | Avg:  3m 58s | Max:  4m 39s
  🟩 Clang10            Pass: 100%/2   | Total:  7m 06s | Avg:  3m 33s | Max:  3m 55s
  🟩 Clang11            Pass: 100%/4   | Total: 14m 56s | Avg:  3m 44s | Max:  4m 17s
  🟩 Clang12            Pass: 100%/4   | Total: 15m 03s | Avg:  3m 45s | Max:  4m 22s
  🟩 Clang13            Pass: 100%/4   | Total: 14m 12s | Avg:  3m 33s | Max:  4m 21s
  🟩 Clang14            Pass: 100%/4   | Total: 33m 27s | Avg:  8m 21s | Max: 22m 53s
  🟩 Clang15            Pass: 100%/2   | Total:  7m 14s | Avg:  3m 37s | Max:  3m 46s
  🟩 Clang16            Pass: 100%/4   | Total: 13m 11s | Avg:  3m 17s | Max:  4m 11s
  🟩 Clang17            Pass: 100%/2   | Total:  8m 01s | Avg:  4m 00s | Max:  4m 12s
  🟩 Clang18            Pass: 100%/2   | Total: 21m 07s | Avg: 10m 33s | Max: 17m 42s
  🟩 GCC9               Pass: 100%/2   | Total:  6m 15s | Avg:  3m 07s | Max:  3m 08s
  🟩 GCC10              Pass: 100%/4   | Total: 15m 13s | Avg:  3m 48s | Max:  4m 19s
  🟩 GCC11              Pass: 100%/4   | Total: 14m 15s | Avg:  3m 33s | Max:  3m 47s
  🟩 GCC12              Pass: 100%/7   | Total:  1h 14m | Avg: 10m 34s | Max: 22m 35s
  🟩 GCC13              Pass: 100%/3   | Total:  8m 17s | Avg:  2m 45s | Max:  3m 22s
  🟩 MSVC14.36          Pass: 100%/1   | Total:  8m 56s | Avg:  8m 56s | Max:  8m 56s | Hits:  90%/123   
  🟩 MSVC14.39          Pass: 100%/1   | Total: 10m 51s | Avg: 10m 51s | Max: 10m 51s | Hits:  90%/123   
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 13m 48s | Avg:  6m 54s | Max:  7m 00s
🟩 cxx_family
  🟩 Clang              Pass: 100%/30  | Total:  2h 22m | Avg:  4m 44s | Max: 22m 53s
  🟩 GCC                Pass: 100%/20  | Total:  1h 58m | Avg:  5m 54s | Max: 22m 35s
  🟩 MSVC               Pass: 100%/2   | Total: 19m 47s | Avg:  9m 53s | Max: 10m 51s | Hits:  90%/246   
  🟩 NVHPC              Pass: 100%/2   | Total: 13m 48s | Avg:  6m 54s | Max:  7m 00s
🟩 gpu
  🟩 v100               Pass: 100%/54  | Total:  4h 53m | Avg:  5m 26s | Max: 22m 53s | Hits:  90%/246   
🟩 jobs
  🟩 Build              Pass: 100%/49  | Total:  3h 14m | Avg:  3m 57s | Max: 10m 51s | Hits:  90%/246   
  🟩 Test               Pass: 100%/5   | Total:  1h 39m | Avg: 19m 57s | Max: 22m 53s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  3m 55s | Avg:  3m 55s | Max:  3m 55s
  🟩 90a                Pass: 100%/1   | Total:  3m 22s | Avg:  3m 22s | Max:  3m 22s
🟩 std
  🟩 17                 Pass: 100%/29  | Total:  2h 22m | Avg:  4m 54s | Max: 22m 35s
  🟩 20                 Pass: 100%/25  | Total:  2h 31m | Avg:  6m 03s | Max: 22m 53s | Hits:  90%/246

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 9m 50s | Avg: 4m 55s | Max: 7m 25s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  9m 50s | Avg:  4m 55s | Max:  7m 25s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total:  9m 50s | Avg:  4m 55s | Max:  7m 25s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total:  9m 50s | Avg:  4m 55s | Max:  7m 25s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  9m 50s | Avg:  4m 55s | Max:  7m 25s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  9m 50s | Avg:  4m 55s | Max:  7m 25s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  9m 50s | Avg:  4m 55s | Max:  7m 25s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total:  9m 50s | Avg:  4m 55s | Max:  7m 25s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 25s | Avg:  2m 25s | Max:  2m 25s
  🟩 Test               Pass: 100%/1   | Total:  7m 25s | Avg:  7m 25s | Max:  7m 25s

  • 🟩 python: Pass: 100%/1 | Total: 21m 40s | Avg: 21m 40s | Max: 21m 40s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 21m 40s | Avg: 21m 40s | Max: 21m 40s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 21m 40s | Avg: 21m 40s | Max: 21m 40s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 21m 40s | Avg: 21m 40s | Max: 21m 40s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 21m 40s | Avg: 21m 40s | Max: 21m 40s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 21m 40s | Avg: 21m 40s | Max: 21m 40s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 21m 40s | Avg: 21m 40s | Max: 21m 40s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 21m 40s | Avg: 21m 40s | Max: 21m 40s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 21m 40s | Avg: 21m 40s | Max: 21m 40s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
+/- libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
+/- libcu++
+/- CUB
+/- Thrust
+/- CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 396)
# Runner
327 linux-amd64-cpu16
28 linux-arm64-cpu16
26 linux-amd64-gpu-v100-latest-1
15 windows-amd64-cpu16

@miscco miscco merged commit 658e0bb into NVIDIA:main Nov 26, 2024
412 checks passed
@miscco miscco deleted the avoid_libcpp_symbol_clashes branch November 26, 2024 08:00
davebayer pushed a commit to davebayer/cccl that referenced this pull request Dec 2, 2024
@miscco @davebayer
Avoid symbol clashes with libc++ (NVIDIA#2955)
88686f6 
* Drop `__libcpp` prefix in favor of `__cccl`

libc++ has moved towards just using unqualified `std::` for any partial qualification.

That leads to a high chance of symbol clashes if we use the same names as them. As a first replace all uses of `__libcpp` with `_cccl`

I was wondering about `__libcupp` but 🤷

* Backport `is_constant_evaluated`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernhardmgruber bernhardmgruber bernhardmgruber approved these changes

@griwes griwes Awaiting requested review from griwes griwes is a code owner automatically assigned from NVIDIA/cccl-libcudacxx-codeowners

@gevtushenko gevtushenko Awaiting requested review from gevtushenko gevtushenko was automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miscco @bernhardmgruber