-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build CUB and Thrust tests with assertions #2987
Build CUB and Thrust tests with assertions #2987
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
🟨 CI finished in 1h 42m: Pass: 95%/224 | Total: 6d 04h | Avg: 39m 39s | Max: 1h 08m | Hits: 70%/12288
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 224)
# | Runner |
---|---|
185 | linux-amd64-cpu16 |
16 | linux-arm64-cpu16 |
14 | linux-amd64-gpu-v100-latest-1 |
9 | windows-amd64-cpu16 |
59c47ec
to
2fb6a97
Compare
/ok to test |
/ok to test |
fcb7d9a
to
25cb70f
Compare
🟩 CI finished in 52m 20s: Pass: 100%/224 | Total: 1d 04h | Avg: 7m 35s | Max: 36m 57s | Hits: 98%/12288
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 224)
# | Runner |
---|---|
185 | linux-amd64-cpu16 |
16 | linux-arm64-cpu16 |
14 | linux-amd64-gpu-v100-latest-1 |
9 | windows-amd64-cpu16 |
@@ -109,8 +109,11 @@ multiply_extract_higher_bits(T value, R multiplier) | |||
{ | |||
static_assert(supported_integral<T>::value, "unsupported type"); | |||
static_assert(supported_integral<R>::value, "unsupported type"); | |||
_CCCL_DIAG_PUSH | |||
_CCCL_DIAG_SUPPRESS_ICC(186) // pointless comparison of unsigned integer with zero |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add an _CCCL_IF_CONSTEXPR(_CCCL_TRAIT(is_signed, T))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't entrust ICC with the competency to not issue the warning if we put a runtime if around the assert before C++17. Plus, ICC is going away soon anyway. I would like to keep the code as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its less about whether ICC is able to suppress the warning, but whether we want pay the price of the check in debug mode for unsigned integers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry. I thought your comment was related to my warning suppression. Follow-up: #2997
No description provided.