Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in thrust/binary_search.h (#2980) #2992

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Fix a typo in thrust/binary_search.h (#2980) #2992

merged 1 commit into from
Nov 30, 2024

Conversation

hzhangxyz
Copy link
Contributor

Description

closes (#2980)

There is a tyro in the comment which generates the document later, so fix it.

The pull request template instructs me to update the CHANGELOG, but it appears that this type of typo should not be included in the CHANGELOG?

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@hzhangxyz hzhangxyz requested review from a team as code owners November 30, 2024 00:59
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 30, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@miscco
Copy link
Collaborator

miscco commented Nov 30, 2024

/ok to test

miscco
miscco approved these changes Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for improving our documentation 🎉

@miscco miscco enabled auto-merge (squash) November 30, 2024 13:43
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 1h 32m: Pass: 100%/224 | Total: 1d 03h | Avg: 7m 16s | Max: 1h 22m | Hits: 99%/12288

  • 🟩 thrust: Pass: 100%/111 | Total: 12h 24m | Avg: 6m 42s | Max: 31m 05s | Hits: 99%/9260 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 18m 05s | Avg:  9m 02s | Max: 12m 29s
🟩 cpu
  🟩 amd64              Pass: 100%/103 | Total: 11h 46m | Avg:  6m 51s | Max: 31m 05s | Hits:  99%/9260  
  🟩 arm64              Pass: 100%/8   | Total: 38m 19s | Avg:  4m 47s | Max:  5m 11s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 15m | Avg:  5m 02s | Max: 17m 18s | Hits:  99%/1852  
  🟩 11.8               Pass: 100%/3   | Total: 15m 58s | Avg:  5m 19s | Max:  5m 44s
  🟩 12.5               Pass: 100%/4   | Total:  1h 00m | Avg: 15m 07s | Max: 16m 11s
  🟩 12.6               Pass: 100%/89  | Total:  9h 52m | Avg:  6m 39s | Max: 31m 05s | Hits:  99%/7408  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 19m 27s | Avg:  4m 51s | Max:  5m 16s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 15m | Avg:  5m 02s | Max: 17m 18s | Hits:  99%/1852  
  🟩 nvcc11.8           Pass: 100%/3   | Total: 15m 58s | Avg:  5m 19s | Max:  5m 44s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  1h 00m | Avg: 15m 07s | Max: 16m 11s
  🟩 nvcc12.6           Pass: 100%/85  | Total:  9h 33m | Avg:  6m 44s | Max: 31m 05s | Hits:  99%/7408  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total: 19m 27s | Avg:  4m 51s | Max:  5m 16s
  🟩 nvcc               Pass: 100%/107 | Total: 12h 05m | Avg:  6m 46s | Max: 31m 05s | Hits:  99%/9260  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 30m 30s | Avg:  5m 05s | Max:  6m 18s
  🟩 Clang10            Pass: 100%/3   | Total: 18m 54s | Avg:  6m 18s | Max:  6m 44s
  🟩 Clang11            Pass: 100%/4   | Total: 20m 52s | Avg:  5m 13s | Max:  5m 39s
  🟩 Clang12            Pass: 100%/4   | Total: 20m 57s | Avg:  5m 14s | Max:  5m 24s
  🟩 Clang13            Pass: 100%/4   | Total: 20m 38s | Avg:  5m 09s | Max:  5m 25s
  🟩 Clang14            Pass: 100%/4   | Total: 20m 25s | Avg:  5m 06s | Max:  5m 26s
  🟩 Clang15            Pass: 100%/4   | Total: 20m 56s | Avg:  5m 14s | Max:  5m 50s
  🟩 Clang16            Pass: 100%/4   | Total: 20m 52s | Avg:  5m 13s | Max:  5m 40s
  🟩 Clang17            Pass: 100%/4   | Total: 21m 28s | Avg:  5m 22s | Max:  5m 45s
  🟩 Clang18            Pass: 100%/11  | Total:  1h 04m | Avg:  5m 53s | Max: 13m 51s
  🟩 GCC6               Pass: 100%/2   | Total:  7m 49s | Avg:  3m 54s | Max:  4m 06s
  🟩 GCC7               Pass: 100%/6   | Total: 27m 25s | Avg:  4m 34s | Max:  5m 29s
  🟩 GCC8               Pass: 100%/6   | Total: 28m 31s | Avg:  4m 45s | Max:  5m 19s
  🟩 GCC9               Pass: 100%/6   | Total: 27m 49s | Avg:  4m 38s | Max:  5m 46s
  🟩 GCC10              Pass: 100%/4   | Total: 20m 59s | Avg:  5m 14s | Max:  5m 36s
  🟩 GCC11              Pass: 100%/7   | Total: 36m 34s | Avg:  5m 13s | Max:  5m 44s
  🟩 GCC12              Pass: 100%/4   | Total: 22m 08s | Avg:  5m 32s | Max:  6m 02s
  🟩 GCC13              Pass: 100%/16  | Total:  2h 22m | Avg:  8m 53s | Max: 31m 05s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 19m 34s | Avg:  6m 31s | Max:  6m 55s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 17m 18s | Avg: 17m 18s | Max: 17m 18s | Hits:  99%/1852  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 32m 04s | Avg: 16m 02s | Max: 17m 11s | Hits:  99%/3704  
  🟩 MSVC14.39          Pass: 100%/2   | Total: 41m 26s | Avg: 20m 43s | Max: 23m 02s | Hits:  99%/3704  
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  1h 00m | Avg: 15m 07s | Max: 16m 11s
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  4h 20m | Avg:  5m 25s | Max: 13m 51s
  🟩 GCC                Pass: 100%/51  | Total:  5h 13m | Avg:  6m 08s | Max: 31m 05s
  🟩 Intel              Pass: 100%/3   | Total: 19m 34s | Avg:  6m 31s | Max:  6m 55s
  🟩 MSVC               Pass: 100%/5   | Total:  1h 30m | Avg: 18m 09s | Max: 23m 02s | Hits:  99%/9260  
  🟩 NVHPC              Pass: 100%/4   | Total:  1h 00m | Avg: 15m 07s | Max: 16m 11s
🟩 gpu
  🟩 v100               Pass: 100%/111 | Total: 12h 24m | Avg:  6m 42s | Max: 31m 05s | Hits:  99%/9260  
🟩 jobs
  🟩 Build              Pass: 100%/103 | Total: 10h 12m | Avg:  5m 56s | Max: 18m 24s | Hits:  99%/7408  
  🟩 TestCPU            Pass: 100%/4   | Total: 45m 54s | Avg: 11m 28s | Max: 23m 02s | Hits:  99%/1852  
  🟩 TestGPU            Pass: 100%/4   | Total:  1h 26m | Avg: 21m 40s | Max: 31m 05s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 15m 58s | Avg:  5m 19s | Max:  5m 44s
  🟩 90a                Pass: 100%/4   | Total: 17m 24s | Avg:  4m 21s | Max:  4m 52s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  2h 58m | Avg:  5m 57s | Max: 29m 17s
  🟩 14                 Pass: 100%/29  | Total:  2h 59m | Avg:  6m 10s | Max: 17m 18s | Hits:  99%/3704  
  🟩 17                 Pass: 100%/27  | Total:  2h 45m | Avg:  6m 08s | Max: 17m 11s | Hits:  99%/1852  
  🟩 20                 Pass: 100%/23  | Total:  3h 23m | Avg:  8m 50s | Max: 31m 05s | Hits:  99%/3704

  • 🟩 cub: Pass: 100%/110 | Total: 14h 13m | Avg: 7m 45s | Max: 1h 22m | Hits: 99%/3028 

    🟩 cpu
  🟩 amd64              Pass: 100%/102 | Total: 13h 36m | Avg:  8m 00s | Max:  1h 22m | Hits:  99%/3028  
  🟩 arm64              Pass: 100%/8   | Total: 37m 10s | Avg:  4m 38s | Max:  5m 00s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 15m | Avg:  5m 02s | Max: 14m 16s | Hits:  99%/757   
  🟩 11.8               Pass: 100%/3   | Total: 16m 54s | Avg:  5m 38s | Max:  6m 01s
  🟩 12.5               Pass: 100%/4   | Total: 36m 53s | Avg:  9m 13s | Max:  9m 21s
  🟩 12.6               Pass: 100%/88  | Total: 12h 04m | Avg:  8m 13s | Max:  1h 22m | Hits:  99%/2271  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 16m 44s | Avg:  4m 11s | Max:  4m 20s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 15m | Avg:  5m 02s | Max: 14m 16s | Hits:  99%/757   
  🟩 nvcc11.8           Pass: 100%/3   | Total: 16m 54s | Avg:  5m 38s | Max:  6m 01s
  🟩 nvcc12.5           Pass: 100%/4   | Total: 36m 53s | Avg:  9m 13s | Max:  9m 21s
  🟩 nvcc12.6           Pass: 100%/84  | Total: 11h 47m | Avg:  8m 25s | Max:  1h 22m | Hits:  99%/2271  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total: 16m 44s | Avg:  4m 11s | Max:  4m 20s
  🟩 nvcc               Pass: 100%/106 | Total: 13h 56m | Avg:  7m 53s | Max:  1h 22m | Hits:  99%/3028  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 32m 05s | Avg:  5m 20s | Max:  6m 26s
  🟩 Clang10            Pass: 100%/3   | Total: 18m 59s | Avg:  6m 19s | Max:  6m 40s
  🟩 Clang11            Pass: 100%/4   | Total: 21m 16s | Avg:  5m 19s | Max:  5m 27s
  🟩 Clang12            Pass: 100%/4   | Total: 20m 29s | Avg:  5m 07s | Max:  5m 28s
  🟩 Clang13            Pass: 100%/4   | Total: 21m 08s | Avg:  5m 17s | Max:  5m 29s
  🟩 Clang14            Pass: 100%/4   | Total: 21m 28s | Avg:  5m 22s | Max:  5m 30s
  🟩 Clang15            Pass: 100%/4   | Total: 21m 40s | Avg:  5m 25s | Max:  5m 40s
  🟩 Clang16            Pass: 100%/4   | Total: 21m 29s | Avg:  5m 22s | Max:  5m 34s
  🟩 Clang17            Pass: 100%/4   | Total: 21m 28s | Avg:  5m 22s | Max:  5m 39s
  🟩 Clang18            Pass: 100%/11  | Total:  1h 19m | Avg:  7m 11s | Max: 21m 36s
  🟩 GCC6               Pass: 100%/2   | Total:  8m 52s | Avg:  4m 26s | Max:  4m 33s
  🟩 GCC7               Pass: 100%/6   | Total:  1h 16m | Avg: 12m 41s | Max: 52m 19s
  🟩 GCC8               Pass: 100%/6   | Total: 28m 52s | Avg:  4m 48s | Max:  5m 17s
  🟩 GCC9               Pass: 100%/6   | Total: 28m 53s | Avg:  4m 48s | Max:  5m 38s
  🟩 GCC10              Pass: 100%/4   | Total: 21m 20s | Avg:  5m 20s | Max:  5m 33s
  🟩 GCC11              Pass: 100%/7   | Total: 38m 18s | Avg:  5m 28s | Max:  6m 01s
  🟩 GCC12              Pass: 100%/4   | Total: 21m 52s | Avg:  5m 28s | Max:  5m 37s
  🟩 GCC13              Pass: 100%/16  | Total:  4h 01m | Avg: 15m 06s | Max:  1h 22m
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 19m 31s | Avg:  6m 30s | Max:  6m 48s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 16s | Avg: 14m 16s | Max: 14m 16s | Hits:  99%/757   
  🟩 MSVC14.29          Pass: 100%/2   | Total: 24m 15s | Avg: 12m 07s | Max: 12m 20s | Hits:  99%/1514  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 13m 39s | Avg: 13m 39s | Max: 13m 39s | Hits:  99%/757   
  🟩 NVHPC24.7          Pass: 100%/4   | Total: 36m 53s | Avg:  9m 13s | Max:  9m 21s
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  4h 39m | Avg:  5m 48s | Max: 21m 36s
  🟩 GCC                Pass: 100%/51  | Total:  7h 46m | Avg:  9m 08s | Max:  1h 22m
  🟩 Intel              Pass: 100%/3   | Total: 19m 31s | Avg:  6m 30s | Max:  6m 48s
  🟩 MSVC               Pass: 100%/4   | Total: 52m 10s | Avg: 13m 02s | Max: 14m 16s | Hits:  99%/3028  
  🟩 NVHPC              Pass: 100%/4   | Total: 36m 53s | Avg:  9m 13s | Max:  9m 21s
🟩 gpu
  🟩 v100               Pass: 100%/110 | Total: 14h 13m | Avg:  7m 45s | Max:  1h 22m | Hits:  99%/3028  
🟩 jobs
  🟩 Build              Pass: 100%/102 | Total: 10h 21m | Avg:  6m 05s | Max: 52m 19s | Hits:  99%/3028  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 19m 52s | Avg: 19m 52s | Max: 19m 52s
  🟩 GraphCapture       Pass: 100%/1   | Total: 32m 12s | Avg: 32m 12s | Max: 32m 12s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 55m | Avg: 38m 23s | Max:  1h 22m
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 05m | Avg: 21m 45s | Max: 21m 52s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 16m 54s | Avg:  5m 38s | Max:  6m 01s
  🟩 90a                Pass: 100%/4   | Total: 17m 12s | Avg:  4m 18s | Max:  4m 23s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  3h 01m | Avg:  6m 02s | Max: 21m 47s
  🟩 14                 Pass: 100%/29  | Total:  2h 49m | Avg:  5m 50s | Max: 14m 16s | Hits:  99%/1514  
  🟩 17                 Pass: 100%/27  | Total:  3h 21m | Avg:  7m 27s | Max: 52m 19s | Hits:  99%/757   
  🟩 20                 Pass: 100%/24  | Total:  5h 01m | Avg: 12m 34s | Max:  1h 22m | Hits:  99%/757

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 10m 12s | Avg: 5m 06s | Max: 8m 12s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 10m 12s | Avg:  5m 06s | Max:  8m 12s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total: 10m 12s | Avg:  5m 06s | Max:  8m 12s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total: 10m 12s | Avg:  5m 06s | Max:  8m 12s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 10m 12s | Avg:  5m 06s | Max:  8m 12s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 10m 12s | Avg:  5m 06s | Max:  8m 12s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 10m 12s | Avg:  5m 06s | Max:  8m 12s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total: 10m 12s | Avg:  5m 06s | Max:  8m 12s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 00s | Avg:  2m 00s | Max:  2m 00s
  🟩 Test               Pass: 100%/1   | Total:  8m 12s | Avg:  8m 12s | Max:  8m 12s

  • 🟩 python: Pass: 100%/1 | Total: 19m 19s | Avg: 19m 19s | Max: 19m 19s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 19m 19s | Avg: 19m 19s | Max: 19m 19s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 19m 19s | Avg: 19m 19s | Max: 19m 19s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 19m 19s | Avg: 19m 19s | Max: 19m 19s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 19m 19s | Avg: 19m 19s | Max: 19m 19s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 19m 19s | Avg: 19m 19s | Max: 19m 19s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 19m 19s | Avg: 19m 19s | Max: 19m 19s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 19m 19s | Avg: 19m 19s | Max: 19m 19s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 19m 19s | Avg: 19m 19s | Max: 19m 19s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
+/- Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 224)
# Runner
185 linux-amd64-cpu16
16 linux-arm64-cpu16
14 linux-amd64-gpu-v100-latest-1
9 windows-amd64-cpu16

@miscco miscco merged commit 5bb9471 into NVIDIA:main Nov 30, 2024
240 checks passed
davebayer pushed a commit to davebayer/cccl that referenced this pull request Dec 2, 2024
@hzhangxyz @davebayer
Fix a typo in thrust/binary_search.h (NVIDIA#2980) (NVIDIA#2992)
b9f61d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@gevtushenko gevtushenko Awaiting requested review from gevtushenko gevtushenko is a code owner automatically assigned from NVIDIA/cccl-thrust-codeowners

@fbusato fbusato Awaiting requested review from fbusato fbusato was automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hzhangxyz @miscco