Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertions in the mdspan accessors that we are not out of bounds #3055

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Add assertions in the mdspan accessors that we are not out of bounds #3055

merged 2 commits into from
Dec 5, 2024

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Dec 4, 2024

While we are at it drop some of the custom macros and use the proper CCCL ones.

Also slap nodiscard on all the APIs

Fixes #3045

@miscco miscco requested review from a team as code owners December 4, 2024 18:11
miscco added 2 commits December 5, 2024 08:57
@miscco
Add assertions in the mdspan accessors that we are not out of bounds
6ecdd30 
While we are at it drop some of the custom macros and use the proper CCCL ones.

Also slap nodiscard on all the APIs
@miscco
Try to avoid pointless comparison warnings
6eb0f2b
@miscco miscco enabled auto-merge (squash) December 5, 2024 09:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

🟩 CI finished in 2h 51m: Pass: 100%/396 | Total: 6d 12h | Avg: 23m 39s | Max: 1h 24m | Hits: 85%/22125

  • 🟩 libcudacxx: Pass: 100%/118 | Total: 22h 41m | Avg: 11m 32s | Max: 37m 09s | Hits: 83%/9581 

    🟩 cpu
  🟩 amd64              Pass: 100%/110 | Total: 21h 00m | Avg: 11m 27s | Max: 37m 09s | Hits:  83%/9581  
  🟩 arm64              Pass: 100%/8   | Total:  1h 41m | Avg: 12m 38s | Max: 20m 02s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  2h 38m | Avg: 10m 35s | Max: 29m 37s | Hits:  37%/2211  
  🟩 11.8               Pass: 100%/3   | Total: 47m 08s | Avg: 15m 42s | Max: 16m 46s
  🟩 12.5               Pass: 100%/4   | Total:  1h 16m | Avg: 19m 00s | Max: 33m 15s
  🟩 12.6               Pass: 100%/96  | Total: 17h 59m | Avg: 11m 14s | Max: 37m 09s | Hits:  97%/7370  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/12  | Total:  2h 31m | Avg: 12m 35s | Max: 20m 40s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  2h 38m | Avg: 10m 35s | Max: 29m 37s | Hits:  37%/2211  
  🟩 nvcc11.8           Pass: 100%/3   | Total: 47m 08s | Avg: 15m 42s | Max: 16m 46s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  1h 16m | Avg: 19m 00s | Max: 33m 15s
  🟩 nvcc12.6           Pass: 100%/84  | Total: 15h 28m | Avg: 11m 03s | Max: 37m 09s | Hits:  97%/7370  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/12  | Total:  2h 31m | Avg: 12m 35s | Max: 20m 40s
  🟩 nvcc               Pass: 100%/106 | Total: 20h 10m | Avg: 11m 25s | Max: 37m 09s | Hits:  83%/9581  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 45m 40s | Avg:  7m 36s | Max: 17m 12s
  🟩 Clang10            Pass: 100%/3   | Total: 32m 54s | Avg: 10m 58s | Max: 23m 13s
  🟩 Clang11            Pass: 100%/4   | Total: 46m 55s | Avg: 11m 43s | Max: 17m 06s
  🟩 Clang12            Pass: 100%/4   | Total: 27m 36s | Avg:  6m 54s | Max: 14m 15s
  🟩 Clang13            Pass: 100%/4   | Total: 29m 53s | Avg:  7m 28s | Max: 15m 56s
  🟩 Clang14            Pass: 100%/4   | Total: 51m 15s | Avg: 12m 48s | Max: 20m 41s
  🟩 Clang15            Pass: 100%/4   | Total:  1h 08m | Avg: 17m 06s | Max: 21m 35s
  🟩 Clang16            Pass: 100%/4   | Total:  1h 01m | Avg: 15m 23s | Max: 23m 33s
  🟩 Clang17            Pass: 100%/4   | Total: 53m 00s | Avg: 13m 15s | Max: 19m 52s
  🟩 Clang18            Pass: 100%/18  | Total:  4h 07m | Avg: 13m 45s | Max: 37m 09s
  🟩 GCC6               Pass: 100%/2   | Total: 23m 57s | Avg: 11m 58s | Max: 20m 58s
  🟩 GCC7               Pass: 100%/6   | Total: 57m 30s | Avg:  9m 35s | Max: 19m 58s
  🟩 GCC8               Pass: 100%/6   | Total: 35m 41s | Avg:  5m 56s | Max: 17m 37s
  🟩 GCC9               Pass: 100%/6   | Total: 46m 06s | Avg:  7m 41s | Max: 15m 54s
  🟩 GCC10              Pass: 100%/4   | Total: 33m 09s | Avg:  8m 17s | Max: 13m 58s
  🟩 GCC11              Pass: 100%/7   | Total:  1h 20m | Avg: 11m 31s | Max: 16m 46s
  🟩 GCC12              Pass: 100%/4   | Total: 42m 16s | Avg: 10m 34s | Max: 22m 17s
  🟩 GCC13              Pass: 100%/17  | Total:  3h 27m | Avg: 12m 12s | Max: 36m 18s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 17m 04s | Avg:  5m 41s | Max:  6m 03s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 29m 37s | Avg: 29m 37s | Max: 29m 37s | Hits:  37%/2211  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 30m 42s | Avg: 15m 21s | Max: 17m 20s | Hits:  98%/4763  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 16m 17s | Avg: 16m 17s | Max: 16m 17s | Hits:  95%/2607  
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  1h 16m | Avg: 19m 00s | Max: 33m 15s
🟩 cxx_family
  🟩 Clang              Pass: 100%/55  | Total: 11h 04m | Avg: 12m 05s | Max: 37m 09s
  🟩 GCC                Pass: 100%/52  | Total:  8h 46m | Avg: 10m 07s | Max: 36m 18s
  🟩 Intel              Pass: 100%/3   | Total: 17m 04s | Avg:  5m 41s | Max:  6m 03s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 16m | Avg: 19m 09s | Max: 29m 37s | Hits:  83%/9581  
  🟩 NVHPC              Pass: 100%/4   | Total:  1h 16m | Avg: 19m 00s | Max: 33m 15s
🟩 gpu
  🟩 v100               Pass: 100%/118 | Total: 22h 41m | Avg: 11m 32s | Max: 37m 09s | Hits:  83%/9581  
🟩 jobs
  🟩 Build              Pass: 100%/110 | Total: 19h 45m | Avg: 10m 46s | Max: 33m 15s | Hits:  83%/9581  
  🟩 NVRTC              Pass: 100%/4   | Total:  1h 27m | Avg: 21m 59s | Max: 26m 05s
  🟩 Test               Pass: 100%/3   | Total:  1h 26m | Avg: 28m 43s | Max: 37m 09s
  🟩 VerifyCodegen      Pass: 100%/1   | Total:  1m 56s | Avg:  1m 56s | Max:  1m 56s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 47m 08s | Avg: 15m 42s | Max: 16m 46s
  🟩 90                 Pass: 100%/4   | Total: 42m 23s | Avg: 10m 35s | Max: 12m 28s
  🟩 90a                Pass: 100%/8   | Total: 55m 07s | Avg:  6m 53s | Max: 11m 40s
🟩 std
  🟩 11                 Pass: 100%/32  | Total:  4h 49m | Avg:  9m 02s | Max: 20m 58s
  🟩 14                 Pass: 100%/32  | Total:  5h 57m | Avg: 11m 10s | Max: 29m 37s | Hits:  69%/4514  
  🟩 17                 Pass: 100%/30  | Total:  5h 29m | Avg: 10m 58s | Max: 26m 52s | Hits:  98%/2460  
  🟩 20                 Pass: 100%/23  | Total:  6h 22m | Avg: 16m 38s | Max: 37m 09s | Hits:  95%/2607

  • 🟩 thrust: Pass: 100%/111 | Total: 1d 22h | Avg: 24m 58s | Max: 1h 05m | Hits: 90%/9260 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 41m 51s | Avg: 20m 55s | Max: 28m 26s
🟩 cpu
  🟩 amd64              Pass: 100%/103 | Total:  1d 18h | Avg: 25m 00s | Max:  1h 05m | Hits:  90%/9260  
  🟩 arm64              Pass: 100%/8   | Total:  3h 16m | Avg: 24m 30s | Max: 35m 28s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  5h 13m | Avg: 20m 55s | Max: 33m 52s | Hits:  99%/1852  
  🟩 11.8               Pass: 100%/3   | Total:  1h 25m | Avg: 28m 39s | Max: 40m 49s
  🟩 12.5               Pass: 100%/4   | Total:  2h 46m | Avg: 41m 33s | Max: 54m 03s
  🟩 12.6               Pass: 100%/89  | Total:  1d 12h | Avg: 24m 47s | Max:  1h 05m | Hits:  88%/7408  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total:  1h 31m | Avg: 22m 47s | Max: 29m 18s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  5h 13m | Avg: 20m 55s | Max: 33m 52s | Hits:  99%/1852  
  🟩 nvcc11.8           Pass: 100%/3   | Total:  1h 25m | Avg: 28m 39s | Max: 40m 49s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  2h 46m | Avg: 41m 33s | Max: 54m 03s
  🟩 nvcc12.6           Pass: 100%/85  | Total:  1d 11h | Avg: 24m 52s | Max:  1h 05m | Hits:  88%/7408  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total:  1h 31m | Avg: 22m 47s | Max: 29m 18s
  🟩 nvcc               Pass: 100%/107 | Total:  1d 20h | Avg: 25m 03s | Max:  1h 05m | Hits:  90%/9260  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  2h 19m | Avg: 23m 11s | Max: 33m 43s
  🟩 Clang10            Pass: 100%/3   | Total:  1h 10m | Avg: 23m 38s | Max: 33m 30s
  🟩 Clang11            Pass: 100%/4   | Total:  1h 44m | Avg: 26m 01s | Max: 35m 10s
  🟩 Clang12            Pass: 100%/4   | Total:  1h 51m | Avg: 27m 52s | Max: 36m 35s
  🟩 Clang13            Pass: 100%/4   | Total:  1h 41m | Avg: 25m 25s | Max: 35m 15s
  🟩 Clang14            Pass: 100%/4   | Total:  1h 44m | Avg: 26m 08s | Max: 36m 01s
  🟩 Clang15            Pass: 100%/4   | Total:  1h 41m | Avg: 25m 28s | Max: 33m 56s
  🟩 Clang16            Pass: 100%/4   | Total:  1h 41m | Avg: 25m 26s | Max: 33m 43s
  🟩 Clang17            Pass: 100%/4   | Total:  1h 42m | Avg: 25m 32s | Max: 33m 46s
  🟩 Clang18            Pass: 100%/11  | Total:  4h 01m | Avg: 21m 58s | Max: 33m 24s
  🟩 GCC6               Pass: 100%/2   | Total: 31m 07s | Avg: 15m 33s | Max: 27m 03s
  🟩 GCC7               Pass: 100%/6   | Total:  2h 09m | Avg: 21m 32s | Max: 32m 10s
  🟩 GCC8               Pass: 100%/6   | Total:  2h 17m | Avg: 22m 52s | Max: 33m 52s
  🟩 GCC9               Pass: 100%/6   | Total:  2h 22m | Avg: 23m 42s | Max: 37m 00s
  🟩 GCC10              Pass: 100%/4   | Total:  1h 43m | Avg: 25m 58s | Max: 34m 04s
  🟩 GCC11              Pass: 100%/7   | Total:  3h 15m | Avg: 27m 55s | Max: 40m 49s
  🟩 GCC12              Pass: 100%/4   | Total:  2h 01m | Avg: 30m 18s | Max: 39m 47s
  🟩 GCC13              Pass: 100%/16  | Total:  5h 43m | Avg: 21m 26s | Max: 44m 47s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  1h 28m | Avg: 29m 25s | Max: 42m 30s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 17m 19s | Avg: 17m 19s | Max: 17m 19s | Hits:  99%/1852  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 30m 30s | Avg: 15m 15s | Max: 15m 24s | Hits:  99%/3704  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 26m | Avg: 43m 28s | Max:  1h 05m | Hits:  78%/3704  
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  2h 46m | Avg: 41m 33s | Max: 54m 03s
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total: 19h 39m | Avg: 24m 34s | Max: 36m 35s
  🟩 GCC                Pass: 100%/51  | Total: 20h 03m | Avg: 23m 35s | Max: 44m 47s
  🟩 Intel              Pass: 100%/3   | Total:  1h 28m | Avg: 29m 25s | Max: 42m 30s
  🟩 MSVC               Pass: 100%/5   | Total:  2h 14m | Avg: 26m 57s | Max:  1h 05m | Hits:  90%/9260  
  🟩 NVHPC              Pass: 100%/4   | Total:  2h 46m | Avg: 41m 33s | Max: 54m 03s
🟩 gpu
  🟩 v100               Pass: 100%/111 | Total:  1d 22h | Avg: 24m 58s | Max:  1h 05m | Hits:  90%/9260  
🟩 jobs
  🟩 Build              Pass: 100%/103 | Total:  1d 19h | Avg: 25m 30s | Max:  1h 05m | Hits:  88%/7408  
  🟩 TestCPU            Pass: 100%/4   | Total: 43m 19s | Avg: 10m 49s | Max: 21m 37s | Hits:  99%/1852  
  🟩 TestGPU            Pass: 100%/4   | Total:  1h 42m | Avg: 25m 32s | Max: 44m 47s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  1h 25m | Avg: 28m 39s | Max: 40m 49s
  🟩 90a                Pass: 100%/4   | Total:  1h 09m | Avg: 17m 19s | Max: 21m 40s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  3h 09m | Avg:  6m 19s | Max: 44m 47s
  🟩 14                 Pass: 100%/29  | Total: 15h 00m | Avg: 31m 02s | Max: 47m 58s | Hits:  99%/3704  
  🟩 17                 Pass: 100%/27  | Total: 15h 09m | Avg: 33m 40s | Max: 54m 03s | Hits:  99%/1852  
  🟩 20                 Pass: 100%/23  | Total: 12h 11m | Avg: 31m 47s | Max:  1h 05m | Hits:  78%/3704

  • 🟩 cub: Pass: 100%/110 | Total: 3d 02h | Avg: 40m 47s | Max: 1h 24m | Hits: 75%/3028 

    🟩 cpu
  🟩 amd64              Pass: 100%/102 | Total:  2d 20h | Avg: 40m 24s | Max:  1h 24m | Hits:  75%/3028  
  🟩 arm64              Pass: 100%/8   | Total:  6h 04m | Avg: 45m 36s | Max: 59m 22s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  7h 58m | Avg: 31m 55s | Max: 54m 26s | Hits:  99%/757   
  🟩 11.8               Pass: 100%/3   | Total:  2h 37m | Avg: 52m 25s | Max:  1h 18m
  🟩 12.5               Pass: 100%/4   | Total:  3h 28m | Avg: 52m 02s | Max:  1h 09m
  🟩 12.6               Pass: 100%/88  | Total:  2d 12h | Avg: 41m 23s | Max:  1h 24m | Hits:  67%/2271  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total:  3h 04m | Avg: 46m 07s | Max:  1h 01m
  🟩 nvcc11.1           Pass: 100%/15  | Total:  7h 58m | Avg: 31m 55s | Max: 54m 26s | Hits:  99%/757   
  🟩 nvcc11.8           Pass: 100%/3   | Total:  2h 37m | Avg: 52m 25s | Max:  1h 18m
  🟩 nvcc12.5           Pass: 100%/4   | Total:  3h 28m | Avg: 52m 02s | Max:  1h 09m
  🟩 nvcc12.6           Pass: 100%/84  | Total:  2d 09h | Avg: 41m 09s | Max:  1h 24m | Hits:  67%/2271  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total:  3h 04m | Avg: 46m 07s | Max:  1h 01m
  🟩 nvcc               Pass: 100%/106 | Total:  2d 23h | Avg: 40m 35s | Max:  1h 24m | Hits:  75%/3028  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  3h 58m | Avg: 39m 42s | Max:  1h 00m
  🟩 Clang10            Pass: 100%/3   | Total:  1h 58m | Avg: 39m 22s | Max: 55m 09s
  🟩 Clang11            Pass: 100%/4   | Total:  2h 55m | Avg: 43m 59s | Max: 57m 31s
  🟩 Clang12            Pass: 100%/4   | Total:  2h 54m | Avg: 43m 33s | Max: 57m 16s
  🟩 Clang13            Pass: 100%/4   | Total:  2h 52m | Avg: 43m 11s | Max: 55m 20s
  🟩 Clang14            Pass: 100%/4   | Total:  2h 55m | Avg: 43m 58s | Max: 57m 53s
  🟩 Clang15            Pass: 100%/4   | Total:  2h 51m | Avg: 42m 58s | Max: 54m 55s
  🟩 Clang16            Pass: 100%/4   | Total:  2h 59m | Avg: 44m 54s | Max:  1h 02m
  🟩 Clang17            Pass: 100%/4   | Total:  3h 09m | Avg: 47m 17s | Max:  1h 00m
  🟩 Clang18            Pass: 100%/11  | Total:  7h 45m | Avg: 42m 20s | Max:  1h 01m
  🟩 GCC6               Pass: 100%/2   | Total: 52m 37s | Avg: 26m 18s | Max: 48m 37s
  🟩 GCC7               Pass: 100%/6   | Total:  3h 31m | Avg: 35m 15s | Max: 53m 21s
  🟩 GCC8               Pass: 100%/6   | Total:  3h 49m | Avg: 38m 10s | Max:  1h 01m
  🟩 GCC9               Pass: 100%/6   | Total:  3h 39m | Avg: 36m 30s | Max: 57m 00s
  🟩 GCC10              Pass: 100%/4   | Total:  3h 03m | Avg: 45m 54s | Max: 59m 30s
  🟩 GCC11              Pass: 100%/7   | Total:  5h 30m | Avg: 47m 16s | Max:  1h 18m
  🟩 GCC12              Pass: 100%/4   | Total:  3h 01m | Avg: 45m 24s | Max:  1h 01m
  🟩 GCC13              Pass: 100%/16  | Total:  9h 38m | Avg: 36m 09s | Max:  1h 24m
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  2h 02m | Avg: 40m 42s | Max: 58m 13s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 16m 15s | Avg: 16m 15s | Max: 16m 15s | Hits:  99%/757   
  🟩 MSVC14.29          Pass: 100%/2   | Total: 26m 22s | Avg: 13m 11s | Max: 13m 19s | Hits:  99%/1514  
  🟩 MSVC14.39          Pass: 100%/1   | Total:  1h 04m | Avg:  1h 04m | Max:  1h 04m | Hits:   3%/757   
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  3h 28m | Avg: 52m 02s | Max:  1h 09m
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  1d 10h | Avg: 42m 57s | Max:  1h 02m
  🟩 GCC                Pass: 100%/51  | Total:  1d 09h | Avg: 38m 57s | Max:  1h 24m
  🟩 Intel              Pass: 100%/3   | Total:  2h 02m | Avg: 40m 42s | Max: 58m 13s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 47m | Avg: 26m 51s | Max:  1h 04m | Hits:  75%/3028  
  🟩 NVHPC              Pass: 100%/4   | Total:  3h 28m | Avg: 52m 02s | Max:  1h 09m
🟩 gpu
  🟩 v100               Pass: 100%/110 | Total:  3d 02h | Avg: 40m 47s | Max:  1h 24m | Hits:  75%/3028  
🟩 jobs
  🟩 Build              Pass: 100%/102 | Total:  2d 22h | Avg: 41m 13s | Max:  1h 18m | Hits:  75%/3028  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 24m 46s | Avg: 24m 46s | Max: 24m 46s
  🟩 GraphCapture       Pass: 100%/1   | Total: 29m 17s | Avg: 29m 17s | Max: 29m 17s
  🟩 HostLaunch         Pass: 100%/3   | Total:  2h 17m | Avg: 45m 49s | Max:  1h 24m
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 30m | Avg: 30m 05s | Max: 38m 45s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  2h 37m | Avg: 52m 25s | Max:  1h 18m
  🟩 90a                Pass: 100%/4   | Total:  1h 25m | Avg: 21m 16s | Max: 26m 55s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  5h 43m | Avg: 11m 27s | Max:  1h 24m
  🟩 14                 Pass: 100%/29  | Total:  1d 00h | Avg: 51m 33s | Max:  1h 08m | Hits:  99%/1514  
  🟩 17                 Pass: 100%/27  | Total:  1d 00h | Avg: 54m 01s | Max:  1h 18m | Hits:  99%/757   
  🟩 20                 Pass: 100%/24  | Total: 19h 49m | Avg: 49m 33s | Max:  1h 09m | Hits:   3%/757

  • 🟩 cudax: Pass: 100%/54 | Total: 11h 53m | Avg: 13m 13s | Max: 21m 25s | Hits: 57%/256 

    🟩 cpu
  🟩 amd64              Pass: 100%/50  | Total: 11h 02m | Avg: 13m 15s | Max: 21m 25s | Hits:  57%/256   
  🟩 arm64              Pass: 100%/4   | Total: 50m 47s | Avg: 12m 41s | Max: 14m 30s
🟩 ctk
  🟩 12.0               Pass: 100%/19  | Total:  4h 00m | Avg: 12m 40s | Max: 18m 30s | Hits:  57%/128   
  🟩 12.5               Pass: 100%/2   | Total: 15m 08s | Avg:  7m 34s | Max:  7m 42s
  🟩 12.6               Pass: 100%/33  | Total:  7h 37m | Avg: 13m 52s | Max: 21m 25s | Hits:  57%/128   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/19  | Total:  4h 00m | Avg: 12m 40s | Max: 18m 30s | Hits:  57%/128   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 15m 08s | Avg:  7m 34s | Max:  7m 42s
  🟩 nvcc12.6           Pass: 100%/33  | Total:  7h 37m | Avg: 13m 52s | Max: 21m 25s | Hits:  57%/128   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/54  | Total: 11h 53m | Avg: 13m 13s | Max: 21m 25s | Hits:  57%/256   
🟩 cxx
  🟩 Clang9             Pass: 100%/2   | Total: 25m 35s | Avg: 12m 47s | Max: 13m 20s
  🟩 Clang10            Pass: 100%/2   | Total: 24m 55s | Avg: 12m 27s | Max: 13m 10s
  🟩 Clang11            Pass: 100%/4   | Total: 48m 52s | Avg: 12m 13s | Max: 12m 49s
  🟩 Clang12            Pass: 100%/4   | Total: 50m 42s | Avg: 12m 40s | Max: 14m 19s
  🟩 Clang13            Pass: 100%/4   | Total: 52m 29s | Avg: 13m 07s | Max: 13m 52s
  🟩 Clang14            Pass: 100%/4   | Total: 56m 42s | Avg: 14m 10s | Max: 16m 58s
  🟩 Clang15            Pass: 100%/2   | Total: 27m 52s | Avg: 13m 56s | Max: 15m 10s
  🟩 Clang16            Pass: 100%/4   | Total: 51m 26s | Avg: 12m 51s | Max: 13m 58s
  🟩 Clang17            Pass: 100%/2   | Total: 28m 52s | Avg: 14m 26s | Max: 14m 30s
  🟩 Clang18            Pass: 100%/2   | Total: 30m 00s | Avg: 15m 00s | Max: 16m 26s
  🟩 GCC9               Pass: 100%/2   | Total: 25m 07s | Avg: 12m 33s | Max: 13m 04s
  🟩 GCC10              Pass: 100%/4   | Total: 57m 03s | Avg: 14m 15s | Max: 16m 00s
  🟩 GCC11              Pass: 100%/4   | Total: 52m 52s | Avg: 13m 13s | Max: 14m 27s
  🟩 GCC12              Pass: 100%/7   | Total:  1h 45m | Avg: 15m 07s | Max: 21m 25s
  🟩 GCC13              Pass: 100%/3   | Total: 36m 30s | Avg: 12m 10s | Max: 14m 30s
  🟩 MSVC14.36          Pass: 100%/1   | Total: 10m 21s | Avg: 10m 21s | Max: 10m 21s | Hits:  57%/128   
  🟩 MSVC14.39          Pass: 100%/1   | Total: 13m 22s | Avg: 13m 22s | Max: 13m 22s | Hits:  57%/128   
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 15m 08s | Avg:  7m 34s | Max:  7m 42s
🟩 cxx_family
  🟩 Clang              Pass: 100%/30  | Total:  6h 37m | Avg: 13m 14s | Max: 16m 58s
  🟩 GCC                Pass: 100%/20  | Total:  4h 37m | Avg: 13m 52s | Max: 21m 25s
  🟩 MSVC               Pass: 100%/2   | Total: 23m 43s | Avg: 11m 51s | Max: 13m 22s | Hits:  57%/256   
  🟩 NVHPC              Pass: 100%/2   | Total: 15m 08s | Avg:  7m 34s | Max:  7m 42s
🟩 gpu
  🟩 v100               Pass: 100%/54  | Total: 11h 53m | Avg: 13m 13s | Max: 21m 25s | Hits:  57%/256   
🟩 jobs
  🟩 Build              Pass: 100%/49  | Total: 10h 25m | Avg: 12m 45s | Max: 16m 00s | Hits:  57%/256   
  🟩 Test               Pass: 100%/5   | Total:  1h 28m | Avg: 17m 41s | Max: 21m 25s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  9m 53s | Avg:  9m 53s | Max:  9m 53s
  🟩 90a                Pass: 100%/1   | Total:  9m 55s | Avg:  9m 55s | Max:  9m 55s
🟩 std
  🟩 17                 Pass: 100%/29  | Total:  6h 17m | Avg: 13m 00s | Max: 21m 25s
  🟩 20                 Pass: 100%/25  | Total:  5h 36m | Avg: 13m 27s | Max: 16m 58s | Hits:  57%/256

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 10m 59s | Avg: 5m 29s | Max: 8m 41s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 10m 59s | Avg:  5m 29s | Max:  8m 41s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total: 10m 59s | Avg:  5m 29s | Max:  8m 41s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total: 10m 59s | Avg:  5m 29s | Max:  8m 41s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 10m 59s | Avg:  5m 29s | Max:  8m 41s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 10m 59s | Avg:  5m 29s | Max:  8m 41s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 10m 59s | Avg:  5m 29s | Max:  8m 41s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total: 10m 59s | Avg:  5m 29s | Max:  8m 41s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 18s | Avg:  2m 18s | Max:  2m 18s
  🟩 Test               Pass: 100%/1   | Total:  8m 41s | Avg:  8m 41s | Max:  8m 41s

  • 🟩 python: Pass: 100%/1 | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
+/- libcu++
CUB
Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
+/- libcu++
+/- CUB
+/- Thrust
+/- CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 396)
# Runner
327 linux-amd64-cpu16
28 linux-arm64-cpu16
26 linux-amd64-gpu-v100-latest-1
15 windows-amd64-cpu16

@miscco miscco merged commit 6001552 into NVIDIA:main Dec 5, 2024
410 checks passed
@miscco miscco deleted the mdspan_assertion branch December 5, 2024 11:33
fbusato
fbusato reviewed Dec 5, 2024
View reviewed changes
libcudacxx/include/cuda/std/__mdspan/mdspan.h
@@ -77,7 +77,7 @@

_LIBCUDACXX_BEGIN_NAMESPACE_STD

#if _CCCL_STD_VER > 2011
#if _CCCL_STD_VER >= 2014
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: we report c++17 for mdspan support in the docs

libcudacxx/include/cuda/std/__mdspan/mdspan.h
{
return __self.__accessor_ref().access(__self.__ptr_ref(), __self.__mapping_ref()(__indices[_Idxs]...));
const index_type __res = __self.__mapping_ref()(__indices[_Idxs]...);
_CCCL_ASSERT(__res < __self.__mapping_ref().required_span_size(), "cuda::std::mdspan subscript out of range!");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important: this check is too weak. We should check out-of-bound accesses for each dimension and not globally.

@miscco miscco mentioned this pull request Dec 5, 2024
Closed
pciolkosz pushed a commit to pciolkosz/cccl that referenced this pull request Dec 6, 2024
@miscco @pciolkosz
Add assertions in the mdspan accessors that we are not out of bounds (N…
f50a90f 
…VIDIA#3055)

While we are at it drop some of the custom macros and use the proper CCCL ones.
Also slap nodiscard on all the APIs
Try to avoid pointless comparison warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbusato fbusato fbusato left review comments

@bernhardmgruber bernhardmgruber bernhardmgruber approved these changes

@wmaxey wmaxey Awaiting requested review from wmaxey wmaxey is a code owner automatically assigned from NVIDIA/cccl-libcudacxx-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Add out of bound assertion to cuda::std::mdspan on operator()
3 participants
@miscco @bernhardmgruber @fbusato