Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a shadow warning in thrust's execute_with_dependencies.h #334

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Fix a shadow warning in thrust's execute_with_dependencies.h #334

merged 1 commit into from
Aug 18, 2023

Conversation

hageboeck
Copy link
Contributor

@hageboeck hageboeck commented Aug 15, 2023 •
edited
Loading

[skip-tests]

Fix NVIDIA/thrust#1980
Fix #335

Moved to here from NVIDIA/thrust#1981 (comment)

Checklist

  • [?] New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@hageboeck hageboeck requested review from a team as code owners August 15, 2023 13:16
@hageboeck hageboeck requested review from miscco and wmaxey and removed request for a team August 15, 2023 13:16
@rapids-bot
Copy link

rapids-bot bot commented Aug 15, 2023

Pull requests from external contributors require approval from a NVIDIA organization member with write permissions or greater before CI can begin.

@hageboeck hageboeck mentioned this pull request Aug 15, 2023
Closed
@miscco
Copy link
Collaborator

miscco commented Aug 15, 2023

/ok to test

@miscco
Copy link
Collaborator

miscco commented Aug 15, 2023

Thanks a lot for the contribution 🎉

@hageboeck
Copy link
Contributor Author

Now the issue is also in this repo:
#335

@miscco
Copy link
Collaborator

miscco commented Aug 15, 2023 •
edited
Loading

@jarmak-nv Shouldnt this PR get someone assigned?

EDIT: Now that I write it I see that Wesley was also added

@miscco
Copy link
Collaborator

miscco commented Aug 16, 2023

@wmaxey I believe we do not want this also backported to 2.2 It is only a warning after all?

@miscco miscco merged commit 1abdb94 into NVIDIA:main Aug 18, 2023
431 checks passed
@miscco
Copy link
Collaborator

miscco commented Aug 18, 2023

Thanks a lot for the contribution 🎉

@hageboeck hageboeck deleted the fixShadow branch November 23, 2023 16:39
@hageboeck hageboeck mentioned this pull request Nov 23, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad approved these changes

@miscco miscco miscco approved these changes

@wmaxey wmaxey Awaiting requested review from wmaxey wmaxey is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Shadow warning in thrust Shadow warning in execute_with_dependencies
3 participants
@hageboeck @miscco @jrhemstad