Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and replace CUB_IS_INT128_ENABLED #3427

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Deprecate and replace CUB_IS_INT128_ENABLED #3427

merged 4 commits into from
Jan 30, 2025

Conversation

fbusato
Copy link
Contributor

@fbusato fbusato commented Jan 16, 2025

Fixes #3403

Description

Deprecate and replace CUB_IS_INT128_ENABLED with _CCCL_HAS_INT128()

Requires: #3413

@fbusato fbusato added the 2.8.0 target for 2.8.0 release label Jan 16, 2025
@fbusato fbusato self-assigned this Jan 16, 2025
@fbusato fbusato requested a review from a team as a code owner January 16, 2025 20:49
bernhardmgruber
bernhardmgruber approved these changes Jan 21, 2025
View reviewed changes
cub/cub/util_type.cuh Outdated Show resolved Hide resolved
@fbusato @bernhardmgruber
Update cub/cub/util_type.cuh
b9c6299 
Co-authored-by: Bernhard Manfred Gruber <[email protected]>
@fbusato fbusato enabled auto-merge (squash) January 29, 2025 20:55
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 4h 29m: Pass: 100%/89 | Total: 1d 06h | Avg: 20m 34s | Max: 1h 17m | Hits: 157%/10936

  • 🟩 cub: Pass: 100%/44 | Total: 20h 10m | Avg: 27m 30s | Max: 1h 17m | Hits: 88%/3552 

    🟩 cpu
  🟩 amd64              Pass: 100%/42  | Total: 19h 20m | Avg: 27m 38s | Max:  1h 17m | Hits:  88%/3552  
  🟩 arm64              Pass: 100%/2   | Total: 49m 27s | Avg: 24m 43s | Max: 44m 20s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  2h 30m | Avg: 30m 01s | Max:  1h 00m | Hits:  90%/888   
  🟩 12.5               Pass: 100%/2   | Total:  2h 24m | Avg:  1h 12m | Max:  1h 14m
  🟩 12.6               Pass: 100%/37  | Total: 15h 15m | Avg: 24m 44s | Max:  1h 17m | Hits:  87%/2664  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  9m 14s | Avg:  4m 37s | Max:  4m 39s
  🟩 nvcc12.0           Pass: 100%/5   | Total:  2h 30m | Avg: 30m 01s | Max:  1h 00m | Hits:  90%/888   
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 24m | Avg:  1h 12m | Max:  1h 14m
  🟩 nvcc12.6           Pass: 100%/35  | Total: 15h 06m | Avg: 25m 53s | Max:  1h 17m | Hits:  87%/2664  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  9m 14s | Avg:  4m 37s | Max:  4m 39s
  🟩 nvcc               Pass: 100%/42  | Total: 20h 01m | Avg: 28m 35s | Max:  1h 17m | Hits:  88%/3552  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  2h 34m | Avg: 38m 36s | Max: 41m 00s
  🟩 Clang15            Pass: 100%/2   | Total:  1h 19m | Avg: 39m 58s | Max: 42m 12s
  🟩 Clang16            Pass: 100%/2   | Total:  1h 13m | Avg: 36m 55s | Max: 37m 13s
  🟩 Clang17            Pass: 100%/2   | Total:  1h 13m | Avg: 36m 44s | Max: 37m 02s
  🟩 Clang18            Pass: 100%/7   | Total:  3h 17m | Avg: 28m 15s | Max: 44m 20s
  🟩 GCC7               Pass: 100%/2   | Total: 11m 02s | Avg:  5m 31s | Max:  5m 43s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 31s | Avg:  5m 31s | Max:  5m 31s
  🟩 GCC9               Pass: 100%/2   | Total: 11m 59s | Avg:  5m 59s | Max:  6m 29s
  🟩 GCC10              Pass: 100%/2   | Total: 11m 52s | Avg:  5m 56s | Max:  5m 59s
  🟩 GCC11              Pass: 100%/2   | Total: 11m 56s | Avg:  5m 58s | Max:  6m 00s
  🟩 GCC12              Pass: 100%/4   | Total: 35m 45s | Avg:  8m 56s | Max: 19m 32s
  🟩 GCC13              Pass: 100%/8   | Total:  2h 00m | Avg: 15m 04s | Max: 28m 21s
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 11m | Hits:  90%/1776  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  2h 25m | Avg:  1h 12m | Max:  1h 17m | Hits:  86%/1776  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 24m | Avg:  1h 12m | Max:  1h 14m
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  9h 39m | Avg: 34m 05s | Max: 44m 20s
  🟩 GCC                Pass: 100%/21  | Total:  3h 28m | Avg:  9m 56s | Max: 28m 21s
  🟩 MSVC               Pass: 100%/4   | Total:  4h 37m | Avg:  1h 09m | Max:  1h 17m | Hits:  88%/3552  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 24m | Avg:  1h 12m | Max:  1h 14m
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 23m 59s | Avg: 11m 59s | Max: 19m 32s
  🟩 v100               Pass: 100%/42  | Total: 19h 46m | Avg: 28m 14s | Max:  1h 17m | Hits:  88%/3552  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total: 17h 04m | Avg: 27m 41s | Max:  1h 17m | Hits:  88%/3552  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 28m 21s | Avg: 28m 21s | Max: 28m 21s
  🟩 GraphCapture       Pass: 100%/1   | Total: 19m 32s | Avg: 19m 32s | Max: 19m 32s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 09m | Avg: 23m 03s | Max: 25m 45s
  🟩 TestGPU            Pass: 100%/2   | Total:  1h 08m | Avg: 34m 26s | Max: 41m 50s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 23m 59s | Avg: 11m 59s | Max: 19m 32s
  🟩 90a                Pass: 100%/1   | Total:  4m 40s | Avg:  4m 40s | Max:  4m 40s
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  9h 21m | Avg: 28m 05s | Max:  1h 11m | Hits:  90%/2664  
  🟩 20                 Pass: 100%/24  | Total: 10h 48m | Avg: 27m 01s | Max:  1h 17m | Hits:  82%/888

  • 🟩 thrust: Pass: 100%/42 | Total: 9h 18m | Avg: 13m 18s | Max: 1h 00m | Hits: 191%/7384 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 16m 43s | Avg:  8m 21s | Max: 11m 12s
🟩 cpu
  🟩 amd64              Pass: 100%/40  | Total:  9h 08m | Avg: 13m 43s | Max:  1h 00m | Hits: 191%/7384  
  🟩 arm64              Pass: 100%/2   | Total:  9m 59s | Avg:  4m 59s | Max:  5m 11s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  1h 09m | Avg: 13m 55s | Max: 48m 25s | Hits: 191%/1846  
  🟩 12.5               Pass: 100%/2   | Total:  1h 55m | Avg: 57m 30s | Max:  1h 00m
  🟩 12.6               Pass: 100%/35  | Total:  6h 14m | Avg: 10m 41s | Max: 56m 47s | Hits: 191%/5538  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 10m 37s | Avg:  5m 18s | Max:  5m 40s
  🟩 nvcc12.0           Pass: 100%/5   | Total:  1h 09m | Avg: 13m 55s | Max: 48m 25s | Hits: 191%/1846  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 55m | Avg: 57m 30s | Max:  1h 00m
  🟩 nvcc12.6           Pass: 100%/33  | Total:  6h 03m | Avg: 11m 00s | Max: 56m 47s | Hits: 191%/5538  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 37s | Avg:  5m 18s | Max:  5m 40s
  🟩 nvcc               Pass: 100%/40  | Total:  9h 08m | Avg: 13m 42s | Max:  1h 00m | Hits: 191%/7384  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 21m 13s | Avg:  5m 18s | Max:  5m 36s
  🟩 Clang15            Pass: 100%/2   | Total: 11m 40s | Avg:  5m 50s | Max:  6m 02s
  🟩 Clang16            Pass: 100%/2   | Total: 11m 03s | Avg:  5m 31s | Max:  5m 35s
  🟩 Clang17            Pass: 100%/2   | Total: 11m 23s | Avg:  5m 41s | Max:  5m 48s
  🟩 Clang18            Pass: 100%/7   | Total: 50m 42s | Avg:  7m 14s | Max: 16m 07s
  🟩 GCC7               Pass: 100%/2   | Total: 11m 03s | Avg:  5m 31s | Max:  5m 50s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 49s | Avg:  5m 49s | Max:  5m 49s
  🟩 GCC9               Pass: 100%/2   | Total: 11m 20s | Avg:  5m 40s | Max:  5m 45s
  🟩 GCC10              Pass: 100%/2   | Total: 11m 53s | Avg:  5m 56s | Max:  5m 59s
  🟩 GCC11              Pass: 100%/2   | Total: 11m 21s | Avg:  5m 40s | Max:  5m 51s
  🟩 GCC12              Pass: 100%/2   | Total: 12m 51s | Avg:  6m 25s | Max:  6m 27s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 06m | Avg:  8m 16s | Max: 18m 50s
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 35m | Avg: 47m 58s | Max: 48m 25s | Hits: 191%/3692  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 51m | Avg: 55m 39s | Max: 56m 47s | Hits: 191%/3692  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 55m | Avg: 57m 30s | Max:  1h 00m
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  1h 46m | Avg:  6m 14s | Max: 16m 07s
  🟩 GCC                Pass: 100%/19  | Total:  2h 10m | Avg:  6m 51s | Max: 18m 50s
  🟩 MSVC               Pass: 100%/4   | Total:  3h 27m | Avg: 51m 48s | Max: 56m 47s | Hits: 191%/7384  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 55m | Avg: 57m 30s | Max:  1h 00m
🟩 gpu
  🟩 v100               Pass: 100%/42  | Total:  9h 18m | Avg: 13m 18s | Max:  1h 00m | Hits: 191%/7384  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  8h 16m | Avg: 13m 24s | Max:  1h 00m | Hits: 191%/7384  
  🟩 TestCPU            Pass: 100%/2   | Total: 16m 13s | Avg:  8m 06s | Max:  8m 09s
  🟩 TestGPU            Pass: 100%/3   | Total: 46m 09s | Avg: 15m 23s | Max: 18m 50s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  4m 56s | Avg:  4m 56s | Max:  4m 56s
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  5h 05m | Avg: 15m 15s | Max:  1h 00m | Hits: 191%/5538  
  🟩 20                 Pass: 100%/20  | Total:  3h 56m | Avg: 11m 50s | Max: 54m 31s | Hits: 191%/1846

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 9m 27s | Avg: 4m 43s | Max: 7m 29s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  9m 27s | Avg:  4m 43s | Max:  7m 29s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total:  9m 27s | Avg:  4m 43s | Max:  7m 29s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total:  9m 27s | Avg:  4m 43s | Max:  7m 29s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  9m 27s | Avg:  4m 43s | Max:  7m 29s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  9m 27s | Avg:  4m 43s | Max:  7m 29s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  9m 27s | Avg:  4m 43s | Max:  7m 29s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total:  9m 27s | Avg:  4m 43s | Max:  7m 29s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  1m 58s | Avg:  1m 58s | Max:  1m 58s
  🟩 Test               Pass: 100%/1   | Total:  7m 29s | Avg:  7m 29s | Max:  7m 29s

  • 🟩 python: Pass: 100%/1 | Total: 52m 14s | Avg: 52m 14s | Max: 52m 14s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 52m 14s | Avg: 52m 14s | Max: 52m 14s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 52m 14s | Avg: 52m 14s | Max: 52m 14s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 52m 14s | Avg: 52m 14s | Max: 52m 14s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 52m 14s | Avg: 52m 14s | Max: 52m 14s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 52m 14s | Avg: 52m 14s | Max: 52m 14s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 52m 14s | Avg: 52m 14s | Max: 52m 14s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 52m 14s | Avg: 52m 14s | Max: 52m 14s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 52m 14s | Avg: 52m 14s | Max: 52m 14s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 89)
# Runner
65 linux-amd64-cpu16
11 linux-amd64-gpu-v100-latest-1
8 windows-amd64-cpu16
4 linux-arm64-cpu16
1 linux-amd64-gpu-h100-latest-1

@fbusato fbusato merged commit 0c17dbd into NVIDIA:main Jan 30, 2025
100 of 104 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Backport failed for branch/2.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin branch/2.8.x
git worktree add -d .worktree/backport-3427-to-branch/2.8.x origin/branch/2.8.x
cd .worktree/backport-3427-to-branch/2.8.x
git checkout -b backport-3427-to-branch/2.8.x
ancref=$(git merge-base 09b12009d906bdb69f9da60de5196991d0610f9e b3827a80d4f6f78096ff0e32d3ee064d36d022d8)
git cherry-pick -x $ancref..b3827a80d4f6f78096ff0e32d3ee064d36d022d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernhardmgruber bernhardmgruber bernhardmgruber approved these changes

Assignees

@fbusato fbusato

Labels
2.8.0 target for 2.8.0 release backport branch/2.8.x
Projects
CCCL
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace uses of CUB_IS_INT128_ENABLED by a CCCL macro and deprecate it
2 participants
@fbusato @bernhardmgruber