-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace CUB iterators by Thrust ones #3480
Merged
bernhardmgruber
merged 2 commits into
NVIDIA:main
from
bernhardmgruber:replace_cub_iterators
Feb 5, 2025
Merged
Replace CUB iterators by Thrust ones #3480
bernhardmgruber
merged 2 commits into
NVIDIA:main
from
bernhardmgruber:replace_cub_iterators
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bernhardmgruber
commented
Jan 22, 2025
•
edited
Loading
edited
- Make sure we revert all deprecations introduced in Deprecate CUB iterators existing in Thrust #3304
- Merge before: Make thrust iterators work with NVRTC #3676
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
1 task
b53e8ae
to
2ab3dc3
Compare
2ab3dc3
to
da0ad03
Compare
/ok to test |
🟩 CI finished in 1h 53m: Pass: 100%/90 | Total: 2d 17h | Avg: 43m 51s | Max: 1h 17m | Hits: 174%/13398
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 90)
# | Runner |
---|---|
65 | linux-amd64-cpu16 |
9 | windows-amd64-cpu16 |
6 | linux-amd64-gpu-rtxa6000-latest-1 |
4 | linux-arm64-cpu16 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
2 | linux-amd64-gpu-rtx2080-latest-1 |
1 | linux-amd64-gpu-h100-latest-1 |
0965aa5
to
5779408
Compare
🟩 CI finished in 3h 03m: Pass: 100%/90 | Total: 2d 23h | Avg: 47m 24s | Max: 1h 51m | Hits: 127%/13398
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 90)
# | Runner |
---|---|
65 | linux-amd64-cpu16 |
9 | windows-amd64-cpu16 |
6 | linux-amd64-gpu-rtxa6000-latest-1 |
4 | linux-arm64-cpu16 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
2 | linux-amd64-gpu-rtx2080-latest-1 |
1 | linux-amd64-gpu-h100-latest-1 |
miscco
approved these changes
Feb 5, 2025
elstehle
approved these changes
Feb 5, 2025
bernhardmgruber
added a commit
to bernhardmgruber/cccl
that referenced
this pull request
Feb 5, 2025
Also consider thrust::discard_iterator's value_type void Fixes: NVIDIA#3261
miscco
added a commit
that referenced
this pull request
Feb 6, 2025
…place CUB iterators by Thrust ones (#3480) (#3697) * Make thrust iterators work with NVRTC (#3676) * Make thrust iterators work with NVRTC As a drive-by, all iterator tags used in CUB and Thrust are replaced with ones from libcu++. Co-authored-by: Michael Schellenberger Costa <[email protected]> * More NVRTC fixes * Replace CUB iterators by Thrust ones (#3480) Also consider thrust::discard_iterator's value_type void Fixes: #3261 --------- Co-authored-by: Michael Schellenberger Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.