Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transform iterator for non-copy-constructible types #3542

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fix transform iterator for non-copy-constructible types #3542

merged 2 commits into from
Jan 28, 2025

Conversation

bernhardmgruber
Copy link
Contributor

Pulled out from #3503 and added a test.

Fixes: #3541

@bernhardmgruber bernhardmgruber requested a review from a team as a code owner January 27, 2025 19:51
@bernhardmgruber bernhardmgruber mentioned this pull request Jan 27, 2025
Closed
1 task
miscco
miscco approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling that out

@miscco miscco enabled auto-merge (squash) January 28, 2025 13:55
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 3h 15m: Pass: 100%/89 | Total: 15h 05m | Avg: 10m 10s | Max: 1h 05m | Hits: 421%/10936

  • 🟩 cub: Pass: 100%/44 | Total: 7h 34m | Avg: 10m 19s | Max: 32m 43s | Hits: 540%/3552 

    🟩 cpu
  🟩 amd64              Pass: 100%/42  | Total:  7h 24m | Avg: 10m 34s | Max: 32m 43s | Hits: 540%/3552  
  🟩 arm64              Pass: 100%/2   | Total: 10m 02s | Avg:  5m 01s | Max:  5m 04s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 47m 22s | Avg:  9m 28s | Max: 26m 33s | Hits: 540%/888   
  🟩 12.5               Pass: 100%/2   | Total: 19m 09s | Avg:  9m 34s | Max:  9m 50s
  🟩 12.6               Pass: 100%/37  | Total:  6h 27m | Avg: 10m 28s | Max: 32m 43s | Hits: 540%/2664  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  9m 07s | Avg:  4m 33s | Max:  4m 38s
  🟩 nvcc12.0           Pass: 100%/5   | Total: 47m 22s | Avg:  9m 28s | Max: 26m 33s | Hits: 540%/888   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 19m 09s | Avg:  9m 34s | Max:  9m 50s
  🟩 nvcc12.6           Pass: 100%/35  | Total:  6h 18m | Avg: 10m 49s | Max: 32m 43s | Hits: 540%/2664  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  9m 07s | Avg:  4m 33s | Max:  4m 38s
  🟩 nvcc               Pass: 100%/42  | Total:  7h 25m | Avg: 10m 36s | Max: 32m 43s | Hits: 540%/3552  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 21m 14s | Avg:  5m 18s | Max:  5m 42s
  🟩 Clang15            Pass: 100%/2   | Total: 11m 07s | Avg:  5m 33s | Max:  5m 45s
  🟩 Clang16            Pass: 100%/2   | Total: 11m 38s | Avg:  5m 49s | Max:  6m 02s
  🟩 Clang17            Pass: 100%/2   | Total: 11m 17s | Avg:  5m 38s | Max:  5m 52s
  🟩 Clang18            Pass: 100%/7   | Total:  1h 08m | Avg:  9m 50s | Max: 22m 27s
  🟩 GCC7               Pass: 100%/2   | Total: 10m 33s | Avg:  5m 16s | Max:  5m 33s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 18s | Avg:  5m 18s | Max:  5m 18s
  🟩 GCC9               Pass: 100%/2   | Total: 11m 42s | Avg:  5m 51s | Max:  6m 06s
  🟩 GCC10              Pass: 100%/2   | Total: 10m 56s | Avg:  5m 28s | Max:  5m 36s
  🟩 GCC11              Pass: 100%/2   | Total: 11m 24s | Avg:  5m 42s | Max:  6m 02s
  🟩 GCC12              Pass: 100%/4   | Total: 35m 05s | Avg:  8m 46s | Max: 19m 19s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 49m | Avg: 13m 41s | Max: 25m 06s
  🟩 MSVC14.29          Pass: 100%/2   | Total: 53m 17s | Avg: 26m 38s | Max: 26m 44s | Hits: 540%/1776  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 03m | Avg: 31m 36s | Max: 32m 43s | Hits: 540%/1776  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 19m 09s | Avg:  9m 34s | Max:  9m 50s
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  2h 04m | Avg:  7m 18s | Max: 22m 27s
  🟩 GCC                Pass: 100%/21  | Total:  3h 14m | Avg:  9m 15s | Max: 25m 06s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 56m | Avg: 29m 07s | Max: 32m 43s | Hits: 540%/3552  
  🟩 NVHPC              Pass: 100%/2   | Total: 19m 09s | Avg:  9m 34s | Max:  9m 50s
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 23m 39s | Avg: 11m 49s | Max: 19m 19s
  🟩 v100               Pass: 100%/42  | Total:  7h 10m | Avg: 10m 15s | Max: 32m 43s | Hits: 540%/3552  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  5h 03m | Avg:  8m 11s | Max: 32m 43s | Hits: 540%/3552  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 25m 06s | Avg: 25m 06s | Max: 25m 06s
  🟩 GraphCapture       Pass: 100%/1   | Total: 22m 27s | Avg: 22m 27s | Max: 22m 27s
  🟩 HostLaunch         Pass: 100%/3   | Total: 59m 33s | Avg: 19m 51s | Max: 20m 53s
  🟩 TestGPU            Pass: 100%/2   | Total: 43m 56s | Avg: 21m 58s | Max: 22m 27s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 23m 39s | Avg: 11m 49s | Max: 19m 19s
  🟩 90a                Pass: 100%/1   | Total:  4m 29s | Avg:  4m 29s | Max:  4m 29s
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  3h 01m | Avg:  9m 03s | Max: 30m 30s | Hits: 540%/2664  
  🟩 20                 Pass: 100%/24  | Total:  4h 33m | Avg: 11m 22s | Max: 32m 43s | Hits: 540%/888

  • 🟩 thrust: Pass: 100%/42 | Total: 6h 15m | Avg: 8m 56s | Max: 31m 21s | Hits: 365%/7384 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 17m 26s | Avg:  8m 43s | Max: 11m 05s
🟩 cpu
  🟩 amd64              Pass: 100%/40  | Total:  6h 05m | Avg:  9m 08s | Max: 31m 21s | Hits: 365%/7384  
  🟩 arm64              Pass: 100%/2   | Total:  9m 50s | Avg:  4m 55s | Max:  5m 08s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 44m 04s | Avg:  8m 48s | Max: 23m 09s | Hits: 365%/1846  
  🟩 12.5               Pass: 100%/2   | Total: 31m 06s | Avg: 15m 33s | Max: 15m 42s
  🟩 12.6               Pass: 100%/35  | Total:  5h 00m | Avg:  8m 35s | Max: 31m 21s | Hits: 365%/5538  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 10m 44s | Avg:  5m 22s | Max:  5m 38s
  🟩 nvcc12.0           Pass: 100%/5   | Total: 44m 04s | Avg:  8m 48s | Max: 23m 09s | Hits: 365%/1846  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 31m 06s | Avg: 15m 33s | Max: 15m 42s
  🟩 nvcc12.6           Pass: 100%/33  | Total:  4h 49m | Avg:  8m 46s | Max: 31m 21s | Hits: 365%/5538  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 44s | Avg:  5m 22s | Max:  5m 38s
  🟩 nvcc               Pass: 100%/40  | Total:  6h 04m | Avg:  9m 07s | Max: 31m 21s | Hits: 365%/7384  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 21m 55s | Avg:  5m 28s | Max:  5m 52s
  🟩 Clang15            Pass: 100%/2   | Total: 11m 15s | Avg:  5m 37s | Max:  5m 53s
  🟩 Clang16            Pass: 100%/2   | Total: 10m 59s | Avg:  5m 29s | Max:  5m 30s
  🟩 Clang17            Pass: 100%/2   | Total: 11m 56s | Avg:  5m 58s | Max:  6m 01s
  🟩 Clang18            Pass: 100%/7   | Total: 45m 17s | Avg:  6m 28s | Max: 10m 49s
  🟩 GCC7               Pass: 100%/2   | Total: 11m 09s | Avg:  5m 34s | Max:  6m 04s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 30s | Avg:  5m 30s | Max:  5m 30s
  🟩 GCC9               Pass: 100%/2   | Total: 11m 20s | Avg:  5m 40s | Max:  5m 58s
  🟩 GCC10              Pass: 100%/2   | Total: 11m 59s | Avg:  5m 59s | Max:  6m 08s
  🟩 GCC11              Pass: 100%/2   | Total: 12m 15s | Avg:  6m 07s | Max:  6m 10s
  🟩 GCC12              Pass: 100%/2   | Total: 12m 24s | Avg:  6m 12s | Max:  6m 32s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 06m | Avg:  8m 19s | Max: 18m 02s
  🟩 MSVC14.29          Pass: 100%/2   | Total: 50m 31s | Avg: 25m 15s | Max: 27m 22s | Hits: 365%/3692  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 01m | Avg: 30m 42s | Max: 31m 21s | Hits: 365%/3692  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 31m 06s | Avg: 15m 33s | Max: 15m 42s
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  1h 41m | Avg:  5m 57s | Max: 10m 49s
  🟩 GCC                Pass: 100%/19  | Total:  2h 11m | Avg:  6m 54s | Max: 18m 02s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 51m | Avg: 27m 59s | Max: 31m 21s | Hits: 365%/7384  
  🟩 NVHPC              Pass: 100%/2   | Total: 31m 06s | Avg: 15m 33s | Max: 15m 42s
🟩 gpu
  🟩 v100               Pass: 100%/42  | Total:  6h 15m | Avg:  8m 56s | Max: 31m 21s | Hits: 365%/7384  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  5h 20m | Avg:  8m 38s | Max: 31m 21s | Hits: 365%/7384  
  🟩 TestCPU            Pass: 100%/2   | Total: 15m 43s | Avg:  7m 51s | Max:  8m 23s
  🟩 TestGPU            Pass: 100%/3   | Total: 39m 56s | Avg: 13m 18s | Max: 18m 02s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  4m 32s | Avg:  4m 32s | Max:  4m 32s
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  3h 09m | Avg:  9m 29s | Max: 30m 04s | Hits: 365%/5538  
  🟩 20                 Pass: 100%/20  | Total:  2h 48m | Avg:  8m 25s | Max: 31m 21s | Hits: 365%/1846

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 9m 53s | Avg: 4m 56s | Max: 7m 54s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  9m 53s | Avg:  4m 56s | Max:  7m 54s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total:  9m 53s | Avg:  4m 56s | Max:  7m 54s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total:  9m 53s | Avg:  4m 56s | Max:  7m 54s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  9m 53s | Avg:  4m 56s | Max:  7m 54s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  9m 53s | Avg:  4m 56s | Max:  7m 54s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  9m 53s | Avg:  4m 56s | Max:  7m 54s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total:  9m 53s | Avg:  4m 56s | Max:  7m 54s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  1m 59s | Avg:  1m 59s | Max:  1m 59s
  🟩 Test               Pass: 100%/1   | Total:  7m 54s | Avg:  7m 54s | Max:  7m 54s

  • 🟩 python: Pass: 100%/1 | Total: 1h 05m | Avg: 1h 05m | Max: 1h 05m

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total:  1h 05m | Avg:  1h 05m | Max:  1h 05m
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total:  1h 05m | Avg:  1h 05m | Max:  1h 05m
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total:  1h 05m | Avg:  1h 05m | Max:  1h 05m
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total:  1h 05m | Avg:  1h 05m | Max:  1h 05m
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total:  1h 05m | Avg:  1h 05m | Max:  1h 05m
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total:  1h 05m | Avg:  1h 05m | Max:  1h 05m
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total:  1h 05m | Avg:  1h 05m | Max:  1h 05m
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total:  1h 05m | Avg:  1h 05m | Max:  1h 05m

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
+/- Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 89)
# Runner
65 linux-amd64-cpu16
11 linux-amd64-gpu-v100-latest-1
8 windows-amd64-cpu16
4 linux-arm64-cpu16
1 linux-amd64-gpu-h100-latest-1-testing

@miscco miscco merged commit 4567491 into NVIDIA:main Jan 28, 2025
101 of 104 checks passed
@bernhardmgruber bernhardmgruber deleted the fix_transform_iter branch January 29, 2025 08:04
davebayer pushed a commit to davebayer/cccl that referenced this pull request Jan 29, 2025
@bernhardmgruber @miscco @davebayer
Fix transform iterator for non-copy-constructible types (NVIDIA#3542)
dc5f31f 
Fixes: NVIDIA#3541

Co-authored-by: Michael Schellenberger Costa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@elstehle elstehle elstehle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Compiler fails to generate default copy assignment operator for thrust::transform_iterator
3 participants
@bernhardmgruber @miscco @elstehle