Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LEGACY_PTX_ARCH #3551

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Remove LEGACY_PTX_ARCH #3551

merged 5 commits into from
Jan 30, 2025

Conversation

fbusato
Copy link
Contributor

@fbusato fbusato commented Jan 28, 2025 •
edited
Loading

Fixes #3552

Description

Remove all code related to LEGACY_PTX_ARCH

see [EPIC] Breaking changes for CCCL 3.0

@fbusato fbusato added the 3.0 Targeted for 3.0 release label Jan 28, 2025
@fbusato fbusato self-assigned this Jan 28, 2025
@fbusato fbusato requested review from a team as code owners January 28, 2025 00:00
@bernhardmgruber bernhardmgruber added thrust For all items related to Thrust. breaking Breaking change labels Jan 28, 2025
@fbusato fbusato enabled auto-merge (squash) January 29, 2025 23:54
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 1h 47m: Pass: 100%/89 | Total: 2d 15h | Avg: 43m 00s | Max: 1h 18m | Hits: 155%/10896

  • 🟩 cub: Pass: 100%/44 | Total: 1d 15h | Avg: 54m 02s | Max: 1h 18m | Hits: 110%/3512 

    🟩 cpu
  🟩 amd64              Pass: 100%/42  | Total:  1d 13h | Avg: 53m 47s | Max:  1h 18m | Hits: 110%/3512  
  🟩 arm64              Pass: 100%/2   | Total:  1h 58m | Avg: 59m 03s | Max: 59m 56s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  5h 05m | Avg:  1h 01m | Max:  1h 04m | Hits: 110%/878   
  🟩 12.5               Pass: 100%/2   | Total:  2h 20m | Avg:  1h 10m | Max:  1h 16m
  🟩 12.6               Pass: 100%/37  | Total:  1d 08h | Avg: 52m 11s | Max:  1h 18m | Hits: 109%/2634  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  1h 57m | Avg: 58m 46s | Max: 58m 57s
  🟩 nvcc12.0           Pass: 100%/5   | Total:  5h 05m | Avg:  1h 01m | Max:  1h 04m | Hits: 110%/878   
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 20m | Avg:  1h 10m | Max:  1h 16m
  🟩 nvcc12.6           Pass: 100%/35  | Total:  1d 06h | Avg: 51m 49s | Max:  1h 18m | Hits: 109%/2634  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  1h 57m | Avg: 58m 46s | Max: 58m 57s
  🟩 nvcc               Pass: 100%/42  | Total:  1d 13h | Avg: 53m 48s | Max:  1h 18m | Hits: 110%/3512  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  4h 06m | Avg:  1h 01m | Max:  1h 11m
  🟩 Clang15            Pass: 100%/2   | Total:  2h 02m | Avg:  1h 01m | Max:  1h 02m
  🟩 Clang16            Pass: 100%/2   | Total:  2h 05m | Avg:  1h 02m | Max:  1h 04m
  🟩 Clang17            Pass: 100%/2   | Total:  2h 01m | Avg:  1h 00m | Max:  1h 01m
  🟩 Clang18            Pass: 100%/7   | Total:  5h 34m | Avg: 47m 46s | Max: 58m 57s
  🟩 GCC7               Pass: 100%/2   | Total:  2h 05m | Avg:  1h 02m | Max:  1h 04m
  🟩 GCC8               Pass: 100%/1   | Total: 59m 50s | Avg: 59m 50s | Max: 59m 50s
  🟩 GCC9               Pass: 100%/2   | Total:  2h 02m | Avg:  1h 01m | Max:  1h 04m
  🟩 GCC10              Pass: 100%/2   | Total:  2h 10m | Avg:  1h 05m | Max:  1h 05m
  🟩 GCC11              Pass: 100%/2   | Total:  1h 55m | Avg: 57m 42s | Max: 58m 58s
  🟩 GCC12              Pass: 100%/4   | Total:  2h 46m | Avg: 41m 33s | Max: 57m 20s
  🟩 GCC13              Pass: 100%/8   | Total:  4h 47m | Avg: 35m 53s | Max:  1h 04m
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 10m | Avg:  1h 05m | Max:  1h 08m | Hits: 110%/1756  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  2h 29m | Avg:  1h 14m | Max:  1h 18m | Hits: 109%/1756  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 20m | Avg:  1h 10m | Max:  1h 16m
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total: 15h 49m | Avg: 55m 51s | Max:  1h 11m
  🟩 GCC                Pass: 100%/21  | Total: 16h 46m | Avg: 47m 57s | Max:  1h 05m
  🟩 MSVC               Pass: 100%/4   | Total:  4h 40m | Avg:  1h 10m | Max:  1h 18m | Hits: 110%/3512  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 20m | Avg:  1h 10m | Max:  1h 16m
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 51m 58s | Avg: 25m 59s | Max: 26m 08s
  🟩 rtxa6000           Pass: 100%/8   | Total:  4h 05m | Avg: 30m 42s | Max:  1h 04m
  🟩 v100               Pass: 100%/34  | Total:  1d 10h | Avg:  1h 01m | Max:  1h 18m | Hits: 110%/3512  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  1d 13h | Avg:  1h 00m | Max:  1h 18m | Hits: 110%/3512  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 21m 26s | Avg: 21m 26s | Max: 21m 26s
  🟩 GraphCapture       Pass: 100%/1   | Total: 16m 05s | Avg: 16m 05s | Max: 16m 05s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 15m | Avg: 25m 09s | Max: 26m 08s
  🟩 TestGPU            Pass: 100%/2   | Total: 39m 42s | Avg: 19m 51s | Max: 20m 24s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 51m 58s | Avg: 25m 59s | Max: 26m 08s
  🟩 90a                Pass: 100%/1   | Total: 25m 07s | Avg: 25m 07s | Max: 25m 07s
🟩 std
  🟩 17                 Pass: 100%/20  | Total: 20h 31m | Avg:  1h 01m | Max:  1h 10m | Hits: 110%/2634  
  🟩 20                 Pass: 100%/24  | Total: 19h 06m | Avg: 47m 46s | Max:  1h 18m | Hits: 107%/878

  • 🟩 thrust: Pass: 100%/42 | Total: 23h 35m | Avg: 33m 41s | Max: 1h 03m | Hits: 177%/7384 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 40m 06s | Avg: 20m 03s | Max: 28m 40s
🟩 cpu
  🟩 amd64              Pass: 100%/40  | Total: 22h 35m | Avg: 33m 53s | Max:  1h 03m | Hits: 177%/7384  
  🟩 arm64              Pass: 100%/2   | Total: 59m 35s | Avg: 29m 47s | Max: 31m 12s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  3h 08m | Avg: 37m 36s | Max: 53m 01s | Hits: 177%/1846  
  🟩 12.5               Pass: 100%/2   | Total:  1h 57m | Avg: 58m 50s | Max: 59m 46s
  🟩 12.6               Pass: 100%/35  | Total: 18h 29m | Avg: 31m 41s | Max:  1h 03m | Hits: 177%/5538  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 57m 30s | Avg: 28m 45s | Max: 29m 53s
  🟩 nvcc12.0           Pass: 100%/5   | Total:  3h 08m | Avg: 37m 36s | Max: 53m 01s | Hits: 177%/1846  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 57m | Avg: 58m 50s | Max: 59m 46s
  🟩 nvcc12.6           Pass: 100%/33  | Total: 17h 31m | Avg: 31m 52s | Max:  1h 03m | Hits: 177%/5538  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 57m 30s | Avg: 28m 45s | Max: 29m 53s
  🟩 nvcc               Pass: 100%/40  | Total: 22h 37m | Avg: 33m 56s | Max:  1h 03m | Hits: 177%/7384  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  2h 13m | Avg: 33m 18s | Max: 34m 28s
  🟩 Clang15            Pass: 100%/2   | Total:  1h 08m | Avg: 34m 09s | Max: 34m 24s
  🟩 Clang16            Pass: 100%/2   | Total:  1h 03m | Avg: 31m 32s | Max: 31m 53s
  🟩 Clang17            Pass: 100%/2   | Total:  1h 06m | Avg: 33m 21s | Max: 34m 01s
  🟩 Clang18            Pass: 100%/7   | Total:  2h 50m | Avg: 24m 20s | Max: 34m 10s
  🟩 GCC7               Pass: 100%/2   | Total:  1h 00m | Avg: 30m 10s | Max: 30m 11s
  🟩 GCC8               Pass: 100%/1   | Total: 34m 21s | Avg: 34m 21s | Max: 34m 21s
  🟩 GCC9               Pass: 100%/2   | Total:  1h 12m | Avg: 36m 29s | Max: 36m 56s
  🟩 GCC10              Pass: 100%/2   | Total:  1h 10m | Avg: 35m 20s | Max: 36m 33s
  🟩 GCC11              Pass: 100%/2   | Total:  1h 05m | Avg: 32m 45s | Max: 33m 29s
  🟩 GCC12              Pass: 100%/2   | Total:  1h 09m | Avg: 34m 57s | Max: 35m 59s
  🟩 GCC13              Pass: 100%/8   | Total:  3h 06m | Avg: 23m 17s | Max: 42m 21s
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 50m | Avg: 55m 16s | Max: 57m 32s | Hits: 177%/3692  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  2h 05m | Avg:  1h 02m | Max:  1h 03m | Hits: 177%/3692  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 57m | Avg: 58m 50s | Max: 59m 46s
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  8h 21m | Avg: 29m 30s | Max: 34m 28s
  🟩 GCC                Pass: 100%/19  | Total:  9h 20m | Avg: 29m 28s | Max: 42m 21s
  🟩 MSVC               Pass: 100%/4   | Total:  3h 55m | Avg: 58m 55s | Max:  1h 03m | Hits: 177%/7384  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 57m | Avg: 58m 50s | Max: 59m 46s
🟩 gpu
  🟩 rtx4090            Pass: 100%/8   | Total:  2h 33m | Avg: 19m 12s | Max: 42m 21s
  🟩 v100               Pass: 100%/34  | Total: 21h 01m | Avg: 37m 06s | Max:  1h 03m | Hits: 177%/7384  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total: 22h 46m | Avg: 36m 56s | Max:  1h 03m | Hits: 177%/7384  
  🟩 TestCPU            Pass: 100%/2   | Total: 15m 23s | Avg:  7m 41s | Max:  7m 52s
  🟩 TestGPU            Pass: 100%/3   | Total: 33m 08s | Avg: 11m 02s | Max: 11m 36s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total: 20m 06s | Avg: 20m 06s | Max: 20m 06s
🟩 std
  🟩 17                 Pass: 100%/20  | Total: 12h 38m | Avg: 37m 54s | Max:  1h 01m | Hits: 177%/5538  
  🟩 20                 Pass: 100%/20  | Total: 10h 16m | Avg: 30m 50s | Max:  1h 03m | Hits: 177%/1846

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 7m 35s | Avg: 3m 47s | Max: 5m 26s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  7m 35s | Avg:  3m 47s | Max:  5m 26s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total:  7m 35s | Avg:  3m 47s | Max:  5m 26s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total:  7m 35s | Avg:  3m 47s | Max:  5m 26s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  7m 35s | Avg:  3m 47s | Max:  5m 26s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  7m 35s | Avg:  3m 47s | Max:  5m 26s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  7m 35s | Avg:  3m 47s | Max:  5m 26s
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total:  7m 35s | Avg:  3m 47s | Max:  5m 26s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 09s | Avg:  2m 09s | Max:  2m 09s
  🟩 Test               Pass: 100%/1   | Total:  5m 26s | Avg:  5m 26s | Max:  5m 26s

  • 🟩 python: Pass: 100%/1 | Total: 27m 49s | Avg: 27m 49s | Max: 27m 49s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 27m 49s | Avg: 27m 49s | Max: 27m 49s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 27m 49s | Avg: 27m 49s | Max: 27m 49s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 27m 49s | Avg: 27m 49s | Max: 27m 49s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 27m 49s | Avg: 27m 49s | Max: 27m 49s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 27m 49s | Avg: 27m 49s | Max: 27m 49s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 27m 49s | Avg: 27m 49s | Max: 27m 49s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 27m 49s | Avg: 27m 49s | Max: 27m 49s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 27m 49s | Avg: 27m 49s | Max: 27m 49s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 89)
# Runner
65 linux-amd64-cpu16
8 windows-amd64-cpu16
6 linux-amd64-gpu-rtxa6000-latest-1
4 linux-arm64-cpu16
3 linux-amd64-gpu-rtx4090-latest-1
2 linux-amd64-gpu-rtx2080-latest-1
1 linux-amd64-gpu-h100-latest-1

@fbusato fbusato merged commit 77a6a45 into NVIDIA:main Jan 30, 2025
100 of 104 checks passed
@fbusato fbusato deleted the remove-legacy-ptx-arch branch January 30, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@bernhardmgruber bernhardmgruber bernhardmgruber approved these changes

@alliepiper alliepiper Awaiting requested review from alliepiper alliepiper is a code owner automatically assigned from NVIDIA/cccl-codeowners

@elstehle elstehle Awaiting requested review from elstehle elstehle is a code owner automatically assigned from NVIDIA/cccl-cub-codeowners

Assignees

@fbusato fbusato

Labels
3.0 Targeted for 3.0 release breaking Breaking change thrust For all items related to Thrust.
Projects
CCCL
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove any LEGACY_PTX_ARCH parameters
3 participants
@fbusato @bernhardmgruber @miscco