-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PTX: Update generated files with Blackwell instructions #3568
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
c1272e7
to
65aae57
Compare
Is there any chance we can temporarily suppress these docs build warnings:
The documentation for these instructions will be brought up in subsequent PRs. |
@@ -54,7 +54,7 @@ api_output_directory = "api" | |||
use_fast_doxygen_conversion = true | |||
sphinx_generate_doxygen_groups = true | |||
sphinx_generate_doxygen_pages = true | |||
sphinx_exclude_patterns = [] | |||
sphinx_exclude_patterns = ['ptx/instructions/generated'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am suppressing warnings on non-included rst files for now.
I am getting failures from NVRTC:
|
0eedfdb
to
fdfb90d
Compare
#ifdef __CUDACC_RTC__ | ||
# ifndef NV_HAS_FEATURE_SM_100a | ||
# define NV_HAS_FEATURE_SM_100a __NV_HAS_FEATURE_SM_100a | ||
# if (defined(__CUDA_ARCH__) && (__CUDA_ARCH__ >= 1000) && defined(__CUDA_ARCH_FEAT_SM100_ALL)) | ||
# define _NV_TARGET_BOOL___NV_HAS_FEATURE_SM_100a 1 | ||
# else | ||
# define _NV_TARGET_BOOL___NV_HAS_FEATURE_SM_100a 0 | ||
# endif | ||
# endif // NV_HAS_FEATURE_SM_100a | ||
|
||
// Re-enable sm_101a support in nvcc. | ||
# ifndef NV_HAS_FEATURE_SM_101a | ||
# define NV_HAS_FEATURE_SM_101a __NV_HAS_FEATURE_SM_101a | ||
# if (defined(__CUDA_ARCH__) && (__CUDA_ARCH__ >= 1010) && defined(__CUDA_ARCH_FEAT_SM101_ALL)) | ||
# define _NV_TARGET_BOOL___NV_HAS_FEATURE_SM_101a 1 | ||
# else | ||
# define _NV_TARGET_BOOL___NV_HAS_FEATURE_SM_101a 0 | ||
# endif | ||
# endif // NV_HAS_FEATURE_SM_101a | ||
#endif // __CUDACC_RTC__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since NVRTC does not use our __target_macros
header, I have to ship some of them in the tests as a workaround.
Wrong files were included.
fdfb90d
to
deebc02
Compare
🟩 CI finished in 3h 05m: Pass: 100%/152 | Total: 1d 07h | Avg: 12m 22s | Max: 1h 09m | Hits: 449%/21523
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 152)
# | Runner |
---|---|
110 | linux-amd64-cpu16 |
17 | linux-amd64-gpu-v100-latest-1 |
14 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1 |
Backport failed for Please cherry-pick the changes locally. git fetch origin branch/2.8.x
git worktree add -d .worktree/backport-3568-to-branch/2.8.x origin/branch/2.8.x
cd .worktree/backport-3568-to-branch/2.8.x
git checkout -b backport-3568-to-branch/2.8.x
ancref=$(git merge-base d0f254490bad268887e33266dc64a0722318ef30 deebc024508aac9b20012ac1e972afa4437e92f5)
git cherry-pick -x $ancref..deebc024508aac9b20012ac1e972afa4437e92f5 |
* ptx: Update existing instructions * ptx: Add new instructions * Fix returning error out values See: - https://gitlab-master.nvidia.com/CCCL/libcuda-ptx/-/merge_requests/74 - https://gitlab-master.nvidia.com/CCCL/libcuda-ptx/-/merge_requests/73 * ptx: Fix out var declaration See https://gitlab-master.nvidia.com/CCCL/libcuda-ptx/-/merge_requests/75 * mbarrier.{test,try}_wait: Fix test. Wrong files were included. * docs: Fix special registers include * Allow non-included documentation pages * Workaround NVRTC Co-authored-by: Allard Hendriksen <[email protected]>
This PR updates the generated files for the PTX support in libcu++. A non-generated test and a documentation file were adapted to account for some changes in file names.