Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make uninitialized[_async]_buffer's range accessors const-correct #3615

Merged

Conversation

ericniebler
Copy link
Collaborator

Description

the range accessors for cuda::experimental::uninitialized[_async]_buffer are currently not const-correct. that is, given a reference cbuf to a const uninitialized_buffer<T>, cbuf.begin() returns a T* instead of a const T*.

since this is a publicly-facing type, it should not break const-ness.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ericniebler ericniebler requested a review from a team as a code owner January 30, 2025 18:37
@ericniebler ericniebler enabled auto-merge (squash) January 30, 2025 18:42
Copy link
Contributor

🟩 CI finished in 1h 26m: Pass: 100%/20 | Total: 1h 57m | Avg: 5m 52s | Max: 15m 09s | Hits: 385%/522
  • 🟩 cudax: Pass: 100%/20 | Total: 1h 57m | Avg: 5m 52s | Max: 15m 09s | Hits: 385%/522

    🟩 cpu
      🟩 amd64              Pass: 100%/16  | Total:  1h 43m | Avg:  6m 28s | Max: 15m 09s | Hits: 385%/522   
      🟩 arm64              Pass: 100%/4   | Total: 13m 49s | Avg:  3m 27s | Max:  3m 35s
    🟩 ctk
      🟩 12.0               Pass: 100%/1   | Total:  9m 42s | Avg:  9m 42s | Max:  9m 42s | Hits: 385%/261   
      🟩 12.5               Pass: 100%/2   | Total: 13m 09s | Avg:  6m 34s | Max:  6m 50s
      🟩 12.6               Pass: 100%/17  | Total:  1h 34m | Avg:  5m 34s | Max: 15m 09s | Hits: 385%/261   
    🟩 cudacxx
      🟩 nvcc12.0           Pass: 100%/1   | Total:  9m 42s | Avg:  9m 42s | Max:  9m 42s | Hits: 385%/261   
      🟩 nvcc12.5           Pass: 100%/2   | Total: 13m 09s | Avg:  6m 34s | Max:  6m 50s
      🟩 nvcc12.6           Pass: 100%/17  | Total:  1h 34m | Avg:  5m 34s | Max: 15m 09s | Hits: 385%/261   
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/20  | Total:  1h 57m | Avg:  5m 52s | Max: 15m 09s | Hits: 385%/522   
    🟩 cxx
      🟩 Clang14            Pass: 100%/1   | Total:  3m 38s | Avg:  3m 38s | Max:  3m 38s
      🟩 Clang15            Pass: 100%/1   | Total:  3m 49s | Avg:  3m 49s | Max:  3m 49s
      🟩 Clang16            Pass: 100%/1   | Total:  4m 01s | Avg:  4m 01s | Max:  4m 01s
      🟩 Clang17            Pass: 100%/1   | Total:  3m 58s | Avg:  3m 58s | Max:  3m 58s
      🟩 Clang18            Pass: 100%/4   | Total: 25m 48s | Avg:  6m 27s | Max: 15m 06s
      🟩 GCC10              Pass: 100%/1   | Total:  4m 34s | Avg:  4m 34s | Max:  4m 34s
      🟩 GCC11              Pass: 100%/1   | Total:  3m 54s | Avg:  3m 54s | Max:  3m 54s
      🟩 GCC12              Pass: 100%/2   | Total: 18m 53s | Avg:  9m 26s | Max: 15m 09s
      🟩 GCC13              Pass: 100%/4   | Total: 13m 12s | Avg:  3m 18s | Max:  3m 35s
      🟩 MSVC14.36          Pass: 100%/1   | Total:  9m 42s | Avg:  9m 42s | Max:  9m 42s | Hits: 385%/261   
      🟩 MSVC14.39          Pass: 100%/1   | Total: 12m 51s | Avg: 12m 51s | Max: 12m 51s | Hits: 385%/261   
      🟩 NVHPC24.7          Pass: 100%/2   | Total: 13m 09s | Avg:  6m 34s | Max:  6m 50s
    🟩 cxx_family
      🟩 Clang              Pass: 100%/8   | Total: 41m 14s | Avg:  5m 09s | Max: 15m 06s
      🟩 GCC                Pass: 100%/8   | Total: 40m 33s | Avg:  5m 04s | Max: 15m 09s
      🟩 MSVC               Pass: 100%/2   | Total: 22m 33s | Avg: 11m 16s | Max: 12m 51s | Hits: 385%/522   
      🟩 NVHPC              Pass: 100%/2   | Total: 13m 09s | Avg:  6m 34s | Max:  6m 50s
    🟩 gpu
      🟩 rtx2080            Pass: 100%/4   | Total: 37m 56s | Avg:  9m 29s | Max: 15m 09s
      🟩 v100               Pass: 100%/16  | Total:  1h 19m | Avg:  4m 58s | Max: 12m 51s | Hits: 385%/522   
    🟩 jobs
      🟩 Build              Pass: 100%/18  | Total:  1h 27m | Avg:  4m 50s | Max: 12m 51s | Hits: 385%/522   
      🟩 Test               Pass: 100%/2   | Total: 30m 15s | Avg: 15m 07s | Max: 15m 09s
    🟩 sm
      🟩 90                 Pass: 100%/1   | Total:  2m 56s | Avg:  2m 56s | Max:  2m 56s
      🟩 90a                Pass: 100%/1   | Total:  3m 12s | Avg:  3m 12s | Max:  3m 12s
    🟩 std
      🟩 17                 Pass: 100%/4   | Total: 16m 36s | Avg:  4m 09s | Max:  6m 50s
      🟩 20                 Pass: 100%/16  | Total:  1h 40m | Avg:  6m 18s | Max: 15m 09s | Hits: 385%/522   
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

🏃‍ Runner counts (total jobs: 20)

# Runner
12 linux-amd64-cpu16
4 linux-arm64-cpu16
2 windows-amd64-cpu16
2 linux-amd64-gpu-rtx2080-latest-1

@ericniebler ericniebler merged commit 0ce59c7 into NVIDIA:main Jan 30, 2025
32 of 36 checks passed
@ericniebler ericniebler deleted the cudax-const-correct-uninit-buffer branch January 30, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants