Replaces bool template parameters on `Dispatch*` class templates to use `enum class` #3643

elstehle · 2025-02-02T09:59:35Z

Description

Note to reviewers: There was a lot of manual work involved mapping bool values to corresponding enum values. I would appreciate another pair of eyes to check that all boolean values (or combinations thereof) were mapped to the correct enum values. Especially on the Device* interfaces, since we might not fully cover all Device interfaces in the tests.

github-actions · 2025-02-02T19:16:21Z

🟨 CI finished in 1h 03m: Pass: 91%/89 | Total: 1d 04h | Avg: 19m 14s | Max: 43m 44s

🟨 cub: Pass: 90%/44 | Total: 21h 51m | Avg: 29m 48s | Max: 43m 44s

🔍 cpu: amd64 🔍
  🔍 amd64              Pass:  90%/42  | Total: 20h 25m | Avg: 29m 10s | Max: 40m 06s
  🟩 arm64              Pass: 100%/2   | Total:  1h 26m | Avg: 43m 11s | Max: 43m 44s
🔍 cudacxx_family: nvcc 🔍
  🟩 ClangCUDA          Pass: 100%/2   | Total:  8m 30s | Avg:  4m 15s | Max:  4m 20s
  🔍 nvcc               Pass:  90%/42  | Total: 21h 43m | Avg: 31m 01s | Max: 43m 44s
🚨 cxx_family: MSVC 🚨
  🟩 Clang              Pass: 100%/17  | Total:  8h 51m | Avg: 31m 15s | Max: 42m 39s
  🟩 GCC                Pass: 100%/21  | Total: 10h 49m | Avg: 30m 54s | Max: 43m 44s
  🔥 MSVC               Pass:   0%/4   | Total:  1h 52m | Avg: 28m 13s | Max: 32m 43s
  🟩 NVHPC              Pass: 100%/2   | Total: 18m 19s | Avg:  9m 09s | Max:  9m 20s
🔍 gpu: v100 🔍
  🟩 h100               Pass: 100%/2   | Total: 38m 56s | Avg: 19m 28s | Max: 23m 58s
  🟩 rtxa6000           Pass: 100%/8   | Total:  3h 13m | Avg: 24m 09s | Max: 39m 11s
  🔍 v100               Pass:  88%/34  | Total: 17h 59m | Avg: 31m 45s | Max: 43m 44s
🔍 jobs: Build 🔍
  🔍 Build              Pass:  89%/37  | Total: 19h 30m | Avg: 31m 38s | Max: 43m 44s
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 19m 32s | Avg: 19m 32s | Max: 19m 32s
  🟩 GraphCapture       Pass: 100%/1   | Total: 15m 03s | Avg: 15m 03s | Max: 15m 03s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 08m | Avg: 22m 50s | Max: 23m 58s
  🟩 TestGPU            Pass: 100%/2   | Total: 37m 39s | Avg: 18m 49s | Max: 19m 30s
🟨 ctk
  🟨 12.0               Pass:  80%/5   | Total:  2h 54m | Avg: 34m 53s | Max: 38m 39s
  🟩 12.5               Pass: 100%/2   | Total: 18m 19s | Avg:  9m 09s | Max:  9m 20s
  🟨 12.6               Pass:  91%/37  | Total: 18h 38m | Avg: 30m 14s | Max: 43m 44s
🟨 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  8m 30s | Avg:  4m 15s | Max:  4m 20s
  🟨 nvcc12.0           Pass:  80%/5   | Total:  2h 54m | Avg: 34m 53s | Max: 38m 39s
  🟩 nvcc12.5           Pass: 100%/2   | Total: 18m 19s | Avg:  9m 09s | Max:  9m 20s
  🟨 nvcc12.6           Pass:  91%/35  | Total: 18h 30m | Avg: 31m 43s | Max: 43m 44s
🟨 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  2h 25m | Avg: 36m 24s | Max: 37m 47s
  🟩 Clang15            Pass: 100%/2   | Total:  1h 11m | Avg: 35m 42s | Max: 35m 52s
  🟩 Clang16            Pass: 100%/2   | Total:  1h 15m | Avg: 37m 34s | Max: 39m 08s
  🟩 Clang17            Pass: 100%/2   | Total:  1h 11m | Avg: 35m 47s | Max: 36m 26s
  🟩 Clang18            Pass: 100%/7   | Total:  2h 47m | Avg: 23m 56s | Max: 42m 39s
  🟩 GCC7               Pass: 100%/2   | Total:  1h 15m | Avg: 37m 58s | Max: 39m 28s
  🟩 GCC8               Pass: 100%/1   | Total: 40m 06s | Avg: 40m 06s | Max: 40m 06s
  🟩 GCC9               Pass: 100%/2   | Total:  1h 13m | Avg: 36m 54s | Max: 38m 39s
  🟩 GCC10              Pass: 100%/2   | Total:  1h 11m | Avg: 35m 58s | Max: 37m 00s
  🟩 GCC11              Pass: 100%/2   | Total:  1h 12m | Avg: 36m 06s | Max: 36m 08s
  🟩 GCC12              Pass: 100%/4   | Total:  1h 52m | Avg: 28m 08s | Max: 36m 51s
  🟩 GCC13              Pass: 100%/8   | Total:  3h 22m | Avg: 25m 19s | Max: 43m 44s
  🟥 MSVC14.29          Pass:   0%/2   | Total: 51m 52s | Avg: 25m 56s | Max: 26m 40s
  🟥 MSVC14.39          Pass:   0%/2   | Total:  1h 01m | Avg: 30m 31s | Max: 32m 43s
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 18m 19s | Avg:  9m 09s | Max:  9m 20s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 38m 56s | Avg: 19m 28s | Max: 23m 58s
  🟩 90a                Pass: 100%/1   | Total:  5m 49s | Avg:  5m 49s | Max:  5m 49s
🟨 std
  🟨 17                 Pass:  85%/20  | Total: 10h 50m | Avg: 32m 30s | Max: 40m 06s
  🟨 20                 Pass:  95%/24  | Total: 11h 01m | Avg: 27m 34s | Max: 43m 44s

🟨 thrust: Pass: 90%/42 | Total: 6h 08m | Avg: 8m 46s | Max: 32m 22s

🔍 cpu: amd64 🔍
  🔍 amd64              Pass:  90%/40  | Total:  5h 58m | Avg:  8m 57s | Max: 32m 22s
  🟩 arm64              Pass: 100%/2   | Total:  9m 41s | Avg:  4m 50s | Max:  5m 07s
🔍 cudacxx_family: nvcc 🔍
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 55s | Avg:  5m 27s | Max:  5m 35s
  🔍 nvcc               Pass:  90%/40  | Total:  5h 57m | Avg:  8m 56s | Max: 32m 22s
🚨 cxx_family: MSVC 🚨
  🟩 Clang              Pass: 100%/17  | Total:  1h 40m | Avg:  5m 56s | Max: 10m 16s
  🟩 GCC                Pass: 100%/19  | Total:  2h 03m | Avg:  6m 28s | Max: 11m 02s
  🔥 MSVC               Pass:   0%/4   | Total:  1h 55m | Avg: 28m 54s | Max: 32m 22s
  🟩 NVHPC              Pass: 100%/2   | Total: 28m 43s | Avg: 14m 21s | Max: 14m 26s
🔍 gpu: v100 🔍
  🟩 rtx4090            Pass: 100%/8   | Total:  1h 06m | Avg:  8m 19s | Max: 11m 02s
  🔍 v100               Pass:  88%/34  | Total:  5h 01m | Avg:  8m 52s | Max: 32m 22s
🔍 jobs: Build 🔍
  🔍 Build              Pass:  89%/37  | Total:  5h 19m | Avg:  8m 38s | Max: 32m 22s
  🟩 TestCPU            Pass: 100%/2   | Total: 16m 33s | Avg:  8m 16s | Max:  8m 31s
  🟩 TestGPU            Pass: 100%/3   | Total: 32m 11s | Avg: 10m 43s | Max: 11m 02s
🟨 ctk
  🟨 12.0               Pass:  80%/5   | Total: 46m 57s | Avg:  9m 23s | Max: 25m 39s
  🟩 12.5               Pass: 100%/2   | Total: 28m 43s | Avg: 14m 21s | Max: 14m 26s
  🟨 12.6               Pass:  91%/35  | Total:  4h 52m | Avg:  8m 21s | Max: 32m 22s
🟨 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 10m 55s | Avg:  5m 27s | Max:  5m 35s
  🟨 nvcc12.0           Pass:  80%/5   | Total: 46m 57s | Avg:  9m 23s | Max: 25m 39s
  🟩 nvcc12.5           Pass: 100%/2   | Total: 28m 43s | Avg: 14m 21s | Max: 14m 26s
  🟨 nvcc12.6           Pass:  90%/33  | Total:  4h 41m | Avg:  8m 32s | Max: 32m 22s
🟨 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 21m 47s | Avg:  5m 26s | Max:  5m 51s
  🟩 Clang15            Pass: 100%/2   | Total: 12m 04s | Avg:  6m 02s | Max:  6m 03s
  🟩 Clang16            Pass: 100%/2   | Total: 11m 10s | Avg:  5m 35s | Max:  5m 44s
  🟩 Clang17            Pass: 100%/2   | Total: 11m 06s | Avg:  5m 33s | Max:  5m 54s
  🟩 Clang18            Pass: 100%/7   | Total: 44m 48s | Avg:  6m 24s | Max: 10m 16s
  🟩 GCC7               Pass: 100%/2   | Total: 11m 27s | Avg:  5m 43s | Max:  5m 59s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 52s | Avg:  5m 52s | Max:  5m 52s
  🟩 GCC9               Pass: 100%/2   | Total: 11m 25s | Avg:  5m 42s | Max:  5m 56s
  🟩 GCC10              Pass: 100%/2   | Total: 11m 13s | Avg:  5m 36s | Max:  5m 48s
  🟩 GCC11              Pass: 100%/2   | Total: 12m 17s | Avg:  6m 08s | Max:  6m 11s
  🟩 GCC12              Pass: 100%/2   | Total: 12m 04s | Avg:  6m 02s | Max:  6m 19s
  🟩 GCC13              Pass: 100%/8   | Total: 58m 43s | Avg:  7m 20s | Max: 11m 02s
  🟥 MSVC14.29          Pass:   0%/2   | Total: 53m 59s | Avg: 26m 59s | Max: 28m 20s
  🟥 MSVC14.39          Pass:   0%/2   | Total:  1h 01m | Avg: 30m 50s | Max: 32m 22s
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 28m 43s | Avg: 14m 21s | Max: 14m 26s
🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 17m 01s | Avg:  8m 30s | Max: 10m 53s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  4m 45s | Avg:  4m 45s | Max:  4m 45s
🟨 std
  🟨 17                 Pass:  85%/20  | Total:  3h 09m | Avg:  9m 28s | Max: 29m 18s
  🟨 20                 Pass:  95%/20  | Total:  2h 41m | Avg:  8m 05s | Max: 32m 22s

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 6m 50s | Avg: 3m 25s | Max: 4m 46s

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  6m 50s | Avg:  3m 25s | Max:  4m 46s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total:  6m 50s | Avg:  3m 25s | Max:  4m 46s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total:  6m 50s | Avg:  3m 25s | Max:  4m 46s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  6m 50s | Avg:  3m 25s | Max:  4m 46s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  6m 50s | Avg:  3m 25s | Max:  4m 46s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  6m 50s | Avg:  3m 25s | Max:  4m 46s
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total:  6m 50s | Avg:  3m 25s | Max:  4m 46s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 04s | Avg:  2m 04s | Max:  2m 04s
  🟩 Test               Pass: 100%/1   | Total:  4m 46s | Avg:  4m 46s | Max:  4m 46s

🟩 python: Pass: 100%/1 | Total: 25m 27s | Avg: 25m 27s | Max: 25m 27s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 25m 27s | Avg: 25m 27s | Max: 25m 27s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 25m 27s | Avg: 25m 27s | Max: 25m 27s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 25m 27s | Avg: 25m 27s | Max: 25m 27s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 25m 27s | Avg: 25m 27s | Max: 25m 27s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 25m 27s | Avg: 25m 27s | Max: 25m 27s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 25m 27s | Avg: 25m 27s | Max: 25m 27s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 25m 27s | Avg: 25m 27s | Max: 25m 27s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 25m 27s | Avg: 25m 27s | Max: 25m 27s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 89)

#	Runner
65	`linux-amd64-cpu16`
8	`windows-amd64-cpu16`
6	`linux-amd64-gpu-rtxa6000-latest-1`
4	`linux-arm64-cpu16`
3	`linux-amd64-gpu-rtx4090-latest-1`
2	`linux-amd64-gpu-rtx2080-latest-1`
1	`linux-amd64-gpu-h100-latest-1`

github-actions · 2025-02-03T05:44:47Z

🟩 CI finished in 34m 54s: Pass: 100%/89 | Total: 14h 36m | Avg: 9m 50s | Max: 32m 59s | Hits: 417%/10908

🟩 cub: Pass: 100%/44 | Total: 7h 45m | Avg: 10m 34s | Max: 32m 59s | Hits: 530%/3524

🟩 cpu
  🟩 amd64              Pass: 100%/42  | Total:  7h 34m | Avg: 10m 49s | Max: 32m 59s | Hits: 530%/3524  
  🟩 arm64              Pass: 100%/2   | Total: 10m 57s | Avg:  5m 28s | Max:  5m 41s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 47m 51s | Avg:  9m 34s | Max: 24m 48s | Hits: 530%/881   
  🟩 12.5               Pass: 100%/2   | Total: 20m 19s | Avg: 10m 09s | Max: 10m 14s
  🟩 12.6               Pass: 100%/37  | Total:  6h 37m | Avg: 10m 44s | Max: 32m 59s | Hits: 530%/2643  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  9m 00s | Avg:  4m 30s | Max:  4m 37s
  🟩 nvcc12.0           Pass: 100%/5   | Total: 47m 51s | Avg:  9m 34s | Max: 24m 48s | Hits: 530%/881   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 20m 19s | Avg: 10m 09s | Max: 10m 14s
  🟩 nvcc12.6           Pass: 100%/35  | Total:  6h 28m | Avg: 11m 05s | Max: 32m 59s | Hits: 530%/2643  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  9m 00s | Avg:  4m 30s | Max:  4m 37s
  🟩 nvcc               Pass: 100%/42  | Total:  7h 36m | Avg: 10m 52s | Max: 32m 59s | Hits: 530%/3524  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 23m 12s | Avg:  5m 48s | Max:  6m 12s
  🟩 Clang15            Pass: 100%/2   | Total: 12m 47s | Avg:  6m 23s | Max:  6m 25s
  🟩 Clang16            Pass: 100%/2   | Total: 12m 24s | Avg:  6m 12s | Max:  6m 22s
  🟩 Clang17            Pass: 100%/2   | Total: 12m 35s | Avg:  6m 17s | Max:  6m 25s
  🟩 Clang18            Pass: 100%/7   | Total:  1h 08m | Avg:  9m 45s | Max: 21m 46s
  🟩 GCC7               Pass: 100%/2   | Total: 11m 12s | Avg:  5m 36s | Max:  5m 45s
  🟩 GCC8               Pass: 100%/1   | Total:  6m 31s | Avg:  6m 31s | Max:  6m 31s
  🟩 GCC9               Pass: 100%/2   | Total: 12m 43s | Avg:  6m 21s | Max:  6m 27s
  🟩 GCC10              Pass: 100%/2   | Total: 12m 21s | Avg:  6m 10s | Max:  6m 12s
  🟩 GCC11              Pass: 100%/2   | Total: 12m 26s | Avg:  6m 13s | Max:  6m 26s
  🟩 GCC12              Pass: 100%/4   | Total: 41m 58s | Avg: 10m 29s | Max: 24m 11s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 39m | Avg: 12m 26s | Max: 22m 48s
  🟩 MSVC14.29          Pass: 100%/2   | Total: 54m 47s | Avg: 27m 23s | Max: 29m 59s | Hits: 530%/1762  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 04m | Avg: 32m 08s | Max: 32m 59s | Hits: 530%/1762  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 20m 19s | Avg: 10m 09s | Max: 10m 14s
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  2h 09m | Avg:  7m 36s | Max: 21m 46s
  🟩 GCC                Pass: 100%/21  | Total:  3h 16m | Avg:  9m 22s | Max: 24m 11s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 59m | Avg: 29m 46s | Max: 32m 59s | Hits: 530%/3524  
  🟩 NVHPC              Pass: 100%/2   | Total: 20m 19s | Avg: 10m 09s | Max: 10m 14s
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 28m 59s | Avg: 14m 29s | Max: 24m 11s
  🟩 rtxa6000           Pass: 100%/8   | Total:  2h 10m | Avg: 16m 22s | Max: 22m 48s
  🟩 v100               Pass: 100%/34  | Total:  5h 05m | Avg:  8m 59s | Max: 32m 59s | Hits: 530%/3524  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  5h 23m | Avg:  8m 44s | Max: 32m 59s | Hits: 530%/3524  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 19m 49s | Avg: 19m 49s | Max: 19m 49s
  🟩 GraphCapture       Pass: 100%/1   | Total: 14m 53s | Avg: 14m 53s | Max: 14m 53s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 08m | Avg: 22m 55s | Max: 24m 11s
  🟩 TestGPU            Pass: 100%/2   | Total: 38m 31s | Avg: 19m 15s | Max: 19m 41s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 28m 59s | Avg: 14m 29s | Max: 24m 11s
  🟩 90a                Pass: 100%/1   | Total:  4m 22s | Avg:  4m 22s | Max:  4m 22s
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  3h 13m | Avg:  9m 39s | Max: 31m 18s | Hits: 530%/2643  
  🟩 20                 Pass: 100%/24  | Total:  4h 32m | Avg: 11m 20s | Max: 32m 59s | Hits: 530%/881

🟩 thrust: Pass: 100%/42 | Total: 6h 18m | Avg: 9m 00s | Max: 32m 29s | Hits: 363%/7384

🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 17m 05s | Avg:  8m 32s | Max: 10m 49s
🟩 cpu
  🟩 amd64              Pass: 100%/40  | Total:  6h 07m | Avg:  9m 11s | Max: 32m 29s | Hits: 363%/7384  
  🟩 arm64              Pass: 100%/2   | Total: 10m 45s | Avg:  5m 22s | Max:  5m 38s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 46m 27s | Avg:  9m 17s | Max: 23m 30s | Hits: 362%/1846  
  🟩 12.5               Pass: 100%/2   | Total: 29m 40s | Avg: 14m 50s | Max: 14m 54s
  🟩 12.6               Pass: 100%/35  | Total:  5h 01m | Avg:  8m 37s | Max: 32m 29s | Hits: 363%/5538  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 10m 50s | Avg:  5m 25s | Max:  5m 29s
  🟩 nvcc12.0           Pass: 100%/5   | Total: 46m 27s | Avg:  9m 17s | Max: 23m 30s | Hits: 362%/1846  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 29m 40s | Avg: 14m 50s | Max: 14m 54s
  🟩 nvcc12.6           Pass: 100%/33  | Total:  4h 51m | Avg:  8m 49s | Max: 32m 29s | Hits: 363%/5538  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 50s | Avg:  5m 25s | Max:  5m 29s
  🟩 nvcc               Pass: 100%/40  | Total:  6h 07m | Avg:  9m 10s | Max: 32m 29s | Hits: 363%/7384  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 22m 25s | Avg:  5m 36s | Max:  5m 42s
  🟩 Clang15            Pass: 100%/2   | Total: 12m 30s | Avg:  6m 15s | Max:  6m 28s
  🟩 Clang16            Pass: 100%/2   | Total: 12m 03s | Avg:  6m 01s | Max:  6m 09s
  🟩 Clang17            Pass: 100%/2   | Total: 12m 44s | Avg:  6m 22s | Max:  6m 22s
  🟩 Clang18            Pass: 100%/7   | Total: 45m 27s | Avg:  6m 29s | Max: 10m 14s
  🟩 GCC7               Pass: 100%/2   | Total: 11m 47s | Avg:  5m 53s | Max:  5m 54s
  🟩 GCC8               Pass: 100%/1   | Total:  6m 06s | Avg:  6m 06s | Max:  6m 06s
  🟩 GCC9               Pass: 100%/2   | Total: 12m 46s | Avg:  6m 23s | Max:  6m 44s
  🟩 GCC10              Pass: 100%/2   | Total: 13m 12s | Avg:  6m 36s | Max:  6m 37s
  🟩 GCC11              Pass: 100%/2   | Total: 12m 52s | Avg:  6m 26s | Max:  6m 34s
  🟩 GCC12              Pass: 100%/2   | Total: 13m 02s | Avg:  6m 31s | Max:  6m 53s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 00m | Avg:  7m 31s | Max: 10m 59s
  🟩 MSVC14.29          Pass: 100%/2   | Total: 50m 30s | Avg: 25m 15s | Max: 27m 00s | Hits: 362%/3692  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 02m | Avg: 31m 23s | Max: 32m 29s | Hits: 363%/3692  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 29m 40s | Avg: 14m 50s | Max: 14m 54s
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  1h 45m | Avg:  6m 11s | Max: 10m 14s
  🟩 GCC                Pass: 100%/19  | Total:  2h 10m | Avg:  6m 50s | Max: 10m 59s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 53m | Avg: 28m 19s | Max: 32m 29s | Hits: 363%/7384  
  🟩 NVHPC              Pass: 100%/2   | Total: 29m 40s | Avg: 14m 50s | Max: 14m 54s
🟩 gpu
  🟩 rtx4090            Pass: 100%/8   | Total:  1h 06m | Avg:  8m 20s | Max: 10m 59s
  🟩 v100               Pass: 100%/34  | Total:  5h 11m | Avg:  9m 09s | Max: 32m 29s | Hits: 363%/7384  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  5h 30m | Avg:  8m 55s | Max: 32m 29s | Hits: 363%/7384  
  🟩 TestCPU            Pass: 100%/2   | Total: 15m 54s | Avg:  7m 57s | Max:  8m 07s
  🟩 TestGPU            Pass: 100%/3   | Total: 32m 02s | Avg: 10m 40s | Max: 10m 59s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  4m 57s | Avg:  4m 57s | Max:  4m 57s
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  3h 14m | Avg:  9m 42s | Max: 30m 17s | Hits: 363%/5538  
  🟩 20                 Pass: 100%/20  | Total:  2h 46m | Avg:  8m 20s | Max: 32m 29s | Hits: 363%/1846

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 6m 37s | Avg: 3m 18s | Max: 4m 36s

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  6m 37s | Avg:  3m 18s | Max:  4m 36s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total:  6m 37s | Avg:  3m 18s | Max:  4m 36s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total:  6m 37s | Avg:  3m 18s | Max:  4m 36s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  6m 37s | Avg:  3m 18s | Max:  4m 36s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  6m 37s | Avg:  3m 18s | Max:  4m 36s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  6m 37s | Avg:  3m 18s | Max:  4m 36s
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total:  6m 37s | Avg:  3m 18s | Max:  4m 36s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 01s | Avg:  2m 01s | Max:  2m 01s
  🟩 Test               Pass: 100%/1   | Total:  4m 36s | Avg:  4m 36s | Max:  4m 36s

🟩 python: Pass: 100%/1 | Total: 26m 23s | Avg: 26m 23s | Max: 26m 23s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 26m 23s | Avg: 26m 23s | Max: 26m 23s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 26m 23s | Avg: 26m 23s | Max: 26m 23s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 26m 23s | Avg: 26m 23s | Max: 26m 23s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 26m 23s | Avg: 26m 23s | Max: 26m 23s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 26m 23s | Avg: 26m 23s | Max: 26m 23s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 26m 23s | Avg: 26m 23s | Max: 26m 23s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 26m 23s | Avg: 26m 23s | Max: 26m 23s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 26m 23s | Avg: 26m 23s | Max: 26m 23s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 89)

#	Runner
65	`linux-amd64-cpu16`
8	`windows-amd64-cpu16`
6	`linux-amd64-gpu-rtxa6000-latest-1`
4	`linux-arm64-cpu16`
3	`linux-amd64-gpu-rtx4090-latest-1`
2	`linux-amd64-gpu-rtx2080-latest-1`
1	`linux-amd64-gpu-h100-latest-1`

cub/cub/device/dispatch/dispatch_common.cuh

miscco

I love this so much, thanks a bunch for looking into cleaning that mess up 💚

cub/benchmarks/bench/radix_sort/pairs.cu

cub/benchmarks/bench/select/unique.cu

cub/cub/device/device_copy.cuh

cub/cub/device/dispatch/dispatch_transform.cuh

bernhardmgruber

Great improvement of readability!

Generally, now that we have good names, we could inline a lot of the flags directly into template instantiations, turning:

constexpr auto option_name = true;
DispatchYYY<..., option_name>

directly into;

DispatchYYY<..., option_name::value>

I think a lot of the former code was written so that the option name was visible, but that's no longer needed.

cub/benchmarks/bench/select/flagged.cu

cub/cub/device/device_memcpy.cuh

cub/cub/device/dispatch/dispatch_adjacent_difference.cuh

cub/cub/device/dispatch/dispatch_batch_memcpy.cuh

cub/cub/device/dispatch/dispatch_common.cuh

cub/test/catch2_test_device_transform.cu

elstehle · 2025-02-03T15:27:57Z

Great improvement of readability!

Generally, now that we have good names, we could inline a lot of the flags directly into template instantiations, turning:
constexpr auto option_name = true;
DispatchYYY<..., option_name>
directly into;
DispatchYYY<..., option_name::value>
I think a lot of the former code was written so that the option name was visible, but that's no longer needed.

When I started the refactoring, I was debating myself whether I should do it that way in the first place. I thought it might be more readable with named constants. After the switch, however, I'm convinced your suggestion is the way to go.

Please give this another good look. My brain is a bit foggy during big refactorings like this and I would appreciate another pair of fresh eyes.

cub/benchmarks/bench/copy/memcpy.cu

cub/benchmarks/bench/adjacent_difference/subtract_left.cu

…mplate-params

github-actions · 2025-02-03T19:25:45Z

🟩 CI finished in 1h 45m: Pass: 100%/90 | Total: 2d 15h | Avg: 42m 32s | Max: 1h 17m | Hits: 241%/12742

🟩 cub: Pass: 100%/44 | Total: 1d 15h | Avg: 53m 38s | Max: 1h 17m | Hits: 310%/3512

🟩 cpu
  🟩 amd64              Pass: 100%/42  | Total:  1d 13h | Avg: 53m 22s | Max:  1h 17m | Hits: 310%/3512  
  🟩 arm64              Pass: 100%/2   | Total:  1h 58m | Avg: 59m 13s | Max: 59m 46s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  4h 46m | Avg: 57m 23s | Max:  1h 05m | Hits: 311%/878   
  🟩 12.5               Pass: 100%/2   | Total:  2h 18m | Avg:  1h 09m | Max:  1h 10m
  🟩 12.8               Pass: 100%/37  | Total:  1d 08h | Avg: 52m 17s | Max:  1h 17m | Hits: 309%/2634  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  2h 01m | Avg:  1h 00m | Max:  1h 01m
  🟩 nvcc12.0           Pass: 100%/5   | Total:  4h 46m | Avg: 57m 23s | Max:  1h 05m | Hits: 311%/878   
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 18m | Avg:  1h 09m | Max:  1h 10m
  🟩 nvcc12.8           Pass: 100%/35  | Total:  1d 06h | Avg: 51m 48s | Max:  1h 17m | Hits: 309%/2634  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  2h 01m | Avg:  1h 00m | Max:  1h 01m
  🟩 nvcc               Pass: 100%/42  | Total:  1d 13h | Avg: 53m 17s | Max:  1h 17m | Hits: 310%/3512  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  3h 35m | Avg: 53m 58s | Max: 54m 35s
  🟩 Clang15            Pass: 100%/2   | Total:  2h 02m | Avg:  1h 01m | Max:  1h 01m
  🟩 Clang16            Pass: 100%/2   | Total:  1h 55m | Avg: 57m 32s | Max:  1h 00m
  🟩 Clang17            Pass: 100%/2   | Total:  1h 52m | Avg: 56m 10s | Max: 59m 13s
  🟩 Clang18            Pass: 100%/7   | Total:  5h 39m | Avg: 48m 28s | Max:  1h 01m
  🟩 GCC7               Pass: 100%/2   | Total:  1h 58m | Avg: 59m 10s | Max:  1h 01m
  🟩 GCC8               Pass: 100%/1   | Total: 55m 14s | Avg: 55m 14s | Max: 55m 14s
  🟩 GCC9               Pass: 100%/2   | Total:  1h 53m | Avg: 56m 49s | Max: 58m 01s
  🟩 GCC10              Pass: 100%/2   | Total:  1h 54m | Avg: 57m 22s | Max: 59m 45s
  🟩 GCC11              Pass: 100%/2   | Total:  2h 04m | Avg:  1h 02m | Max:  1h 03m
  🟩 GCC12              Pass: 100%/2   | Total:  2h 04m | Avg:  1h 02m | Max:  1h 02m
  🟩 GCC13              Pass: 100%/10  | Total:  6h 17m | Avg: 37m 42s | Max:  1h 03m
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 17m | Avg:  1h 08m | Max:  1h 11m | Hits: 309%/1756  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  2h 29m | Avg:  1h 14m | Max:  1h 17m | Hits: 310%/1756  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 18m | Avg:  1h 09m | Max:  1h 10m
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total: 15h 05m | Avg: 53m 16s | Max:  1h 01m
  🟩 GCC                Pass: 100%/21  | Total: 17h 08m | Avg: 48m 59s | Max:  1h 03m
  🟩 MSVC               Pass: 100%/4   | Total:  4h 47m | Avg:  1h 11m | Max:  1h 17m | Hits: 310%/3512  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 18m | Avg:  1h 09m | Max:  1h 10m
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 51m 11s | Avg: 25m 35s | Max: 26m 27s
  🟩 rtx2080            Pass: 100%/34  | Total:  1d 10h | Avg:  1h 00m | Max:  1h 17m | Hits: 310%/3512  
  🟩 rtxa6000           Pass: 100%/8   | Total:  3h 58m | Avg: 29m 47s | Max: 59m 49s
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  1d 12h | Avg: 59m 44s | Max:  1h 17m | Hits: 310%/3512  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 20m 46s | Avg: 20m 46s | Max: 20m 46s
  🟩 GraphCapture       Pass: 100%/1   | Total: 14m 40s | Avg: 14m 40s | Max: 14m 40s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 12m | Avg: 24m 12s | Max: 24m 44s
  🟩 TestGPU            Pass: 100%/2   | Total: 41m 23s | Avg: 20m 41s | Max: 21m 48s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 51m 11s | Avg: 25m 35s | Max: 26m 27s
  🟩 90;90a;100         Pass: 100%/1   | Total:  1h 01m | Avg:  1h 01m | Max:  1h 01m
🟩 std
  🟩 17                 Pass: 100%/20  | Total: 20h 21m | Avg:  1h 01m | Max:  1h 12m | Hits: 310%/2634  
  🟩 20                 Pass: 100%/24  | Total: 18h 58m | Avg: 47m 26s | Max:  1h 17m | Hits: 307%/878

🟩 thrust: Pass: 100%/43 | Total: 23h 55m | Avg: 33m 23s | Max: 1h 01m | Hits: 215%/9230

🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 38m 17s | Avg: 19m 08s | Max: 26m 31s
🟩 cpu
  🟩 amd64              Pass: 100%/41  | Total: 22h 57m | Avg: 33m 35s | Max:  1h 01m | Hits: 215%/9230  
  🟩 arm64              Pass: 100%/2   | Total: 58m 40s | Avg: 29m 20s | Max: 31m 08s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  3h 00m | Avg: 36m 09s | Max: 52m 26s | Hits: 178%/1846  
  🟩 12.5               Pass: 100%/2   | Total:  1h 53m | Avg: 56m 44s | Max:  1h 00m
  🟩 12.8               Pass: 100%/36  | Total: 19h 01m | Avg: 31m 42s | Max:  1h 01m | Hits: 225%/7384  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 54m 34s | Avg: 27m 17s | Max: 28m 07s
  🟩 nvcc12.0           Pass: 100%/5   | Total:  3h 00m | Avg: 36m 09s | Max: 52m 26s | Hits: 178%/1846  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 53m | Avg: 56m 44s | Max:  1h 00m
  🟩 nvcc12.8           Pass: 100%/34  | Total: 18h 07m | Avg: 31m 58s | Max:  1h 01m | Hits: 225%/7384  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 54m 34s | Avg: 27m 17s | Max: 28m 07s
  🟩 nvcc               Pass: 100%/41  | Total: 23h 01m | Avg: 33m 41s | Max:  1h 01m | Hits: 215%/9230  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  2h 07m | Avg: 31m 56s | Max: 35m 22s
  🟩 Clang15            Pass: 100%/2   | Total:  1h 06m | Avg: 33m 19s | Max: 34m 43s
  🟩 Clang16            Pass: 100%/2   | Total:  1h 03m | Avg: 31m 42s | Max: 32m 43s
  🟩 Clang17            Pass: 100%/2   | Total:  1h 02m | Avg: 31m 01s | Max: 31m 11s
  🟩 Clang18            Pass: 100%/7   | Total:  2h 44m | Avg: 23m 30s | Max: 32m 43s
  🟩 GCC7               Pass: 100%/2   | Total:  1h 08m | Avg: 34m 10s | Max: 34m 25s
  🟩 GCC8               Pass: 100%/1   | Total: 31m 18s | Avg: 31m 18s | Max: 31m 18s
  🟩 GCC9               Pass: 100%/2   | Total:  1h 04m | Avg: 32m 11s | Max: 33m 08s
  🟩 GCC10              Pass: 100%/2   | Total:  1h 05m | Avg: 32m 44s | Max: 34m 56s
  🟩 GCC11              Pass: 100%/2   | Total:  1h 07m | Avg: 33m 59s | Max: 35m 47s
  🟩 GCC12              Pass: 100%/2   | Total:  1h 14m | Avg: 37m 23s | Max: 37m 40s
  🟩 GCC13              Pass: 100%/8   | Total:  3h 17m | Avg: 24m 44s | Max: 38m 24s
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 50m | Avg: 55m 20s | Max: 58m 15s | Hits: 177%/3692  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  2h 37m | Avg: 52m 22s | Max:  1h 01m | Hits: 241%/5538  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 53m | Avg: 56m 44s | Max:  1h 00m
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  8h 04m | Avg: 28m 29s | Max: 35m 22s
  🟩 GCC                Pass: 100%/19  | Total:  9h 30m | Avg: 30m 00s | Max: 38m 24s
  🟩 MSVC               Pass: 100%/5   | Total:  4h 27m | Avg: 53m 33s | Max:  1h 01m | Hits: 215%/9230  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 53m | Avg: 56m 44s | Max:  1h 00m
🟩 gpu
  🟩 rtx2080            Pass: 100%/33  | Total: 19h 54m | Avg: 36m 11s | Max:  1h 01m | Hits: 179%/5538  
  🟩 rtx4090            Pass: 100%/10  | Total:  4h 01m | Avg: 24m 08s | Max:  1h 00m | Hits: 270%/3692  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total: 22h 31m | Avg: 36m 31s | Max:  1h 01m | Hits: 178%/7384  
  🟩 TestCPU            Pass: 100%/3   | Total: 50m 53s | Avg: 16m 57s | Max: 35m 05s | Hits: 365%/1846  
  🟩 TestGPU            Pass: 100%/3   | Total: 33m 45s | Avg: 11m 15s | Max: 11m 46s
🟩 sm
  🟩 90;90a;100         Pass: 100%/1   | Total: 38m 24s | Avg: 38m 24s | Max: 38m 24s
🟩 std
  🟩 17                 Pass: 100%/20  | Total: 12h 20m | Avg: 37m 02s | Max:  1h 01m | Hits: 179%/5538  
  🟩 20                 Pass: 100%/21  | Total: 10h 56m | Avg: 31m 16s | Max:  1h 00m | Hits: 270%/3692

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 7m 13s | Avg: 3m 36s | Max: 4m 48s

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  7m 13s | Avg:  3m 36s | Max:  4m 48s
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total:  7m 13s | Avg:  3m 36s | Max:  4m 48s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total:  7m 13s | Avg:  3m 36s | Max:  4m 48s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  7m 13s | Avg:  3m 36s | Max:  4m 48s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  7m 13s | Avg:  3m 36s | Max:  4m 48s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  7m 13s | Avg:  3m 36s | Max:  4m 48s
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total:  7m 13s | Avg:  3m 36s | Max:  4m 48s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 25s | Avg:  2m 25s | Max:  2m 25s
  🟩 Test               Pass: 100%/1   | Total:  4m 48s | Avg:  4m 48s | Max:  4m 48s

🟩 python: Pass: 100%/1 | Total: 26m 01s | Avg: 26m 01s | Max: 26m 01s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 26m 01s | Avg: 26m 01s | Max: 26m 01s
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total: 26m 01s | Avg: 26m 01s | Max: 26m 01s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total: 26m 01s | Avg: 26m 01s | Max: 26m 01s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 26m 01s | Avg: 26m 01s | Max: 26m 01s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 26m 01s | Avg: 26m 01s | Max: 26m 01s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 26m 01s | Avg: 26m 01s | Max: 26m 01s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 26m 01s | Avg: 26m 01s | Max: 26m 01s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 26m 01s | Avg: 26m 01s | Max: 26m 01s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 90)

#	Runner
65	`linux-amd64-cpu16`
9	`windows-amd64-cpu16`
6	`linux-amd64-gpu-rtxa6000-latest-1`
4	`linux-arm64-cpu16`
3	`linux-amd64-gpu-rtx4090-latest-1`
2	`linux-amd64-gpu-rtx2080-latest-1`
1	`linux-amd64-gpu-h100-latest-1`

miscco

Some minor nits, feel free to ignore

cub/cub/device/dispatch/dispatch_adjacent_difference.cuh

cub/cub/device/dispatch/dispatch_common.cuh

elstehle · 2025-02-04T09:33:05Z

Some minor nits, feel free to ignore

Thanks! I'll address these in a follow-up PR.

elstehle added 7 commits January 31, 2025 07:56

bool-to-enum for adjacent difference

32768fd

bool-to-enum for batched copy

aa44584

bool-to-enum for radix sort

a4d292c

bool-to-enum for segmented radix sort

46098d9

fixes few compilation issues

b1e7f6f

bool-to-enum for segmented sort

d5258a7

bool-to-enum for select & partition

d25617d

elstehle requested review from a team as code owners February 2, 2025 09:59

elstehle requested a review from bernhardmgruber February 2, 2025 09:59

elstehle added 4 commits February 2, 2025 02:14

fixes thrust adjacent difference

ef82bb0

fixes thrust usage of scan

d97e58f

documents common enum classes

d2ddfb8

fixes benchmarks

4775195

fixes msvc

d0bedfb

elstehle added the breaking Breaking change label Feb 3, 2025

bernhardmgruber reviewed Feb 3, 2025

View reviewed changes

cub/cub/device/dispatch/dispatch_common.cuh Outdated Show resolved Hide resolved

miscco reviewed Feb 3, 2025

View reviewed changes

cub/benchmarks/bench/radix_sort/pairs.cu Outdated Show resolved Hide resolved

cub/benchmarks/bench/select/unique.cu Outdated Show resolved Hide resolved

cub/cub/device/device_copy.cuh Outdated Show resolved Hide resolved

cub/cub/device/dispatch/dispatch_transform.cuh Show resolved Hide resolved

bernhardmgruber reviewed Feb 3, 2025

View reviewed changes

addresses review comments

4e19ef5

elstehle requested review from miscco and bernhardmgruber February 3, 2025 16:50

bernhardmgruber approved these changes Feb 3, 2025

View reviewed changes

cub/benchmarks/bench/copy/memcpy.cu Outdated Show resolved Hide resolved

cub/benchmarks/bench/adjacent_difference/subtract_left.cu Outdated Show resolved Hide resolved

elstehle added 2 commits February 3, 2025 09:31

inline enum usage in benches

b0915b7

Merge remote-tracking branch 'upstream/main' into enh/bool-to-enum-te…

1e5ca6d

…mplate-params

elstehle changed the title ~~Replaces bool template parameters on Dispatch* class tempaltes to use enum class~~ Replaces bool template parameters on Dispatch* class templates to use enum class Feb 4, 2025

miscco approved these changes Feb 4, 2025

View reviewed changes

cub/cub/device/dispatch/dispatch_adjacent_difference.cuh Show resolved Hide resolved

cub/cub/device/dispatch/dispatch_common.cuh Show resolved Hide resolved

cub/cub/device/dispatch/dispatch_common.cuh Show resolved Hide resolved

elstehle merged commit 6b8ddb2 into NVIDIA:main Feb 4, 2025
103 of 106 checks passed

elstehle mentioned this pull request Feb 6, 2025

Minor cleanups following bool-to-enum template parameter PR #3716

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replaces bool template parameters on `Dispatch*` class templates to use `enum class` #3643

Replaces bool template parameters on `Dispatch*` class templates to use `enum class` #3643

elstehle commented Feb 2, 2025 •

edited

Loading

github-actions bot commented Feb 2, 2025

🟨 cub: Pass: 90%/44 | Total: 21h 51m | Avg: 29m 48s | Max: 43m 44s

🟨 thrust: Pass: 90%/42 | Total: 6h 08m | Avg: 8m 46s | Max: 32m 22s

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 6m 50s | Avg: 3m 25s | Max: 4m 46s

🟩 python: Pass: 100%/1 | Total: 25m 27s | Avg: 25m 27s | Max: 25m 27s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 89)

github-actions bot commented Feb 3, 2025

🟩 cub: Pass: 100%/44 | Total: 7h 45m | Avg: 10m 34s | Max: 32m 59s | Hits: 530%/3524

🟩 thrust: Pass: 100%/42 | Total: 6h 18m | Avg: 9m 00s | Max: 32m 29s | Hits: 363%/7384

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 6m 37s | Avg: 3m 18s | Max: 4m 36s

🟩 python: Pass: 100%/1 | Total: 26m 23s | Avg: 26m 23s | Max: 26m 23s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 89)

miscco left a comment

bernhardmgruber left a comment

elstehle commented Feb 3, 2025 •

edited

Loading

github-actions bot commented Feb 3, 2025

🟩 cub: Pass: 100%/44 | Total: 1d 15h | Avg: 53m 38s | Max: 1h 17m | Hits: 310%/3512

🟩 thrust: Pass: 100%/43 | Total: 23h 55m | Avg: 33m 23s | Max: 1h 01m | Hits: 215%/9230

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 7m 13s | Avg: 3m 36s | Max: 4m 48s

🟩 python: Pass: 100%/1 | Total: 26m 01s | Avg: 26m 01s | Max: 26m 01s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 90)

miscco left a comment

elstehle commented Feb 4, 2025

Replaces bool template parameters on Dispatch* class templates to use enum class #3643

Replaces bool template parameters on Dispatch* class templates to use enum class #3643

Conversation

elstehle commented Feb 2, 2025 • edited Loading

Description

github-actions bot commented Feb 2, 2025

🟨 cub: Pass: 90%/44 | Total: 21h 51m | Avg: 29m 48s | Max: 43m 44s

🟨 thrust: Pass: 90%/42 | Total: 6h 08m | Avg: 8m 46s | Max: 32m 22s

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 6m 50s | Avg: 3m 25s | Max: 4m 46s

🟩 python: Pass: 100%/1 | Total: 25m 27s | Avg: 25m 27s | Max: 25m 27s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 89)

github-actions bot commented Feb 3, 2025

🟩 cub: Pass: 100%/44 | Total: 7h 45m | Avg: 10m 34s | Max: 32m 59s | Hits: 530%/3524

🟩 thrust: Pass: 100%/42 | Total: 6h 18m | Avg: 9m 00s | Max: 32m 29s | Hits: 363%/7384

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 6m 37s | Avg: 3m 18s | Max: 4m 36s

🟩 python: Pass: 100%/1 | Total: 26m 23s | Avg: 26m 23s | Max: 26m 23s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 89)

miscco left a comment

Choose a reason for hiding this comment

bernhardmgruber left a comment

Choose a reason for hiding this comment

elstehle commented Feb 3, 2025 • edited Loading

github-actions bot commented Feb 3, 2025

🟩 cub: Pass: 100%/44 | Total: 1d 15h | Avg: 53m 38s | Max: 1h 17m | Hits: 310%/3512

🟩 thrust: Pass: 100%/43 | Total: 23h 55m | Avg: 33m 23s | Max: 1h 01m | Hits: 215%/9230

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 7m 13s | Avg: 3m 36s | Max: 4m 48s

🟩 python: Pass: 100%/1 | Total: 26m 01s | Avg: 26m 01s | Max: 26m 01s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 90)

miscco left a comment

Choose a reason for hiding this comment

elstehle commented Feb 4, 2025

Replaces bool template parameters on `Dispatch*` class templates to use `enum class` #3643

Replaces bool template parameters on `Dispatch*` class templates to use `enum class` #3643

elstehle commented Feb 2, 2025 •

edited

Loading

elstehle commented Feb 3, 2025 •

edited

Loading