-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport to 2.8: Fix transform_iterator<identity> (#3652) and Deprecate thrust::identity (#3649) #3693
Merged
bernhardmgruber
merged 5 commits into
NVIDIA:branch/2.8.x
from
bernhardmgruber:backport_depr_identity
Feb 5, 2025
Merged
Backport to 2.8: Fix transform_iterator<identity> (#3652) and Deprecate thrust::identity (#3649) #3693
bernhardmgruber
merged 5 commits into
NVIDIA:branch/2.8.x
from
bernhardmgruber:backport_depr_identity
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NVIDIA#3652) Thrust's transform_iterator relied on thrust::identity<T>::result_type via result_of_adaptable_function to avoid dangling references. However, thrust::identity<void>, cuda::std::identity, and the placeholder expression _1 have the same issue without a workaround. This change centralizes and adds workarounds for all of these by introducing a new trait thrust::detail::transform_iterator_reference, which decays the return value type of any of the aforementioned function objects.
Co-authored-by: Michael Schellenberger Costa <[email protected]>
miscco
approved these changes
Feb 5, 2025
🟨 CI finished in 1h 12m: Pass: 99%/169 | Total: 1d 21h | Avg: 16m 16s | Max: 1h 10m | Hits: 523%/20825
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 169)
# | Runner |
---|---|
125 | linux-amd64-cpu16 |
14 | windows-amd64-cpu16 |
10 | linux-amd64-gpu-rtx2080-latest-1 |
10 | linux-arm64-cpu16 |
6 | linux-amd64-gpu-rtxa6000-latest-1 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
1 | linux-amd64-gpu-h100-latest-1 |
miscco
approved these changes
Feb 5, 2025
elstehle
approved these changes
Feb 5, 2025
🟨 CI finished in 1h 26m: Pass: 98%/169 | Total: 3d 03h | Avg: 26m 46s | Max: 1h 09m | Hits: 442%/20825
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 169)
# | Runner |
---|---|
125 | linux-amd64-cpu16 |
14 | windows-amd64-cpu16 |
10 | linux-amd64-gpu-rtx2080-latest-1 |
10 | linux-arm64-cpu16 |
6 | linux-amd64-gpu-rtxa6000-latest-1 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
1 | linux-amd64-gpu-h100-latest-1 |
🟨 CI finished in 2h 27m: Pass: 99%/169 | Total: 3d 03h | Avg: 26m 56s | Max: 1h 09m | Hits: 442%/20825
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 169)
# | Runner |
---|---|
125 | linux-amd64-cpu16 |
14 | windows-amd64-cpu16 |
10 | linux-amd64-gpu-rtx2080-latest-1 |
10 | linux-arm64-cpu16 |
6 | linux-amd64-gpu-rtxa6000-latest-1 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
1 | linux-amd64-gpu-h100-latest-1 |
🟩 CI finished in 3h 03m: Pass: 100%/169 | Total: 3d 03h | Avg: 26m 57s | Max: 1h 09m | Hits: 442%/20825
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 169)
# | Runner |
---|---|
125 | linux-amd64-cpu16 |
14 | windows-amd64-cpu16 |
10 | linux-amd64-gpu-rtx2080-latest-1 |
10 | linux-arm64-cpu16 |
6 | linux-amd64-gpu-rtxa6000-latest-1 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
1 | linux-amd64-gpu-h100-latest-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following PRs: